Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1166332pxb; Fri, 21 Jan 2022 11:15:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJwvZ92XGEYevbbzOhcBerby3YNxB6c8/Jk+IB8FC1NJJHMIESvyQtUm3Wiol0YoawA1d0cY X-Received: by 2002:a17:902:ce8b:b0:14b:9b9:73fe with SMTP id f11-20020a170902ce8b00b0014b09b973femr5199789plg.130.1642792539868; Fri, 21 Jan 2022 11:15:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642792539; cv=none; d=google.com; s=arc-20160816; b=RFIINRE+fIERS77mJKWw814hMk0myLglfsqROUGv4/YnaHYh7VHr9npOmwfsH/Mxbj /uu3DoCm7jvYXAndeJp/WWHM2uQ6Iv8ZnmTfxAlhKqMTuGhYL7Ep6Fp/3EtfTVQ2rr+C Gu8Afbw7h9aGr4rNzYWNRan7HyWD2pIuyrke5UcIW/zk/sQXL0emiEHrUlyobvw73M2O +xDJwsNKkCZstprHjz1q1m0VvJGei9xQYHZhtjF2PgHScvZnt6DgLKJyRfYlx2MjMAjk pGAJC6uVwypUGsI1tX+tscZf6dWmngt2ft+i0vX+tdbkjA0svjuJkdhgskE1e8Fp73W1 W/aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=KZuC6TmXhJQVSeFuSv1mMMFPmjV47Ffvc9/epCoTyMw=; b=AnArgAVOhYuiT30N5bIi3gzmBioiu8cJi41xYIy908/CfOcZbo6BQIl64tFwsXeoGn RPw2SrqpNQgkcu9UUaWqeB1zFULq9aCGvZxiIIVIWq73bHXS3UBsEOCEu7QdD3Vl3a6U lhoqcjU7w++n/NJuJWtWtxd4miaJkxZcJSesHZFJjd45r6q5cG1eWcOnPDD2Kndaschq YKj0uMfK0FLRjERidbF/pimDxaj3EcBwu2Hdm5b7XyzmrqdgWhIYHGK6i/Mhw3bFLWFe Oa2dxtm3kyl1A+IAbTFZ1Y4fNwZ6hTa9Z/Nfoo/g2kOAUieB4wNqPDCSH6V7yPjLOfei xCkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b="lo/qsE3O"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v185si1849508pgd.469.2022.01.21.11.15.28; Fri, 21 Jan 2022 11:15:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b="lo/qsE3O"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349595AbiASNes (ORCPT + 99 others); Wed, 19 Jan 2022 08:34:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238516AbiASNer (ORCPT ); Wed, 19 Jan 2022 08:34:47 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACC01C061574; Wed, 19 Jan 2022 05:34:46 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2F974B8189A; Wed, 19 Jan 2022 13:34:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B128C340E9; Wed, 19 Jan 2022 13:34:43 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="lo/qsE3O" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1642599280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KZuC6TmXhJQVSeFuSv1mMMFPmjV47Ffvc9/epCoTyMw=; b=lo/qsE3OdM57p2UPmTM4vhgsJTwEd33zm6WXgphvGllfKgyMDMYAL/ekg+CEXfP4YXyYY6 etdTZ/wfi5hqt1w9QzeK76g8zOqVnVlqs9ATDpWRgNPoTvm89wvC/T6qXWD6iOH6npuQGi bjRJctbJQH6hIDE37t1E6Rfmu4qT9TE= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id d4afa98c (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 19 Jan 2022 13:34:40 +0000 (UTC) Received: by mail-yb1-f173.google.com with SMTP id m1so7467250ybo.5; Wed, 19 Jan 2022 05:34:40 -0800 (PST) X-Gm-Message-State: AOAM530FrciVPFIeptolOo40eZbvW2d9OWsxNCvGTVpcDTYc1Zi78lNP cygai3szlc/ZVqnlJaUgwphmib81FCBXLRx0MSg= X-Received: by 2002:a05:6902:709:: with SMTP id k9mr15518165ybt.113.1642599277841; Wed, 19 Jan 2022 05:34:37 -0800 (PST) MIME-Version: 1.0 References: <20220119100615.5059-1-miles.chen@mediatek.com> In-Reply-To: From: "Jason A. Donenfeld" Date: Wed, 19 Jan 2022 14:34:27 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] lib/crypto: blake2s: fix a CFI failure To: Ard Biesheuvel Cc: Miles Chen , "David S. Miller" , Greg Kroah-Hartman , Herbert Xu , Linux ARM , Linux Crypto Mailing List , Linux Kernel Mailing List , linux-mediatek@lists.infradead.org, Matthias Brugger , Nathan Chancellor , Nick Desaulniers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 19, 2022 at 1:19 PM Ard Biesheuvel wrote: > > I'd prefer it if we could avoid magic #define's like this. I'll send something that just replaces it with a simple bool.