Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1184472pxb; Fri, 21 Jan 2022 11:43:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJzp8TnToWYvc4awHjzUF+RQQy+rPtwrN1oKQ7VlcNC2xjvTdlt865DT/nyUp9U1DLMLlIn5 X-Received: by 2002:a17:902:8498:b0:14a:1b37:9f2b with SMTP id c24-20020a170902849800b0014a1b379f2bmr5490624plo.85.1642794195776; Fri, 21 Jan 2022 11:43:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642794195; cv=none; d=google.com; s=arc-20160816; b=y05XYBoAPDUyvsH44RVXiz1Vu0CdiLHdIepwO+Ya3unfGJP2n37CXLM2YDpCy28/cA GIOneTAPAD3hbtkDfwe4AdGukhadKFqS1wEamu3k0Yp2PAb6MVkYF59Colj5sojCV+m0 k7fvwCQ5t2YzShp2SviOuYQzSdcyp+no/gq7qS9od58NlfGH26shjKFFibRLrFQ2PFI3 esmw+FRPdSyeQDgc53zkdA2srSjEgRl6KDcz2c5woeUixU6YIOdbdAeL49yRWgU/uKbw guoESJDopW7jyaXR5FmIi2bELQwVJOn+P/XBKCOXYuoud+WDG3sTJ/uhy2i2LIiwXQXr 7ZSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=lnVyVLjDvCI437BvvoNWSQiKn/b8WGK/JLTRlR1kpf8=; b=i485vcCjdK/2q8AxqbPIA1+0jH5MfyD294llJME3qoUxWIHcFCmEIISGvo46xJCQGU z6053HcEgDQjvC8VvxKPT1r/02F3YPZ3ZrXUfPnYtX93qf6cPmRmm/riRcJTJLQwQGdk T1U/XiEst3q8Feo6SCCXU8qy8U1IBBqBHdcwrnbNOq+GiPSyv6+sQkDX/ScWjlehUJc9 bYU1HrFjDKhgjxH9BuSctFxDm1xHw++9sId4GDQrV0j/Ruv/JVY+IS+kH2GIaPM7+SNT CaP/XscE6L/afHy5rzcEFdSTLB4PKfW0lOMGDoVULj2HfJVU8RlvDyc62cBSsfkYYKWt iwlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ipn7wi2g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o6si1391819pjt.142.2022.01.21.11.43.04; Fri, 21 Jan 2022 11:43:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ipn7wi2g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356012AbiASP7k (ORCPT + 99 others); Wed, 19 Jan 2022 10:59:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356084AbiASP7c (ORCPT ); Wed, 19 Jan 2022 10:59:32 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FD3EC061574; Wed, 19 Jan 2022 07:59:32 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 7184DCE1D3F; Wed, 19 Jan 2022 15:59:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 544CBC004E1; Wed, 19 Jan 2022 15:59:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642607968; bh=V7LGtmzqvJJFqa4HA4DOO3BH4xLnT72+9Ue/Qr2CyZM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ipn7wi2gM6AxT8HMkfwiBF51Du6zCECt9n+Es4TK6ShL5vt2XPVVEvXbou1gfBMBE 8JmgWHLHYe2KYpe9ZOcbRzEEFL61z9+t9eIFzUIl2M29hfAqU+5VpehkA1h+gJk5NQ L0B/jFgqvtzddIhNxuLC5yiWkARk2XWbLuMkIJY3DUNrC55yOQYVjNfkggLWqQC8jx 0e+h3CQ1l4TdGV68J2rU+ang+msL+41lGyCyBUc/fx2selJq51r1cgswHgxqxBnKdx j2/qoQyKQ1bNI9nSKEpuARdtyGkndNXzzTmRH7AHU90DhgY0yEPjsNDkeARgFzXJzn MxKx5pbcxRdXw== Date: Wed, 19 Jan 2022 07:59:27 -0800 From: Jakub Kicinski To: cgel.zte@gmail.com Cc: chi.minghao@zte.com.cn, davem@davemloft.net, dsahern@gmail.com, dsahern@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org, zealci@zte.com.cn Subject: Re: [PATCH] net/ipv6: remove redundant err variable Message-ID: <20220119075927.0d2c4a21@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20220119055557.931265-1-chi.minghao@zte.com.cn> References: <20220118192804.1032c172@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <20220119055557.931265-1-chi.minghao@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Jan 2022 05:55:57 +0000 cgel.zte@gmail.com wrote: > There are more than 3,000 numbers retrieved by the rules I wrote. > Of course, many of these 3,000 are false positives, and maybe > there are 300 patches.I wrote this rule similar to returnvar.cocci. Can you start by improving returnvar.cocci so it catches all the cases? Then make sure your patches build and don't introduce formatting problems. Then post them.