Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 0/4] Watchdog: sp5100_tco: Replace cd6h/cd7h port I/O
 accesses with MMIO accesses
To:     Jean Delvare <jdelvare@suse.de>
Cc:     linux@roeck-us.net, linux-watchdog@vger.kernel.org,
        jdelvare@suse.com, linux-i2c@vger.kernel.org, wsa@kernel.org,
        andy.shevchenko@gmail.com, rafael.j.wysocki@intel.com,
        linux-kernel@vger.kernel.org, wim@linux-watchdog.org,
        rrichter@amd.com, thomas.lendacky@amd.com,
        Nehal-bakulchandra.Shah@amd.com, Basavaraj.Natikar@amd.com,
        Shyam-sundar.S-k@amd.com, Mario.Limonciello@amd.com
References: <20220118202234.410555-1-terry.bowman@amd.com>
 <20220119163012.4274665d@endymion>
From:   Terry Bowman <Terry.Bowman@amd.com>
Message-ID: <dda39f1f-b683-35ac-d810-d4759c4f8448@amd.com>
Date:   Wed, 19 Jan 2022 11:33:55 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20220119163012.4274665d@endymion>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmExQkNHdDlKbkxiMTZRaHZFLy8wVXh2eEdxalZ6ZmxPamJtVE1hTDNCSmhW?=
 =?utf-8?B?Z210NDFDTmp4cVpudW9MSEszbFgrenpDb2hRaFV0N0ZHdGxXUS96NEYyQlZq?=
 =?utf-8?B?NzBubmt0TGhxYjlSZ2pGdUhLOVVlakZQMWxWMDdWbVNPYTVCTlAxcVdXbDRK?=
 =?utf-8?B?aS9KdFZ6WlI3Q0crakx1OHhKQUJ3Q1V3Wm0ydjUwOHBmKzhIbFpqMWxmanRh?=
 =?utf-8?B?TzVDVUlVeWxHS1J5RFdZRVdjYUdaWUx1MlNKd2tVK1l3aGxDSy9ZdklBSEEv?=
 =?utf-8?B?QUF6aGxkU1ZGTlRRV3QzS1RDZ01OUUNMcUUxYUxrZnhRY244R0xYekZidVk2?=
 =?utf-8?B?WVNudldWa3oxYUp2MW9vNUUvbUZoeEVIVHZpaVBqc1FNNjErZzNTL3lMb2RZ?=
 =?utf-8?B?SnZqaFQ5Nkc5cGNRWVprR2hRNmcxdjVtSjI0K3grVjRMTWsxRGZvNkdvaHo1?=
 =?utf-8?B?WGNhWE5qaTRBcnE5WCswTnZhVzRzT0VvN0pPcTRVUW5WU2lOaU11SFArOXJ1?=
 =?utf-8?B?Z3BjWHpQd2VBUkRhSGdnVE1KVlZLc2gwbEhSUUdjNlFUc0xKSE9Jamw4Umkv?=
 =?utf-8?B?MW1IaWRYRk94dzVodER6T1k5aHMxS2hPMHJvMnFkUlV4NmRFZS9ETHByMk9G?=
 =?utf-8?B?YjUrZFdNeVhFTW96U0JrZXNKd051Rm5iZVpWeVUwTWR4MXVWbjJ5UUxvQTV0?=
 =?utf-8?B?Y3RrTnJhRXpaSW4rM3duWGxvMHc1WWIzamN4Z2hnZ0xpekIzSDlMUnBjUnAx?=
 =?utf-8?B?dEYvRHRRcVY5Q0RkaitIa0haM3R6LzNBRnEwc2RJK2h0bXZxeHR3SVRHRUNz?=
 =?utf-8?B?dlY2bkowSVdYTjQvVGhZa0lxZjdUUExLUEFyTXVJZDAvamhITVR3Q281RUM2?=
 =?utf-8?B?dGJucE5iNnpYSjdtZWVWdHVqaXVQaXA2cEhURE9tZkdPY0dIRnE0Nko1c2dz?=
 =?utf-8?B?YUF6ZXJMNnJhcUEyNHRQTDZCVjNZWkdxTkhvYVk0SXRwUWpXdzJ6MjhaNUxL?=
 =?utf-8?B?dEQ5RnJIZXZaaFFaU3BjQXBGYUlBcklTR0U2VEJjWWNQVS9NZWtQUFUvNmtp?=
 =?utf-8?B?WDRQOWZMaCtWSldaTUN6VU5kby9kZnZhNGdaT3RaN3VrQVM4bW8weDJkQTha?=
 =?utf-8?B?WjRSR0N4RTh3QVZucmVFdHlzQjBhVDFsM2lFUUVRUllsTFFEMkdkdzZmREhw?=
 =?utf-8?B?d2I0MGlEdTJZTTRtcmNhZUNRMG1YK0cwRVhDVnBlT1krZE96c0R6aHhRT1l2?=
 =?utf-8?B?ZWwxVXUrakxhQjFPcHZ2WUcwenNxZjZxaFBqcnEyMlByZ0UzckM3Y0t0ZWVn?=
 =?utf-8?B?anlsbXFEWWVkSW5BaUMwNEppZEJjYTVrelZDSGNCVWpjUXVmbEVFdTBNZDY3?=
 =?utf-8?B?MUZ1MHZJRWFYek5oUWdaWkNmcVc1QWhBRmVWbzdlQ3h6K3p1SHZJQnJOM1R5?=
 =?utf-8?B?UzVLVzFsdyttNzJZUG5sOEplUTNiQ243eTIyOEU2aXllN3BsdlovVzdqbzFF?=
 =?utf-8?B?WFc5VVBONWZGYURxcy94QTFsM0hNT3F3L2NiRU9Za2hCNlpRdVludTV5VGRU?=
 =?utf-8?B?OWVtTExTdHAxZXBmL1pqK05BOVQ4RXFoclFIVFlHRDliRjNjTWE0TjJFN1d0?=
 =?utf-8?B?aWFkZzZhNmhYSWJ4ajMwVk4xSWRyck01MnVHcElWTk5VUkVDRC8xVUVHWTZ0?=
 =?utf-8?B?T1FZZFFoWFJLWjUwclVJZkdjRlRtY01lVzNWeURoUHVkRUVJNEdsd1VrQmpp?=
 =?utf-8?B?d0NKNExia0ltZjhOVlFHT0prV0gwSnhJUTMxZjJTVTViWHl2ZmhJc0dsRDY0?=
 =?utf-8?B?OVYxV04wUzNkS0VvbHRXT25VR1hvNzlrUVpDdnV1NERPajR0dVlFc3VHTUp6?=
 =?utf-8?B?Um9qOS8rMFd3NERBcExrbjhPRlRRSENveURGRUk2dzhJaWs4MXBsS0lQWmpP?=
 =?utf-8?B?QSs0d21FY2JVNTBFOWJOUmFZTGlSLzk5M2x6ZUhuN0ZidUJGWUY1aHVqazhm?=
 =?utf-8?B?d2liY2M2NGh0L2JXdysrZHgweVdGT055UTJnQnIwcEI5Vk01aytuRWY3dVRj?=
 =?utf-8?B?VHBQTVRlTFluZ01Pa001aVR1bTlpU2hpc045b0VTWUFNbmNwYXRlMkJUVVRq?=
 =?utf-8?B?MGN5SlU3aVd3Uit1T3RrbzZJa25DdG9ZekZ5bWZpWGQ3STFXQVE4c0J3OC80?=
 =?utf-8?Q?mSvK4Hd+ePuTnLXLErIBdpw=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9cffd506-721d-4886-3a97-08d9db71df70
X-MS-Exchange-CrossTenant-AuthSource: CH0PR12MB5346.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2022 17:33:57.7972
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I4CYxjlIB8PxSwJRYNEsaw0QXak7Hjwg3fOaGe7fqpyFOzJnSkaJ/WCA6M4IMAM592porA0ujmKZdLY79FMvoQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2600
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/19/22 9:30 AM, Jean Delvare wrote:
> Hi Terry,
> 
> On Tue, 18 Jan 2022 14:22:30 -0600, Terry Bowman wrote:
>> This series uses request_mem_region() to synchronize accesses to the MMIO
>> registers mentioned above. request_mem_region() is missing the retry
>> logic in the case the resource is busy. As a result, request_mem_region()
>> will fail immediately if the resource is busy. The 'muxed' variant is
>> needed here but request_muxed_mem_region() is not defined to use.  I will
>> follow up with another patch series to define the
>> request_muxed_mem_region() and use in both drivers.
> 
> Shouldn't this be done the other way around, first introducing
> request_muxed_mem_region() and then using it directly in both drivers,
> rather than having a temporary situation where a failure can happen?
> 
> As far as I'm concerned, the patch series you just posted are
> acceptable only if request_muxed_mem_region() gets accepted too.
> Otherwise we end up with the situation where a driver could randomly
> fail.
> 

Hi Jean,
                                                                      
I considered sending the request_muxed_mem_region() patch series first but 
was concerned the patch might not be accepted without a need or usage. I 
didn't see an obvious path forward for the order of submissions because of 
the dependencies. 

I need to make the review easy for you and the other maintainers. I can 
send the request_muxed_mem_region() single patch series ASAP if you like. 
Then I change the request_mem_region() -> request_muxed_mem_region() as 
needed in the piix4_smbus v3 and sp5100_tco v4 and add dependency line as 
well? Is their a risk the driver patches will take 2 merge windows before 
added to the tree ? Is there anything I can do to avoid this?

Regards,
Terry