Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <2fad3da6-987a-ae62-9da2-f9184b0c91cb@linux.ibm.com>
Date:   Wed, 19 Jan 2022 19:13:55 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH v2 13/30] s390/pci: return status from zpci_refresh_trans
Content-Language: en-US
To:     Matthew Rosato <mjrosato@linux.ibm.com>, linux-s390@vger.kernel.org
Cc:     alex.williamson@redhat.com, cohuck@redhat.com,
        schnelle@linux.ibm.com, farman@linux.ibm.com,
        borntraeger@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,
        gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com,
        frankja@linux.ibm.com, david@redhat.com, imbrenda@linux.ibm.com,
        vneethv@linux.ibm.com, oberpar@linux.ibm.com, freude@linux.ibm.com,
        thuth@redhat.com, pasic@linux.ibm.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220114203145.242984-1-mjrosato@linux.ibm.com>
 <20220114203145.242984-14-mjrosato@linux.ibm.com>
From:   Pierre Morel <pmorel@linux.ibm.com>
In-Reply-To: <20220114203145.242984-14-mjrosato@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/14/22 21:31, Matthew Rosato wrote:
> Current callers of zpci_refresh_trans don't need to interrogate the status
> returned from the underlying instructions.  However, a subsequent patch
> will add a KVM caller that needs this information.  Add a new argument to
> zpci_refresh_trans to pass the address of a status byte and update
> existing call sites to provide it.
> 
> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>

Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>


> ---
>   arch/s390/include/asm/pci_insn.h |  2 +-
>   arch/s390/pci/pci_dma.c          |  6 ++++--
>   arch/s390/pci/pci_insn.c         | 10 +++++-----
>   drivers/iommu/s390-iommu.c       |  4 +++-
>   4 files changed, 13 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/s390/include/asm/pci_insn.h b/arch/s390/include/asm/pci_insn.h
> index 5331082fa516..32759c407b8f 100644
> --- a/arch/s390/include/asm/pci_insn.h
> +++ b/arch/s390/include/asm/pci_insn.h
> @@ -135,7 +135,7 @@ union zpci_sic_iib {
>   DECLARE_STATIC_KEY_FALSE(have_mio);
>   
>   u8 zpci_mod_fc(u64 req, struct zpci_fib *fib, u8 *status);
> -int zpci_refresh_trans(u64 fn, u64 addr, u64 range);
> +int zpci_refresh_trans(u64 fn, u64 addr, u64 range, u8 *status);
>   int __zpci_load(u64 *data, u64 req, u64 offset);
>   int zpci_load(u64 *data, const volatile void __iomem *addr, unsigned long len);
>   int __zpci_store(u64 data, u64 req, u64 offset);
> diff --git a/arch/s390/pci/pci_dma.c b/arch/s390/pci/pci_dma.c
> index a81de48d5ea7..b0a2380bcad8 100644
> --- a/arch/s390/pci/pci_dma.c
> +++ b/arch/s390/pci/pci_dma.c
> @@ -23,8 +23,9 @@ static u32 s390_iommu_aperture_factor = 1;
>   
>   static int zpci_refresh_global(struct zpci_dev *zdev)
>   {
> +	u8 status;
>   	return zpci_refresh_trans((u64) zdev->fh << 32, zdev->start_dma,
> -				  zdev->iommu_pages * PAGE_SIZE);
> +				  zdev->iommu_pages * PAGE_SIZE, &status);
>   }
>   
>   unsigned long *dma_alloc_cpu_table(void)
> @@ -183,6 +184,7 @@ static int __dma_purge_tlb(struct zpci_dev *zdev, dma_addr_t dma_addr,
>   			   size_t size, int flags)
>   {
>   	unsigned long irqflags;
> +	u8 status;
>   	int ret;
>   
>   	/*
> @@ -201,7 +203,7 @@ static int __dma_purge_tlb(struct zpci_dev *zdev, dma_addr_t dma_addr,
>   	}
>   
>   	ret = zpci_refresh_trans((u64) zdev->fh << 32, dma_addr,
> -				 PAGE_ALIGN(size));
> +				 PAGE_ALIGN(size), &status);
>   	if (ret == -ENOMEM && !s390_iommu_strict) {
>   		/* enable the hypervisor to free some resources */
>   		if (zpci_refresh_global(zdev))
> diff --git a/arch/s390/pci/pci_insn.c b/arch/s390/pci/pci_insn.c
> index 0509554301c7..ca6399d52767 100644
> --- a/arch/s390/pci/pci_insn.c
> +++ b/arch/s390/pci/pci_insn.c
> @@ -77,20 +77,20 @@ static inline u8 __rpcit(u64 fn, u64 addr, u64 range, u8 *status)
>   	return cc;
>   }
>   
> -int zpci_refresh_trans(u64 fn, u64 addr, u64 range)
> +int zpci_refresh_trans(u64 fn, u64 addr, u64 range, u8 *status)
>   {
> -	u8 cc, status;
> +	u8 cc;
>   
>   	do {
> -		cc = __rpcit(fn, addr, range, &status);
> +		cc = __rpcit(fn, addr, range, status);
>   		if (cc == 2)
>   			udelay(ZPCI_INSN_BUSY_DELAY);
>   	} while (cc == 2);
>   
>   	if (cc)
> -		zpci_err_insn(cc, status, addr, range);
> +		zpci_err_insn(cc, *status, addr, range);
>   
> -	if (cc == 1 && (status == 4 || status == 16))
> +	if (cc == 1 && (*status == 4 || *status == 16))
>   		return -ENOMEM;
>   
>   	return (cc) ? -EIO : 0;
> diff --git a/drivers/iommu/s390-iommu.c b/drivers/iommu/s390-iommu.c
> index 50860ebdd087..845bb99c183e 100644
> --- a/drivers/iommu/s390-iommu.c
> +++ b/drivers/iommu/s390-iommu.c
> @@ -214,6 +214,7 @@ static int s390_iommu_update_trans(struct s390_domain *s390_domain,
>   	unsigned long irq_flags, nr_pages, i;
>   	unsigned long *entry;
>   	int rc = 0;
> +	u8 status;
>   
>   	if (dma_addr < s390_domain->domain.geometry.aperture_start ||
>   	    dma_addr + size > s390_domain->domain.geometry.aperture_end)
> @@ -238,7 +239,8 @@ static int s390_iommu_update_trans(struct s390_domain *s390_domain,
>   	spin_lock(&s390_domain->list_lock);
>   	list_for_each_entry(domain_device, &s390_domain->devices, list) {
>   		rc = zpci_refresh_trans((u64) domain_device->zdev->fh << 32,
> -					start_dma_addr, nr_pages * PAGE_SIZE);
> +					start_dma_addr, nr_pages * PAGE_SIZE,
> +					&status);
>   		if (rc)
>   			break;
>   	}
> 

-- 
Pierre Morel
IBM Lab Boeblingen