Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Sean Anderson <sean.anderson@seco.com>
Subject: Re: [PATCH v2 0/7] usb: dwc3: Calculate REFCLKPER et. al. from
 reference clock
To:     Baruch Siach <baruch@tkos.co.il>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Balaji Prakash J <bjagadee@codeaurora.org>,
        linux-kernel@vger.kernel.org,
        Robert Hancock <robert.hancock@calian.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Michal Simek <michal.simek@xilinx.com>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org
References: <20220119002438.106079-1-sean.anderson@seco.com>
 <87ee53fv01.fsf@tarshish>
Message-ID: <a1932eba-564c-fe32-f220-53aa75250105@seco.com>
Date:   Wed, 19 Jan 2022 13:23:44 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <87ee53fv01.fsf@tarshish>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1BQSzF0NENWY3ZPQ2VobjBGbWlhYlU4SEJ6ek9sWVNLcU1oUFMzRnBRU0tr?=
 =?utf-8?B?N01xNU9tbSt6ZlhXdjkzUE9IQ2lYaS94Vjg5NGNjcGx5c2ovNFBuM2hOdVlD?=
 =?utf-8?B?VHBueDFqSVlLSjMwVklrSUFqc2I2NERJWUdyQkJ3MVNDUnVyMG1wb1ZaZlRy?=
 =?utf-8?B?blRaVmlnVCtPQ1REbnV0Vk4xMEUrdXVCQStzZnNVamMySnNrUUdNWGtSaFVh?=
 =?utf-8?B?Y05FWXk5UHdSbnNXN2Rxc21zWHlmblp3dmRndGNDUXhaSU5Lb2lweUVMbDhq?=
 =?utf-8?B?ZUI3Z0ZtekdjNVJmZjYwWll1cDI0eGZ4S2RIbmFiNXZTNSttZ29vd2NsQ3FQ?=
 =?utf-8?B?Q1hCRVNxZDZZcFJnODlDVGZFT0ZtZnpUSWgwYlRsN3RlUG45NzZpSkxETHVi?=
 =?utf-8?B?SWh3VStlUXJYQ1pWL3VMY0t1eWtqVnlrNHA1S3AvVWczdFlUeXhUMXhYTnNl?=
 =?utf-8?B?ZHNGeGorY2JXaW1ValdhanBvRGpsQllhenpid3MzeVNYN2RJMU15bTlaeWp3?=
 =?utf-8?B?RGxSQXJOREFXVWlhZkxoVGg5amdsazNjcHlNakI3TUFmNzJjcWxwQnRZT092?=
 =?utf-8?B?Z0NVTGU1WjlLZHcxSHhybzNDUkt4S0xMZjlUQldZdjVEb3pLTlBhYk1lVFVx?=
 =?utf-8?B?UGpVR0xxaHN1UlFoOEtaRm9GT3ZjRndTa1pQaUVXRHdWKzAxYXFjNWMrODNq?=
 =?utf-8?B?MzFhN2habmFkNlQyZmhGOGtwdThSa2RlTDFBb1JKaWtPV1M1QkhRU0tROHZJ?=
 =?utf-8?B?ZEFQZUlTVUxmeHlLNjZZaTc5UWdTTlRQaEkvWllwMUdjcTRCdjN1UEtVZFA3?=
 =?utf-8?B?T28raWRYWTgwa1FRT29rMzJCN1BjcFp4cVBBbVVLQnpRdENLQTBwV3gzVnUv?=
 =?utf-8?B?b3ViQkhaMnVRWkZFZkk4VFBKUzFCeG5wRUt4L1pzMkg4QnRCMXBKZEUrSE1F?=
 =?utf-8?B?Nk56WEhjdS9TVzdtV0czYVlvRnZRaHoxYTUyQWlvemdXYWpGUVlFWUFoWFpX?=
 =?utf-8?B?dEtEdHQ5eUZxSTVQMUI5cFZNSm5lejBORS9TdkxreUR2NkI3OVl3a05lQTBG?=
 =?utf-8?B?TzZrSnhPdVNVY3lvc1RnYy9nbm1XRHJuOVpGNTh4V2lLVTZVaTcxaEgwcndJ?=
 =?utf-8?B?Y2hLbmxlUnFPWTJDYlVUYnRvWTR6dkVOS3lueDhkMkxncVNmTTd3UWpjQTdU?=
 =?utf-8?B?UzM2NlQwRzVUOE1VM2pZUFZ2Zm15aUl4c2FEL00rY2pjTTBTaVRWc1VEb213?=
 =?utf-8?B?UTYvdzNWcGcyQ2R3czhRT00vVW1IeTlHQjh5NkFxQTJPZEF3V0dSM25Xbm1t?=
 =?utf-8?B?SzFCRlJRVEV2YzNOdzYxdWJDNFZoejI2amNSN2MwcVdEQnMwZ3RnTWh2VUZv?=
 =?utf-8?B?d01YZnRyT3YzelRMUFJZOG1PVFdZTU4wVVhMMS9tUnQ0a2VWZW1XQ2Zza2FO?=
 =?utf-8?B?bXlrTGs4YnRCM1ltNjMwS3dSQmVLdXAvR3NrbXVIMVdqcnN6a28zMTBOWHFz?=
 =?utf-8?B?eFVudHdvcDJGYzhhaEU0d2pYQlJwcWVBb0U0TlAyVjQyMHBMS1d0NE9WVkYr?=
 =?utf-8?B?a0RtOG81N3VzQ3p1ekREbnUwanJJTzVQNy90bnd5a014eUw2M2NsdUk2VVl6?=
 =?utf-8?B?TzBIWllVT1lsVXdzZDh2K3B2RW13U0ZPU2FEeXZteXp6SGwwVXpFVEtqT0d0?=
 =?utf-8?B?c0I2eVVkUzJDciszUXNpSUw0MEU2cm45bUpnTFdJcmxwcTQxMkpINXBIaUNr?=
 =?utf-8?B?RmlZaldRT3V6L1lPUlIrZXdIdmF2eUczSHFQUVZNMlc3bHk4NjBVNUl0MGpK?=
 =?utf-8?B?TGRUWGovaFhFNUlnaUJXUUozaEFmRUhhRnd3T0FzZXNyTVVQUFprbndmb3NW?=
 =?utf-8?B?NXhqSWpQWk45ZDNlV2RUcThCYzBUUWFuZUQvZkdVSHUwbjhhSmJEenl5K21I?=
 =?utf-8?B?bDN0RU5qcTJDZzVQd2RlcUduYTZoQTdrQnlUeUExV1o4R2Fxb0l6cTAyeWU2?=
 =?utf-8?B?ZjNHVGFXemdwbWxTSm93U3hUSTcrTHJxemFQeHJJR01NNitzM3hxcjJpbmZF?=
 =?utf-8?B?UGY3aCtOeXdpeTlUaUNlSWhxN09KVTlZTGJ4VjZ6U1pSaHd2djNESXlrWHFB?=
 =?utf-8?B?SmNXMCtVSzZvWkl1U1MzbHhySFZWM3VqWVloMmppUnhLR3hSNnp3MXp4YUx5?=
 =?utf-8?Q?/N35JytYoRYBUFMx+H4fPOA=3D?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 725e89cc-1017-4277-f266-08d9db78d711
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB4514.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2022 18:23:50.1878
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v+2yiDW4KXfNK4pIFCR26PZ0XmSIxU77E6NJzEMMqfQAMehlGrnVm/Nxfq5l9Num3/nPcnBWm2UUEeefoqSrcg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7537
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Baruch,

On 1/19/22 1:14 PM, Baruch Siach wrote:
> Hi Sean,
>
> On Tue, Jan 18 2022, Sean Anderson wrote:
>> This is a rework of patches 3-5 of [1]. It attempts to correctly program
>> REFCLKPER and REFCLK_FLADJ based on the reference clock frequency. Since
>> we no longer need a special property duplicating this configuration,
>> snps,ref-clock-period-ns is deprecated.
>>
>> Please test this! Patches 3/4 in this series have the effect of
>> programming REFCLKPER and REFCLK_FLADJ on boards which already configure
>> the "ref" clock. I have build tested, but not much else.
>
> Tested here on IPQ6010 based system. USB still works. But the with "ref"
> clock at 24MHz, period is calculated as 0x29. Previous
> snps,ref-clock-period-ns value used to be 0x32.
>
> Is that expected?

Yes. From the documentation for GFLADJ_REFCLK_240MHZ_DECR:

> Examples:
> If the ref_clk is 24 MHz then
> - GUCTL.REF_CLK_PERIOD = 41
> - GFLADJ.GFLADJ_REFCLK_240MHZ_DECR = 240/24 = 10

And 41 == 0x29.

--Sean