Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <d4b47a8e-77f2-eef2-2245-bdc7eaf8f57f@redhat.com>
Date:   Wed, 19 Jan 2022 19:37:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] selftests: kvm/x86: Fix the warning in
 lib/x86_64/processor.c
Content-Language: en-US
To:     Jinrong Liang <ljr.kernel@gmail.com>
Cc:     Wanpeng Li <wanpengli@tencent.com>,
        Sean Christopherson <seanjc@google.com>,
        Jim Mattson <jmattson@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Joerg Roedel <joro@8bytes.org>,
        Jinrong Liang <cloudliang@tencent.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220119140325.59369-1-cloudliang@tencent.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <20220119140325.59369-1-cloudliang@tencent.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/19/22 15:03, Jinrong Liang wrote:
> From: Jinrong Liang <cloudliang@tencent.com>
> 
> The following warning appears when executing
> make -C tools/testing/selftests/kvm
> 
> In file included from lib/x86_64/processor.c:11:
> lib/x86_64/processor.c: In function ':
> include/x86_64/processor.h:290:2: warning: 'ecx' may be used uninitialized in this
> function [-Wmaybe-uninitialized]
>    asm volatile("cpuid"
>    ^~~
> lib/x86_64/processor.c:1523:21: note: 'ecx' was declared here
>    uint32_t eax, ebx, ecx, edx, max_ext_leaf;
> 
> Just initialize ecx to remove this warning.
> 
> Fixes: c8cc43c1eae2 ("selftests: KVM: avoid failures due to reserved
> HyperTransport region")
> 
> Signed-off-by: Jinrong Liang <cloudliang@tencent.com>
> ---
>   tools/testing/selftests/kvm/lib/x86_64/processor.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kvm/lib/x86_64/processor.c b/tools/testing/selftests/kvm/lib/x86_64/processor.c
> index 59dcfe1967cc..4a4c7945cf3e 100644
> --- a/tools/testing/selftests/kvm/lib/x86_64/processor.c
> +++ b/tools/testing/selftests/kvm/lib/x86_64/processor.c
> @@ -1520,7 +1520,7 @@ unsigned long vm_compute_max_gfn(struct kvm_vm *vm)
>   {
>   	const unsigned long num_ht_pages = 12 << (30 - vm->page_shift); /* 12 GiB */
>   	unsigned long ht_gfn, max_gfn, max_pfn;
> -	uint32_t eax, ebx, ecx, edx, max_ext_leaf;
> +	uint32_t eax, ebx, ecx = 0, edx, max_ext_leaf;
>   
>   	max_gfn = (1ULL << (vm->pa_bits - vm->page_shift)) - 1;
>   

A separate assignment of "ecx = 0" is slightly more conforming to the 
coding standards.  Queued nevertheless, thanks.

Paolo