Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 19 Jan 2022 23:08:41 +0300
From:   "Kirill A. Shutemov" <kirill@shutemov.name>
To:     Borislav Petkov <bp@alien8.de>
Cc:     "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        mingo@redhat.com, dave.hansen@intel.com, luto@kernel.org,
        peterz@infradead.org, sathyanarayanan.kuppuswamy@linux.intel.com,
        aarcange@redhat.com, ak@linux.intel.com, dan.j.williams@intel.com,
        david@redhat.com, jgross@suse.com, jmattson@google.com,
        joro@8bytes.org, jpoimboe@redhat.com, knsathya@kernel.org,
        pbonzini@redhat.com, sdeep@vmware.com, seanjc@google.com,
        tony.luck@intel.com, vkuznets@redhat.com, wanpengli@tencent.com,
        x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/26] x86/tdx: Support TDX guest port I/O at
 decompression time
Message-ID: <20220119200841.fupa3hemmswllmxc@box.shutemov.name>
References: <20211214150304.62613-11-kirill.shutemov@linux.intel.com>
 <YeAuehoOEjUH3vZ3@zn.tnic>
 <20220115010155.ss2hnyotw4a3nljf@black.fi.intel.com>
 <YeK7AJXGN5GVGkRV@zn.tnic>
 <20220117143920.3umnnlx7dl27cm5z@box.shutemov.name>
 <YeW2U9vH65NcLHtY@zn.tnic>
 <20220119115326.rw2aj3ho2mct4xxv@box.shutemov.name>
 <YegTjdltOFBIDlf2@zn.tnic>
 <20220119154925.mzri4zaz3o477e3k@box.shutemov.name>
 <YehqkKNgQ65uUOe6@zn.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YehqkKNgQ65uUOe6@zn.tnic>
Precedence: bulk

On Wed, Jan 19, 2022 at 08:46:24PM +0100, Borislav Petkov wrote:
> On Wed, Jan 19, 2022 at 06:49:25PM +0300, Kirill A. Shutemov wrote:
> > const struct port_io_ops default_pio_ops = {
> > 	.inb = inb,
> > 	.inw = inw,
> > 	.inl = inl,
> > 	.outb = outb,
> > 	.outw = outw,
> > 	.outl = outl,
> > };
> > 
> > make pio_ops a pointer and assign it here:
> > 
> > 	pio_ops = &default_pio_ops;
> > 
> > But it leads to an issue on linking:
> > 
> > ld.lld: error: Unexpected run-time relocations (.rela) detected!
> 
> So the above generates absolute relocations of type R_X86_64_64
> 
> Relocation section '.rela.data.rel.local' at offset 0x5c18 contains 6 entries:
>   Offset          Info           Type           Sym. Value    Sym. Name + Addend
> 000000000000  000200000001 R_X86_64_64       0000000000000000 .text + 10
> 000000000008  000200000001 R_X86_64_64       0000000000000000 .text + 30
> 000000000010  000200000001 R_X86_64_64       0000000000000000 .text + 50
> 000000000018  000200000001 R_X86_64_64       0000000000000000 .text + 0
> 000000000020  000200000001 R_X86_64_64       0000000000000000 .text + 20
> 000000000028  000200000001 R_X86_64_64       0000000000000000 .text + 40
> 
> and the linker doesn't like them probably because of the mcmodel we use
> but I need to talk to toolchain folks first to make sense of what's
> going on...

JFYI, the message comes from ASSERT in vmlinux.lds.S.

I assume for now I can proceed with the assignment that works, right?
It can be changed later once we figure out what is going on.

-- 
 Kirill A. Shutemov