Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1196633pxb; Fri, 21 Jan 2022 12:02:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJylQ1SASdzUykWfHg7DKLQQnKT75o8MsJ+vl6MIAoKcw0GfW1Wbw1eLChzZihXNH3NACcff X-Received: by 2002:a05:6a00:1490:b0:4c2:7965:9512 with SMTP id v16-20020a056a00149000b004c279659512mr5096992pfu.55.1642795325254; Fri, 21 Jan 2022 12:02:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642795325; cv=none; d=google.com; s=arc-20160816; b=Bn4TBpagjr7XRS1ZwEBmrP4+Gcn08tepV62MC8HDnXnc0V5eqew7jP02kXUNP+gG+O Y8vLQWbR4Ag9w9ZPifNBarF1kNkBdS7xtOBXnZZXX6nQ+6GmueClP4kfXI0UcLaNBDkV a8RabvP65IEL5ILmQM73674lUMDTmy9pe4J04m60SJVpg2LLbxVhfH+TaRq8pgZBnQoJ KcMitndM/FEaUYKIjkG05KDV8vrUbRjjNtARzB6AQf5rlz8P62zAbycUBD+nH1LJfCX0 F/Mi/5X+Q4Ae0/AbRd+YHBXMQlFHAr2a3IgPX7efXL5EBjKtbTIeZZMvrov/alEUZf3C CPRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:references:in-reply-to :message-id:mime-version:user-agent:dkim-signature:dkim-signature; bh=JKT/nV8EFLKtbGZNTCYtvqRmmyTL2Tgsz1tu10VSjNQ=; b=nNi8pkAgBNi3uUcbE9UOwDuqTr5KLVV9wNonhKLhAVjIdblLjGiEPf2SQd7KsgfKzz GvxteHQvXvoJwLCpYz/ML13RJJ+A6vo7q604k1Yai5c/kKDwdU7WW3UforRbnzK96MY9 7D6aino/XqNyV2NHAk04hvuQQfpZHqST5FB0l+BPeZpRD85JereizA3zXrgqRm/JaUHn SjKNqQ9EFOh7bOFggoz/SxcDzTgKzuQuOLCh9Pgpc+G7F9fa4r57YoTlVlLI6RMsF/Q0 fptf5ekRTdZVoJkc+V7M+Fk5X+KDumrMHlz0gwFLTALjMbOwETRlXa1i0p9YcU8A/baL gNdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@liquorix.net header.s=fm1 header.b=cxdUi+cb; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=m2pZbC12; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e11si4833631plh.161.2022.01.21.12.01.53; Fri, 21 Jan 2022 12:02:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@liquorix.net header.s=fm1 header.b=cxdUi+cb; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=m2pZbC12; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357288AbiASUVe (ORCPT + 99 others); Wed, 19 Jan 2022 15:21:34 -0500 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:53733 "EHLO new3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357255AbiASUV2 (ORCPT ); Wed, 19 Jan 2022 15:21:28 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id 9CC405803E8; Wed, 19 Jan 2022 15:21:22 -0500 (EST) Received: from imap46 ([10.202.2.96]) by compute5.internal (MEProxy); Wed, 19 Jan 2022 15:21:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=liquorix.net; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=JKT/nV8EFLKtbGZNTCYtvqRmmyTL2Tg sz1tu10VSjNQ=; b=cxdUi+cbXCN+4iHGOELe5QBWZOviFSD8GJEG52aBsXsVaIu 8OqmAhi5Dl4e5hDUIQ/qo3cDovmpunrbZqh9j8ocObhnaUCyYae5RuEfMwGEKA1a 9+nWS8UwZyKEy+McYZBr78JuzucOxulj8KtwEBGa8sO31HgY7146ViVL1B5CXB9j DWrh7jSSkLCROJagKYmyKHJlt01lll4VRxFzB4oBTyeKF3r0NgN5u6gB4p5Kfb+K /lEPpBYo6jxZfQ/55+CKH9uu4WS7E8TtIUBSGUqPFdmq1Q6jNIJxkUtWhcwJ+lBa pRl+dwNtSJ+aS3Hif3umMzpu90dAjWUSwC3q2LQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=JKT/nV 8EFLKtbGZNTCYtvqRmmyTL2Tgsz1tu10VSjNQ=; b=m2pZbC12MWeHg5y4W+U1wf A+eiOYdWpwCNn1IR5Zagic8Fh6gf4A5dVJhpexiDDOsGdYwVt+29u/5G6ivQmq5i DYvn+VLyeZzTFBDBLKx13M4hhiaVuploplxhDN4rcL+tiwoNnoGGTEglzX0k5j9M /Bwut0errFggj63mRR2tn8LNTpbYb7DgINX+2pm5xq72G6Or6lRBd7WsE+9vJajG 2eALcaw6Lynz9sIZmYij6smHQx1ScHOOejLzH0ae/UVgs8R3GebM2EpYr2hU1Sra b/7YxD+R5p03hBh+PAyTjBf11uIEl0pt0PBBuI2iTrioWfBDEMM4bVd/723KPb+w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeigdejiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedfufhtvghv vghnuceurghrrhgvthhtfdcuoehsthgvvhgvnheslhhiqhhuohhrihigrdhnvghtqeenuc ggtffrrghtthgvrhhnpeekleffieffheevveeuteduteffkeffvdejuefhuedugfduvdeh fedtueeiffelheenucffohhmrghinhepgigrnhhmohgurdhorhhgpdgthhhrohhmihhumh drohhrghdprghrtghhlhhinhhugidrohhrghdplhhiqhhuohhrihigrdhnvghtpdhgohho ghhlvghsohhurhgtvgdrtghomhdpvgguihdrfihorhhkshenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsthgvvhgvnheslhhiqhhuohhrihig rdhnvght X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 6A2321EE007B; Wed, 19 Jan 2022 15:21:20 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-4585-ga9d9773056-fm-20220113.001-ga9d97730 Mime-Version: 1.0 Message-Id: <9203f79f-7910-4613-a593-aa6fda665b42@www.fastmail.com> In-Reply-To: References: <20220104202227.2903605-1-yuzhao@google.com> Date: Wed, 19 Jan 2022 14:19:30 -0600 From: "Steven Barrett" To: "Yu Zhao" Cc: "Andi Kleen" , "Catalin Marinas" , "Dave Hansen" , "Hillf Danton" , "Jens Axboe" , "Jesse Barnes" , "Johannes Weiner" , "Jonathan Corbet" , "Matthew Wilcox" , "Mel Gorman" , "Michael Larabel" , "Michal Hocko" , "Rik van Riel" , "Vlastimil Babka" , "Will Deacon" , "Ying Huang" , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, page-reclaim@google.com, x86@kernel.org, "Andrew Morton" , "Linus Torvalds" Subject: Re: [PATCH v6 0/9] Multigenerational LRU Framework Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 11, 2022, at 2:41 AM, Yu Zhao wrote: > On Tue, Jan 04, 2022 at 01:30:00PM -0700, Yu Zhao wrote: > > On Tue, Jan 04, 2022 at 01:22:19PM -0700, Yu Zhao wrote: > > > TLDR > > > ==== > > > The current page reclaim is too expensive in terms of CPU usage and it > > > often makes poor choices about what to evict. This patchset offers an > > > alternative solution that is performant, versatile and > > > straightforward. > > > > > > > > > Summery > > > ======= > > > The facts are: > > > 1. The independent lab results and the real-world applications > > > indicate substantial improvements; there are no known regressions. > > > 2. Thrashing prevention, working set estimation and proactive reclaim > > > work out of the box; there are no equivalent solutions. > > > 3. There is a lot of new code; nobody has demonstrated smaller changes > > > with similar effects. > > > > > > Our options, accordingly, are: > > > 1. Given the amount of evidence, the reported improvements will likely > > > materialize for a wide range of workloads. > > > 2. Gauging the interest from the past discussions [14][15][16], the > > > new features will likely be put to use for both personal computers > > > and data centers. > > > 3. Based on Google's track record, the new code will likely be well > > > maintained in the long term. It'd be more difficult if not > > > impossible to achieve similar effects on top of the existing > > > design. > > > > Hi Andrew, Linus, > > > > Can you please take a look at this patchset and let me know if it's > > 5.17 material? > > > > My goal is to get it merged asap so that users can reap the benefits > > and I can push the sequels. Please examine the data provided -- I > > think the unprecedented coverage and the magnitude of the improvements > > warrant a green light. > > Downstream kernel maintainers who have been carrying MGLRU for more than > 3 versions, can you please provide your Acked-by tags? > > Having this patchset in the mainline will make your job easier :) > > Alexandre - the XanMod Kernel maintainer > https://xanmod.org > > Brian - the Chrome OS kernel memory maintainer > https://www.chromium.org > > Jan - the Arch Linux Zen kernel maintainer > https://archlinux.org > > Steven - the Liquorix kernel maintainer > https://liquorix.net > > Suleiman - the ARCVM (Android downstream) kernel memory maintainer > https://chromium.googlesource.com/chromiumos/third_party/kernel > > Also my gratitude to those who have helped test MGLRU: > > Daniel - researcher at Michigan Tech > benchmarked memcached > > Holger - who has been testing/patching/contributing to various > subsystems since ~2008 > > Shuang - researcher at University of Rochester > benchmarked fio and provided a report > > Sofia - EDI https://www.edi.works > benchmarked the top eight memory hogs and provided reports > > Can you please provide your Tested-by tags? This will ensure the credit > for your contributions. > > Thanks! This feature has been a huge improvement for desktop linux, system responsiveness has hit a new level high memory pressure. Thanks Yu! Acked-by: Steven Barrett