Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Wed, 19 Jan 2022 16:45:40 -0800
From:   Guenter Roeck <linux@roeck-us.net>
To:     Eugene Shalygin <eugene.shalygin@gmail.com>
Cc:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Denis Pauk <pauk.denis@gmail.com>,
        Jean Delvare <jdelvare@suse.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-hwmon@vger.kernel.org
Subject: Re: [ASUS EC Sensors v7 1/3] hwmon: (asus-ec-sensors) add driver for
 ASUS EC
Message-ID: <20220120004540.GD3474033@roeck-us.net>
References: <20220118165316.412735-1-eugene.shalygin@gmail.com>
 <20220118165316.412735-2-eugene.shalygin@gmail.com>
 <CAB95QATvQPZ-s4dCWeqKcSZ9Rfx9uK1AyoM9Kk3biPfvXh5r5g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAB95QATvQPZ-s4dCWeqKcSZ9Rfx9uK1AyoM9Kk3biPfvXh5r5g@mail.gmail.com>
Precedence: bulk

On Wed, Jan 19, 2022 at 04:25:41AM +0100, Eugene Shalygin wrote:
> I did not read carefully what I committed and now two small
> corrections are required (see inline). Should I resend again?
> 

Wait for a couple of days in case there is test coverage
or other feedback.

Guenter

> On Tue, 18 Jan 2022 at 17:53, Eugene Shalygin <eugene.shalygin@gmail.com> wrote:
> > +       DMI_EXACT_MATCH_BOARD(VENDOR_ASUS_UPPER_CASE, "ROG STRIX X570-F GAMING",
> > +               SENSOR_SET_TEMP_CHIPSET_CPU_MB |
> > +               SENSOR_TEMP_T_SENSOR | SENSOR_FAN_CHIPSET
> Redundant line break.
> > +       ),
> > +       DMI_EXACT_MATCH_BOARD(VENDOR_ASUS_UPPER_CASE, "ROG STRIX X570-I GAMING",
> > +               SENSOR_TEMP_T_SENSOR | SENSOR_FAN_VRM_HS |
> > +               SENSOR_FAN_CHIPSET | SENSOR_CURR_CPU),
> 
> 
> > +struct ec_sensors_data {
> > +       unsigned long board_sensors;
> > +       struct ec_sensor *sensors;
> > +       /** EC registers to read from */
> > +       u16 *registers;
> > +       u8 *read_buffer;
> > +       /** sorted list of unique register banks */
> > +       u8 banks[ASUS_EC_MAX_BANK + 1];
> > +       /** in jiffies */
> > +       unsigned long last_updated;
> > +       acpi_handle aml_mutex;
> > +       /** number of board EC sensors */
> > +       u8 nr_sensors;
> > +       /** number of EC registers to read (sensor might span more than 1 register) */
> > +       u8 nr_registers;
> > +       /** number of unique register banks */
> > +       u8 nr_banks;
> > +};
> 
> Forgot to remove doc-comments.
> 
> Thanks,
> Eugene