Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <39230575-13ea-7384-71bc-2aac1fa2edb8@intel.com>
Date:   Thu, 20 Jan 2022 09:46:36 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.5.0
Subject: arch/arm/mach-ep93xx/clock.c:154:2: warning: Use of memory after it
 is freed [clang-analyzer-unix.Malloc]
References: <202201200359.lTk9zHg4-lkp@intel.com>
Content-Language: en-US
To:     Nikita Shubin <nikita.shubin@maquefel.me>
CC:     <llvm@lists.linux.dev>, <kbuild-all@lists.01.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        "Alexander Sverdlin" <alexander.sverdlin@gmail.com>
From:   kernel test robot <yujie.liu@intel.com>
In-Reply-To: <202201200359.lTk9zHg4-lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUZOaStrRW15RzNDYzdpNXU4WXlHeWh2a0RnSE1Nc0R5VG9pRVUxbS9PRDh4?=
 =?utf-8?B?Wm5EaVJKb2N0TUVUWW5rd3lOTWNDT2UveDFwb25SZGlCcGVtcnMyK09CdjlV?=
 =?utf-8?B?TGpIamtJZWM4QnpkY0xPdEFoY3psOXo2djRFMllMMkdlQmR3UCtIRkxaQ1p0?=
 =?utf-8?B?S3M1VTY2bmdvOS9nV09iMXhpL2FPN2ovQUthMHB6YW4yL0NCZmFXV3JjN0cw?=
 =?utf-8?B?cGN1S08wNEl0YXBVNndYTjRQd3Q0YzFlcWxMRlIzL2h0ZmdvSGFLL1gxZlZm?=
 =?utf-8?B?MjJDSHB0NG9SZTQvSjFOV3U5UTdDbC9ieXM2bU0xdXVKYzZMNVVsQ09CNDVC?=
 =?utf-8?B?bnY0bS8rWk54aXR0MXpJYXg2VFNGM1lVbTF5SUxNWkliTTArekhRQUdwZE93?=
 =?utf-8?B?ODV1QTlOQU15OXppT2p4ODJHcGxnOUVWVjhjT3JGUzJkRFFtL3ZScUZ0RHox?=
 =?utf-8?B?TTRpdjJYTTZoTkJpLytBMjg4b3MwM3JteDE2dWJDTU5yNWxUTVluODA3bFFt?=
 =?utf-8?B?cTY1TzgyUk95U3o5YVgvb3YyZ3A1NzRTY0ZhWHRTNE41YTBFOU1xaytLTExO?=
 =?utf-8?B?RVlyUmh0UkJKaUZ0dXE0ckcyUU1JZW12N2tEVkhXRGVmOC9kcUE4eithVGJE?=
 =?utf-8?B?UVd2dWFubjJxU0lJbjdMM1V4VFRqS2gwTmtNQ2l4eXNJQmJvbTR5dWxtMHRm?=
 =?utf-8?B?dXFzUlZHMmVkV2xMWnMxT1FMUWJFWEI2QlJvQWpGRUI5bFJJRlhsbkhRMlR5?=
 =?utf-8?B?eTYxMGU4ZXBxeWUrR1dFQm8xczdIaWZROGxnTStiVUV3ZzRWZk1lUXg0ZDN5?=
 =?utf-8?B?UzllWWR0NjFFd2pLSTg0bzdoZEFJdnJMQzhYOGtyMitPUFVFNnNFWmc3NStK?=
 =?utf-8?B?TVl5WGs0R1lDamJpM1pFdnVkT1lEYnhqVjFYNmxsc2RieWxzTEdwRVZmcFl6?=
 =?utf-8?B?K2s0dG5yUGNRdEVERXgxZHR0WldTWVFGTnlONlhEaXZQTE9aOEdtV3BqczBU?=
 =?utf-8?B?SlNvbkxCbW5iMlQzL25HSjZmSGd2WCtqT21zRHN0Z2NJTjd0Rmh2dWdqelUw?=
 =?utf-8?B?ckNLb0NIMDd1a1ppYWdsVHozMWVVUzZhL0dNWGRFRlNJMHBVTm9JNVFBbDhS?=
 =?utf-8?B?ZWptRVNLSllZWXVwOTl3TXlBU0x0OStlRFh0NkpPTXNwbW1xSEk1ekdmeEdn?=
 =?utf-8?B?bnE1UENsaWM3VjhNK3MwSzlsMGFmNUJxS0NSTU51bjY3d0R5SkdLSkIvazVB?=
 =?utf-8?B?dE1zYXdKUjhKNzlmNzg5UFVlVFJZR1J0bXlrTUFwdnRKckdPaHBQZUZLcDdn?=
 =?utf-8?B?eXF5YVo5Zlhsc0doakhoblZmUitrV1dKbjdleWsyOU0vdzlFWGZmak9FdVdU?=
 =?utf-8?B?ZysvWmIwcnNuUHFrbFZ1TjhBdVFqK2NNdVB0YkYweHBGVDRjdE9QdUl4K2J1?=
 =?utf-8?B?ZFpxelM0WkJ6eWc2R3EwWWxBdlhtK2RwbWhKMTBvenU0VTBKeGdnc3c2Rmhy?=
 =?utf-8?B?eXEzR0NnMzNlRFR2ZHcxbHdsTngva3Q5c1BuTDdVa2hISXhhVVhjOTFONHRo?=
 =?utf-8?B?TkpkZWpIb1hOMURNUlp1K2J4RVNYRFBUMk0xMWxUV0ZRbzRtUjM4VjAyemNT?=
 =?utf-8?B?MExaVUZjU0ZiUHlzbGlyMXVqKzJuN2NGNEltRW5vU2d5NVNpTE9TT3pVYSt5?=
 =?utf-8?B?L2ltSHVUT1p1V3VRMFFhbUh1YklRVWlTNmRVcDVBZWd0ZDlZdFNMaCtsRnl4?=
 =?utf-8?B?eDJ2STRxTjl1UklxYXYzRnZBazlrcEdIbHpRN1YralJpK2pheXpMbStKcCs2?=
 =?utf-8?B?dzUyeTdDSTBhdXY3bUxQSy9KZG5WbjFlcnpGVVROUjAxMGQrQ1FuTUR1VjZ3?=
 =?utf-8?B?WFNpUVl0a0MyZ043ZnJWTmRmK29IK1NvaVB1ekkzdk1taUJSV2EzTzdEWk5E?=
 =?utf-8?B?TDBQTHJXK0VqMTJtNzhkWmpUaFdiaFd0dE8rbFlYUFQ1bndJUHZuaFVMYUlz?=
 =?utf-8?B?TWpLNTkwZUVlM2tBejVIQ3JrNGdRWm9ZQktwcU5OMmVlb1hMVXkvQ0QrUTdQ?=
 =?utf-8?B?MUNJcHlENVczdFBDSC8yMHBWajdRRlZZc1c5NFQvR2dzRmZNd3kwaXZ6MFlm?=
 =?utf-8?B?YVpVZkZTdlAxMkFhciticUFxSXJLQmh3K0MxRHB5SHltUkFPbFE2dHRHVjNH?=
 =?utf-8?Q?wRqOuI/4i6nVZNxAolAI0Q8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: af2babdf-70a8-4131-3322-08d9dbb6b5c6
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5598.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2022 01:46:43.2500
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mxoaw9O1vWJnuLD/p5iDDheVTufIZdzfWLxZ8XGj1WI6DLx0wLJBGwEUmsezGmske8rm/wIR/Dqdp7KbsSPDfw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5507
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   1d1df41c5a33359a00e919d54eaebfb789711fdc
commit: 9645ccc7bd7a16cd73c3be9dee70cd702b03be37 ep93xx: clock: convert in-place to COMMON_CLK
date:   3 months ago
config: arm-randconfig-c002-20220118 (https://download.01.org/0day-ci/archive/20220120/202201200359.lTk9zHg4-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 5f782d25a742302d25ef3c8b84b54f7483c2deb9)
reproduce (this is a W=1 build):
         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
         chmod +x ~/bin/make.cross
         # install arm cross compiling tool for clang build
         # apt-get install binutils-arm-linux-gnueabi
         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9645ccc7bd7a16cd73c3be9dee70cd702b03be37
         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
         git fetch --no-tags linus master
         git checkout 9645ccc7bd7a16cd73c3be9dee70cd702b03be37
         # save the config file to linux build tree
         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm clang-analyzer

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


clang-analyzer warnings: (new ones prefixed by >>)

 >> arch/arm/mach-ep93xx/clock.c:154:2: warning: Use of memory after it is freed [clang-analyzer-unix.Malloc]
            return &psc->hw;
            ^
    arch/arm/mach-ep93xx/clock.c:151:2: note: Taking true branch
            if (IS_ERR(clk))
            ^
    arch/arm/mach-ep93xx/clock.c:152:3: note: Memory is released
                    kfree(psc);
                    ^~~~~~~~~~
    arch/arm/mach-ep93xx/clock.c:154:2: note: Use of memory after it is freed
            return &psc->hw;
            ^      ~~~~~~~~
 >> arch/arm/mach-ep93xx/clock.c:484:2: warning: Value stored to 'hw' is never read [clang-analyzer-deadcode.DeadStores]
            hw = clk_hw_register_fixed_factor(NULL, "uart", "xtali", 0, 1, clk_uart_div);
            ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 >> arch/arm/mach-ep93xx/clock.c:612:2: warning: Value stored to 'hw' is never read [clang-analyzer-deadcode.DeadStores]
            hw = clk_hw_register_fixed_factor(NULL, "usb_clk", "pll2", 0, 1, clk_usb_div);
            ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +154 arch/arm/mach-ep93xx/clock.c

ff05c0330b9880 Hartley Sweeten 2009-05-07  125
9645ccc7bd7a16 Nikita Shubin   2021-10-18  126  static struct clk_hw *ep93xx_clk_register_gate(const char *name,
9645ccc7bd7a16 Nikita Shubin   2021-10-18  127  				    const char *parent_name,
9645ccc7bd7a16 Nikita Shubin   2021-10-18  128  				    void __iomem *reg,
9645ccc7bd7a16 Nikita Shubin   2021-10-18  129  				    u8 bit_idx)
9645ccc7bd7a16 Nikita Shubin   2021-10-18  130  {
9645ccc7bd7a16 Nikita Shubin   2021-10-18  131  	struct clk_init_data init;
9645ccc7bd7a16 Nikita Shubin   2021-10-18  132  	struct clk_psc *psc;
9645ccc7bd7a16 Nikita Shubin   2021-10-18  133  	struct clk *clk;
9645ccc7bd7a16 Nikita Shubin   2021-10-18  134
9645ccc7bd7a16 Nikita Shubin   2021-10-18  135  	psc = kzalloc(sizeof(*psc), GFP_KERNEL);
9645ccc7bd7a16 Nikita Shubin   2021-10-18  136  	if (!psc)
9645ccc7bd7a16 Nikita Shubin   2021-10-18  137  		return ERR_PTR(-ENOMEM);
9645ccc7bd7a16 Nikita Shubin   2021-10-18  138
9645ccc7bd7a16 Nikita Shubin   2021-10-18  139  	init.name = name;
9645ccc7bd7a16 Nikita Shubin   2021-10-18  140  	init.ops = &clk_ep93xx_gate_ops;
9645ccc7bd7a16 Nikita Shubin   2021-10-18  141  	init.flags = CLK_SET_RATE_PARENT;
9645ccc7bd7a16 Nikita Shubin   2021-10-18  142  	init.parent_names = (parent_name ? &parent_name : NULL);
9645ccc7bd7a16 Nikita Shubin   2021-10-18  143  	init.num_parents = (parent_name ? 1 : 0);
9645ccc7bd7a16 Nikita Shubin   2021-10-18  144
9645ccc7bd7a16 Nikita Shubin   2021-10-18  145  	psc->reg = reg;
9645ccc7bd7a16 Nikita Shubin   2021-10-18  146  	psc->bit_idx = bit_idx;
9645ccc7bd7a16 Nikita Shubin   2021-10-18  147  	psc->hw.init = &init;
9645ccc7bd7a16 Nikita Shubin   2021-10-18  148  	psc->lock = &clk_lock;
9645ccc7bd7a16 Nikita Shubin   2021-10-18  149
9645ccc7bd7a16 Nikita Shubin   2021-10-18  150  	clk = clk_register(NULL, &psc->hw);
9645ccc7bd7a16 Nikita Shubin   2021-10-18  151  	if (IS_ERR(clk))
9645ccc7bd7a16 Nikita Shubin   2021-10-18  152  		kfree(psc);
9645ccc7bd7a16 Nikita Shubin   2021-10-18  153
9645ccc7bd7a16 Nikita Shubin   2021-10-18 @154  	return &psc->hw;
ff05c0330b9880 Hartley Sweeten 2009-05-07  155  }
ff05c0330b9880 Hartley Sweeten 2009-05-07  156

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org