Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1232579pxb; Fri, 21 Jan 2022 12:56:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJz/+LIj1TYQtbCzWXwGoa2O36nAdds8H5alZsDu9eh1ypKTjM6ct7Q27yOepHpdkvVe1Usx X-Received: by 2002:a63:fe47:: with SMTP id x7mr4063886pgj.415.1642798615768; Fri, 21 Jan 2022 12:56:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642798615; cv=none; d=google.com; s=arc-20160816; b=dg4xyOWtYVAhRLFdNOVkYAPKOJ7m3dlz9Wi0vhyage0heconoeh3uXLj4zYuZGR+fH WSjRUzvtEKUnjhzcJc3VAz7PcdiqJNCbu/0cJIDwvPHCmqLBOkFefSmlYPntOEN7pDsF eBSRuc/aakC7q0ODLNcQu6VhurMGsumB/JymoE0Jg6FBymUZjtCEHjDIkJl5N4H2SnZz /BRr+jQkHUKQ7RW8/TJacUVueRfsOPzfuBTTsKyTDsfADkCXok7qH2nmmDmjKXGVNHSP ggijyNkWQTEat5PSlcy2rThfzsF0LMttrUbfHmROA4WHR846cewRMWFab5j3R025E1vm Ig0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=fXMhBKaGQfjanJ7Rz0k/wIqdxBRVsZLUM/vyPmU7JL8=; b=ye3joKA/WafzVwGfEMQamf5YVP/QyOkiMwXChc0ENpf7IZ2rJiy2WdmezCFPw8oVB8 B1DbHFTimTZgcCsGKxzJ/AitIY7AKhy8PIoiaEwJUOMfOB69o4nOUviqSfHMi+Ub0wVJ G3UiNA+pj5oQEvW7HvM+yEGCNT0ch07TFkfBimCdxu0uDDAEWSya3An+/kIXFaUxzLca WVNtTQWpVLsEuV43khOtK/fBSiH0QexoZSSbEN8++d2T9OhbQOWZfwCVpfIX4T5Zhrku KtsOu8jTg2Q4Lqnm/Ko6KUgGRl2aXXBaN2b8LnaUVMh+uTwQ03RG0uwEW7cxbYvaEa1D OJpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x70si2381249pgd.654.2022.01.21.12.56.43; Fri, 21 Jan 2022 12:56:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358138AbiATB5e (ORCPT + 99 others); Wed, 19 Jan 2022 20:57:34 -0500 Received: from smtp21.cstnet.cn ([159.226.251.21]:60310 "EHLO cstnet.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232065AbiATB5c (ORCPT ); Wed, 19 Jan 2022 20:57:32 -0500 Received: from localhost.localdomain (unknown [124.16.138.126]) by APP-01 (Coremail) with SMTP id qwCowABXXp5kwehh+WqkBg--.26567S2; Thu, 20 Jan 2022 09:56:52 +0800 (CST) From: Jiasheng Jiang To: broonie@kernel.org Cc: cezary.rojewski@intel.com, srinivas.kandagatla@linaro.org, bgoswami@codeaurora.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jiasheng Jiang Subject: Re: Re: [PATCH v2] ASoC: codecs: Check for error pointer after calling devm_regmap_init_mmio Date: Thu, 20 Jan 2022 09:56:50 +0800 Message-Id: <20220120015650.1851703-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: qwCowABXXp5kwehh+WqkBg--.26567S2 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUY67AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E 6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28Cjx kF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI8I cVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87 Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE 6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72 CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7 M4IIrI8v6xkF7I0E8cxan2IY04v7MxkIecxEwVAFwVWkMxAIw28IcxkI7VAKI48JMxC20s 026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_ JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14 v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xva j40_Wr1j6rW3Jr1lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxV W8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUbLiSPUUUUU== X-Originating-IP: [124.16.138.126] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 20, 2022 at 00:46:45AM +0800, Mark Brown wrote: >> Since the possible failure of the devm_regmap_init_mmio(), it will >> return error pointer and be assigned to the regmap. >> Then the error pointer will be dereferenced. >> For example rx->regmap will be used in rx_macro_mclk_enable(). >> Therefore, it should be better to check it. > > This doesn't apply against current code, please check and resend. I am really sorry. I have already try my best to find the latest code but fails. Please give me the url or the git repository. Sincerely thanks, Jiang