Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <c371d737fd5e7e19e966d7aec42da0c3edd9a556.camel@nxp.com>
Subject: Re: [PATCH v2] phy: dphy: Correct clk_pre parameter
From:   Liu Ying <victor.liu@nxp.com>
To:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        linux-phy@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org,
        linux-rockchip@lists.infradead.org,
        Wyon Bi <bivvy.bi@rock-chips.com>
Cc:     linux-imx@nxp.com, Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Robert Foss <robert.foss@linaro.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Heiko Stuebner <heiko@sntech.de>,
        Maxime Ripard <mripard@kernel.org>,
        Guido =?ISO-8859-1?Q?G=FCnther?= <agx@sigxcpu.org>
Date:   Thu, 20 Jan 2022 11:00:26 +0800
In-Reply-To: <20220119023714.1498508-1-victor.liu@nxp.com>
References: <20220119023714.1498508-1-victor.liu@nxp.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.4-0ubuntu1 
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWd1OUlDY0xFNDQzdTdRMjE1OERkTGVPaHZRaDJ1OWhWbVY4VU42YzQrc2tR?=
 =?utf-8?B?V3cyTThRNVlEUW5YQXcwMlVqK3ZMeHNJdU4vVzJKUllhUHJNUURMN2tiWTQ1?=
 =?utf-8?B?S05iTDFJMGhFc0ZHZ1pnQXRVdHhXeUROUmZVN25xcUlRd0hKOEdIMTEycU9o?=
 =?utf-8?B?SkF0YVVQSjNIQVowQWtTMDdUVnVPV3lsemhxRHdaVm9wVk5TRUlCMVlqdXF4?=
 =?utf-8?B?bmtUR2hWemRqd1lWR1laRXFFTEFiMDRmRnRlTjF3S3RpMVEwSlJzS21tRWRr?=
 =?utf-8?B?eGZIMzdyNFppYUU2T1NjeXN3cmQweWFrNWZXV2gxK1lBbmtla0V2LzRnYTJZ?=
 =?utf-8?B?RHg1MldZS2hEWk9GTjkzRWZIZm1LYkN6WXpiT2E3YjNUZEpLQjlXcVZ4RW15?=
 =?utf-8?B?d0kxTDhudE5MTFBUTmk2MC8yb0dvNEp1ajhET2RBcW5qRWV6c0twMUR1bVFE?=
 =?utf-8?B?MkR6SVp3OEpYNGJ5RDZjeVI0SURjSUxvWjdmbGNsb3E5d0haTEdROHptTDNW?=
 =?utf-8?B?Mk9oTkZNdXpxbXM0ZDlCRXZMa3RpRkhKNTdWcFRNNENwNW5XemNPcW9OWFU4?=
 =?utf-8?B?NkxJcXR0UFFoTzhPcmJ1MnpNYVBCemZKOFFDTW5mVExsMW5lZ1RMOFhYdi9R?=
 =?utf-8?B?OUNXZFJmUWQ2cFpZWXNVQmttVjJiU2oyRExYcFdaRHZILzBzVklrZGNjWVRQ?=
 =?utf-8?B?dHBFRndtMUN0aWhyZ2NlaTI2OE5EMFQyMFl1YlI4ZVRrdkVWUmlPSHB2QjFt?=
 =?utf-8?B?U2lrbVlxcnBrQU9hRk4wZmE1eDZ2TXpVK2lBUHpCS2k1ODZHTUhuT3U0eWQ5?=
 =?utf-8?B?WFdjUEZnSXFlZVZrdCtWUTVDV3kzRVBxeDBIc0pnNHljQkhzcVhjakljSC9C?=
 =?utf-8?B?NEVhVE5FcFpFV2V6dEdiQWlJMks0NE14SHB5SXNGR3FNRWJUbHFVeWFOa25E?=
 =?utf-8?B?NW9OQ1lyOE1uU2orTTU4bkFURG5ZYU1BZUQ3aEJYVTNZOC9Qak40YkROTUsy?=
 =?utf-8?B?S2dIY25hSGRRM08yWkxjRVBlMGVMTFNYTm1wRXNQTG1PVmJmcVV3TnlOY01R?=
 =?utf-8?B?bzFRV2VnQ0JKdHUxdG55YkpNelQveTFTNTMwdWplUUtSTTN5R01DTzdadHZB?=
 =?utf-8?B?VzZLTjF0czRtQXpyVjAzb1BPM2FDQ29pLzFzYmRzd0Z5WGpOd1dKQ3pMY2cr?=
 =?utf-8?B?MWpZcml3b1JQL3llc0YrQnd3QWl5akNNSUNIQnJ5ZHNldVFLbkxqK2RETDhO?=
 =?utf-8?B?MTcwUkJFZE1DSHc1bnBPVVBPUU9BYzNSWkh6N09rcmhKblpnZDEyTC9zUFhB?=
 =?utf-8?B?eEFZbU5YSlZxNFl4aVpVZXVJWnJ2SmRwY09MUTVPRnUyNUZ6bTZKdzg0Nkwz?=
 =?utf-8?B?T3duU200N1dyK3pLemhwRkorYkhjVzJXVVc0L1pEWjBUUkNPbEVOSUJnby8v?=
 =?utf-8?B?RmVrQnZQL1E0SjM5bE5KRnNzTE9wZks5OUhlengvN2phajZwQm1XejFDRVEy?=
 =?utf-8?B?Q3JkeDZuY0prNk1xNmV1eE1sYWNsbUxJR1JkU1pUdkVtbWFoRDBXR0Q4aXY5?=
 =?utf-8?B?aWJFRjVrNUlRNWRJZXdxdGFtWlRxN2ZmZ3NNV3VGamx2akpubEFhQXdQRjkx?=
 =?utf-8?B?bTBkVVAzbjV6RkpYS1dISWMvenJmVU83aEVQR0VPb09NR2x6N0NXRGt6aCtK?=
 =?utf-8?B?ei9nWHJBNzJWSGlCY0tmMUZjRkF5NU11VGhyZll4K0FGazhPRXcvVVRwTkF2?=
 =?utf-8?B?aXV2SjZBYTl6cU1XNE9BN2Y2cVh5QXBwT2VXemFuMVQ2UTZmOUxZN3ZMVkIv?=
 =?utf-8?B?YVU5YUNCU1dnTXdVMjlGTVBqa213TTVkdjZyVXVFVW1YeGxDRG0yWURSM1dj?=
 =?utf-8?B?WHNJalhOZEcvenBQVm0vOUQzWVNGUmxYN2ZwVkoyUUtyL21CdmJMb3VsRnBN?=
 =?utf-8?B?MzM2anZoR3FIM3Z4U0F1TXpLdTByVUJYNUNjb1NSQVNmWHNRZFdObDl2a0E1?=
 =?utf-8?B?cjJaOGdiTFl1YWIraHJUSDFMTWpyNEpyTkFtUnhpbXVySTVCNjIvclB1QWI3?=
 =?utf-8?B?VUIvOE85R293U1E5N2RyRzdLWHp1UmZEbTU2L2k1clR4NmFiR3lhT3pDem45?=
 =?utf-8?B?MmpmN3dBMGFHc2F6VitHTGtUdG1Hb1NLMjVjN1JOZG0xWS9ydWpOR2VJSFcz?=
 =?utf-8?Q?FiTd4RprR/iJlSDTLa318l0=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30b5a95d-1779-4dfd-c3ca-08d9dbc10aa6
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2022 03:00:40.6475
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CVC95ur+6RwNLWgenzfAg59/vx3uVGx4G5B5HdVbyUNWINjupT+S1n29o7DaUq744grDxAZGXuOKhzeUndOevQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5552
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Heiko, Wyon,

On Wed, 2022-01-19 at 10:37 +0800, Liu Ying wrote:
> The D-PHY specification (v1.2) explicitly mentions that the T-CLK-PRE
> parameter's unit is Unit Interval(UI) and the minimum value is 8.  Also,
> kernel doc of the 'clk_pre' member of struct phy_configure_opts_mipi_dphy
> mentions that it should be in UI.  However, the dphy core driver wrongly
> sets 'clk_pre' to 8000, which seems to hint that it's in picoseconds.
> And, the kernel doc of the 'clk_pre' member wrongly says the minimum value
> is '8 UI', instead of 8.
> 
> So, let's fix both the dphy core driver and the kernel doc of the 'clk_pre'
> member to correctly reflect the T-CLK-PRE parameter's unit and the minimum
> value according to the D-PHY specification.
> 
> I'm assuming that all impacted custom drivers shall program values in
> TxByteClkHS cycles into hardware for the T-CLK-PRE parameter.  The D-PHY
> specification mentions that the frequency of TxByteClkHS is exactly 1/8
> the High-Speed(HS) bit rate(each HS bit consumes one UI).  So, relevant
> custom driver code is changed to program those values as
> DIV_ROUND_UP(cfg->clk_pre, BITS_PER_BYTE), then.
> 
> Note that I've only tested the patch with RM67191 DSI panel on i.MX8mq EVK.
> Help is needed to test with other i.MX8mq, Meson and Rockchip platforms,
> as I don't have the hardwares.
> 
> Fixes: 2ed869990e14 ("phy: Add MIPI D-PHY configuration options")
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Robert Foss <robert.foss@linaro.org>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: Jonas Karlman <jonas@kwiboo.se>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Guido Günther <agx@sigxcpu.org>
> Tested-by: Liu Ying <victor.liu@nxp.com> # RM67191 DSI panel on i.MX8mq EVK
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> v1->v2:
> * Use BITS_PER_BYTE macro. (Andrzej)
> * Drop dsi argument from ui2bc() in nwl-dsi.c.
> 
>  drivers/gpu/drm/bridge/nwl-dsi.c                 | 12 +++++-------
>  drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c    |  3 ++-
>  drivers/phy/phy-core-mipi-dphy.c                 |  4 ++--
>  drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c |  3 ++-
>  include/linux/phy/phy-mipi-dphy.h                |  2 +-
>  5 files changed, 12 insertions(+), 12 deletions(-)

[...]

> diff --git a/drivers/phy/phy-core-mipi-dphy.c b/drivers/phy/phy-core-mipi-dphy.c
> index 288c9c67aa74..ccb4045685cd 100644
> --- a/drivers/phy/phy-core-mipi-dphy.c
> +++ b/drivers/phy/phy-core-mipi-dphy.c
> @@ -36,7 +36,7 @@ int phy_mipi_dphy_get_default_config(unsigned long pixel_clock,
>  
>  	cfg->clk_miss = 0;
>  	cfg->clk_post = 60000 + 52 * ui;
> -	cfg->clk_pre = 8000;
> +	cfg->clk_pre = 8;
>  	cfg->clk_prepare = 38000;
>  	cfg->clk_settle = 95000;
>  	cfg->clk_term_en = 0;
> @@ -97,7 +97,7 @@ int phy_mipi_dphy_config_validate(struct phy_configure_opts_mipi_dphy *cfg)
>  	if (cfg->clk_post < (60000 + 52 * ui))
>  		return -EINVAL;
>  
> -	if (cfg->clk_pre < 8000)
> +	if (cfg->clk_pre < 8)
>  		return -EINVAL;
>  
>  	if (cfg->clk_prepare < 38000 || cfg->clk_prepare > 95000)
> diff --git a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
> index 347dc79a18c1..630e01b5c19b 100644
> --- a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
> +++ b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
> @@ -5,6 +5,7 @@
>   * Author: Wyon Bi <bivvy.bi@rock-chips.com>
>   */
>  
> +#include <linux/bits.h>
>  #include <linux/kernel.h>
>  #include <linux/clk.h>
>  #include <linux/iopoll.h>
> @@ -364,7 +365,7 @@ static void inno_dsidphy_mipi_mode_enable(struct inno_dsidphy *inno)
>  	 * The value of counter for HS Tclk-pre
>  	 * Tclk-pre = Tpin_txbyteclkhs * value
>  	 */
> -	clk_pre = DIV_ROUND_UP(cfg->clk_pre, t_txbyteclkhs);
> +	clk_pre = DIV_ROUND_UP(cfg->clk_pre, BITS_PER_BYTE);

For the Rockchip part, can you please give a test? Any comments?

We already have T-b tags on i.MX8mq and Meson platforms.

Regards,
Liu Ying

>  
>  	/*
>  	 * The value of counter for HS Tlpx Time
> diff --git a/include/linux/phy/phy-mipi-dphy.h b/include/linux/phy/phy-mipi-dphy.h
> index a877ffee845d..59a5e77ab409 100644
> --- a/include/linux/phy/phy-mipi-dphy.h
> +++ b/include/linux/phy/phy-mipi-dphy.h
> @@ -42,7 +42,7 @@ struct phy_configure_opts_mipi_dphy {
>  	 * the transmitter prior to any associated Data Lane beginning
>  	 * the transition from LP to HS mode.
>  	 *
> -	 * Minimum value: 8 UI
> +	 * Minimum value: 8
>  	 */
>  	unsigned int		clk_pre;
>