Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 20 Jan 2022 06:55:43 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Kees Cook <keescook@chromium.org>
Cc:     Jiasheng Jiang <jiasheng@iscas.ac.cn>, arnd@arndb.de,
        gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] lkdtm/bugs: Check for the NULL pointer after calling
 kmalloc
Message-ID: <20220120035542.GC1978@kadam>
References: <20220119122055.1826561-1-jiasheng@iscas.ac.cn>
 <202201191044.69872866B@keescook>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202201191044.69872866B@keescook>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6EEoq1K/PVF5a3OcrXfoFZ0WqHNBjJLOR6BxAw6ihjb2dAI+KvGc/3UQHMB9?=
 =?us-ascii?Q?HgiDJFiRijWEEGPjQodJPUN46AYCGGvUflSgYF7rJ5FpnAjibfcPQgVR+5Q2?=
 =?us-ascii?Q?psy3lASUOQFD/tVzhkcD/DpfmvcOwOEQvhqtHT3jLzGUkp5xy9RmPNvMD1nR?=
 =?us-ascii?Q?Be1OhyKBjX6Y4aR43fLWVHGpOIGVjPCWOXwoSx5qlATXe105/QLKFSqzfJde?=
 =?us-ascii?Q?EMjE0cqlOrAqg6g0n9k1oPxBXVHS/MQDEmZBekRgmULK2Jj+2wnlFVz1ktVC?=
 =?us-ascii?Q?9Tr6D7CiPJwJ3zQbv7imyQYNaJptimPIPvCsafM8ciwTqVlRD5cw1Q6q2RNj?=
 =?us-ascii?Q?TcknTwFDlP1sDPK3IvpQtyCQ4IOyPKR8MtO/ChmsbBJATSo89niYY38PQRj2?=
 =?us-ascii?Q?Wb4O4ZzpZkhpuARaulkHzUyVChKoEZ9XBbnO9VtdiPsiNuLSRS/4u2kyRV20?=
 =?us-ascii?Q?fkch+rwzR4C0xm2Ape4xNrbVxpys3wbDJN70YIp5ZBvCl1weau8WksNd/hbr?=
 =?us-ascii?Q?j0XfpE2RxMIedeCijkKYCeMJ4hX/X8XoT0oQqBrp8Kgf6t7FrNTVs+uYrmFc?=
 =?us-ascii?Q?C9ZJBpMa7jwjROrrZkeMndcjU0qTbjuvtbuZostkAmnr8p7+JteYpQeUsUh9?=
 =?us-ascii?Q?tyU4Of41lZrcb6KJmLT/rDgZLkKiD1gh77Gsae0gDHVPV1Odbhle4bIEAggh?=
 =?us-ascii?Q?LAwvllkOguuw+SJsfQot1BgSEiznntryIePtK2BEgUK0FYPyQtWDPyYe8Ozy?=
 =?us-ascii?Q?xt/rK8mtgVeEhESupHZ8+IccIlzaqc0E4jVTNQpKxEb7394n9vqXaP8H5PKk?=
 =?us-ascii?Q?xrCHbhsk/EF9pblxLqd+ocoZd9OUaU7kW0MNrXPFSldv+5AqMTYoN5W5w5as?=
 =?us-ascii?Q?lYQukRn8r8yMxhVnTBmtD2nl6QO9pJjTrsMAL+56i3JE3Ieano/UHCg7NlB/?=
 =?us-ascii?Q?54q16MsLMS79pInghAWok9kiPW3XrAKHOcWekLLQ0uqU0CEY54DS6CzDO/tW?=
 =?us-ascii?Q?TAiEwZ4aVMwncxlP6z+xEeNHpASEs4dbPLXiA6AmyO+ii9wd9UskPke9usEZ?=
 =?us-ascii?Q?9DUa1Ig0yqw/tx3d7eGCwJVYb8Tds2OqUNViNfgk6DP7tlVYc6Pt0XzCZaHo?=
 =?us-ascii?Q?/Ufv3dusdi0NlzMCOU9pUbHSaxYnCOQhtMTj+DviUJh8LiEJOmyHCjCfnLKL?=
 =?us-ascii?Q?WBnrC/ElvR9edaF4qJpplUnfxxN+Ea+WUVLKq42SjtIM1LlbMUb8Skqy3CZK?=
 =?us-ascii?Q?5/qLDzZ5rf0fiFaCX7V2H2pEvzc6K3+2A2yd3f0/1PK1NveeC3vyKV5G2lu/?=
 =?us-ascii?Q?mFWhhaQgLj9SrD7qJlg7Lt+B4ocfCA31D3Gzg0qPTLoGPjQ8im2yAUc0DEoF?=
 =?us-ascii?Q?FKbJDdnvLpuzeWQV40nPNnf9HLX7rPoZ2m29G2en2g0ItOBQYTMX7mtBGVrQ?=
 =?us-ascii?Q?c7W+HIF69mKZ1aDbOIkN/7fR2S55Od4vKBVgSpt3oUc01e5IONBW97TMH4VL?=
 =?us-ascii?Q?bzuPPpurrNiwgFF1rY0n0RDZ1hZzO8PDoBEy2SnPItAQQ1s/MIn/icFsc3uB?=
 =?us-ascii?Q?rXrVaiSeoxDHer2dUO/iEJJCgLAmuW6RvhAgU1N4Y4owXtOKEUbiY41AYuYi?=
 =?us-ascii?Q?DlYGiWYa5zxirfe4svr1gpD1L9IgP6ofxf3y4bby7HJldhsnqTlBi/Zzoc8g?=
 =?us-ascii?Q?GQeIxOEff9m1fp6GcB+8Tz72BoY=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb76bd4b-2d96-4eee-c8ab-08d9dbc8c686
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2022 03:56:02.3893
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1q+xcBgrHe7J7X8WRduCZQ9eXrB3g1OaeFVg1+VHU1MX0BNVC3cJzxgAsfy1t7j3zvyalupGaPFiRHh8XrEgVJZhiyKevkstlJxJS1dQYyk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3304
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10232 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0
 malwarescore=0 adultscore=0 phishscore=0 mlxscore=0 spamscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201200019
X-Proofpoint-GUID: b0palV1e2DR61oxTyQsTiu8UB_VWNydm
X-Proofpoint-ORIG-GUID: b0palV1e2DR61oxTyQsTiu8UB_VWNydm
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 19, 2022 at 10:45:33AM -0800, Kees Cook wrote:
> > diff --git a/drivers/misc/lkdtm/bugs.c b/drivers/misc/lkdtm/bugs.c
> > index f4cb94a9aa9c..c35ea54824ac 100644
> > --- a/drivers/misc/lkdtm/bugs.c
> > +++ b/drivers/misc/lkdtm/bugs.c
> > @@ -325,6 +325,11 @@ void lkdtm_ARRAY_BOUNDS(void)
> >  
> >  	not_checked = kmalloc(sizeof(*not_checked) * 2, GFP_KERNEL);
> >  	checked = kmalloc(sizeof(*checked) * 2, GFP_KERNEL);
> > +	if (!not_checked || !checked) {
> > +		kfree(not_checked);
> > +		kfree(checked);
> > +		return;
> > +	}
> 
> This should explicitly yell about the memory failure. See the other
> error cases for examples. I'd expect something like this before the
> return:
> 
> 		pr_err("FAIL: could not allocate required buffers\n");

Adding error messages for kmalloc failures is a checkpatch violation.

Those allocations will never fail.  There is already a warning message
and stack trace built into kmalloc().  It's just a waste of resources to
add the warning message.

regards,
dan carpenter