Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Alexei Starovoitov <alexei.starovoitov@gmail.com>
CC:     Song Liu <song@kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "ast@kernel.org" <ast@kernel.org>,
        "daniel@iogearbox.net" <daniel@iogearbox.net>,
        "andrii@kernel.org" <andrii@kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v4 bpf-next 6/7] bpf: introduce bpf_prog_pack allocator
Thread-Topic: [PATCH v4 bpf-next 6/7] bpf: introduce bpf_prog_pack allocator
Thread-Index: AQHYDYlCsyEKG86ANky3ljsiNA7gyaxrTVOAgAAJeYA=
Date:   Thu, 20 Jan 2022 04:48:15 +0000
Message-ID: <FC0F20F4-8B5A-428A-BA48-3ABC49723327@fb.com>
References: <20220119230620.3137425-1-song@kernel.org>
 <20220119230620.3137425-7-song@kernel.org>
 <20220120041421.ngrxukhb4t6b7tlq@ast-mbp.dhcp.thefacebook.com>
In-Reply-To: <20220120041421.ngrxukhb4t6b7tlq@ast-mbp.dhcp.thefacebook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TgIR0USLwn+H2qNMM+XbFAtZU50h1BkhAC42o1B0VTBTo1OI+OBNkbpUCgAu?=
 =?us-ascii?Q?2WrxUhQDDsziG0Q0kmyMri4DinBQBQASm1dFNVzoBfV+K0D0KWq/azHUt0Xh?=
 =?us-ascii?Q?rQ5NGSJZJtvRQwcgbKxPw7fiEuK8RTk5OHtsiYmzCUkkFT1DTl7M0SBvF1+C?=
 =?us-ascii?Q?MtWyIEkYjhMh3QPqNnsEfDAnDAFABa9+3AxUaPR4bdq4w3cpooM2AIC8lrkc?=
 =?us-ascii?Q?uwWXqpj3zNO7MGY3VGgFzlEYRW0xSRoDH/gRPTE6/GkgKlcHas9/CMhgRWR3?=
 =?us-ascii?Q?hZ3fwzabXFrSDS/xvY7s3U47+CuwyFM3ZRA8YPd8/bfgAZA5YGo/KBOF8jjI?=
 =?us-ascii?Q?s/8Vxe2g7Ve0YTXADhIv0A9bJqq0M4eZoQPe+h7RxHgVrgBnosqGGJ/gXGY+?=
 =?us-ascii?Q?4Jtm593vjiLw5HZ35dLgtyvImgQXC0Zqeoq4FK4i0iNyhlcvtI6HrWiceJHJ?=
 =?us-ascii?Q?4XO4LtuJovanv0+YdA6PJBKH3kpcsOxmIBK5E+i7mI9bB1VkcIe0/15fofZe?=
 =?us-ascii?Q?/x8MXY976pDxIX1HRdGF8F6EtaUlYDoSVGbyAhV2DFiXsbuVwTNcC8Ohw6kf?=
 =?us-ascii?Q?5lyJrOR0HEocPQ2ZDTSUFUy3ixvQraRaLK2eRDxD6gnucc4HSTohpFNhqZg+?=
 =?us-ascii?Q?uV86fc6yX1aBQU7JgVN7xavjxLTpp/x421YCVfluWdXwGj3u6OnH2ObbzgPZ?=
 =?us-ascii?Q?TEq1PYxduUW49YQ5MZIpl8HJfRjPPINmAHgEbGCb7WJByK9dkTNbWvSQY35u?=
 =?us-ascii?Q?xpbLfl/MTjw8M6e0qMt8JprbnXxEIM8WEWDHkFqToqIZL3RY3GCzh+9+oSwD?=
 =?us-ascii?Q?A5jH9mbc5CUQp4DMyZFEN6rTLhYOfbC+AVjq1GDEzypHNWsPuUDTTmJYgemP?=
 =?us-ascii?Q?k7llRVNVVi6b0xBXsonaRsNqafVUK+/wsMo15vxktCFv01djxx75Qci8ywLr?=
 =?us-ascii?Q?JLBKwdI6OAlPUexzbueFDZhmQPIz6iZANkb9h+UirATLgb433SvNFX1c322f?=
 =?us-ascii?Q?9O/7rASUTPxoE5vVtQLPf7Gl9z73yJi7WvzZaikuFjH7qCi6zegw3F0m1Mmk?=
 =?us-ascii?Q?xM3Mk74+mSB7XPaYU4HrGIPh5ivPuWZ4L4/0G2rRS5yEA1m8hTVgDnApl92c?=
 =?us-ascii?Q?wMNSAZoEHMrxT1FpN2c4UpXPbLpCRtqpTHNyfsKOgyBF9iPs+kwa8e83zul6?=
 =?us-ascii?Q?IxYiA3rLXlFPaZHzc2cbiL++S4viFnFM0NsIVak1pgd4iT+YzJGt1WMvRXTB?=
 =?us-ascii?Q?T6W7kJOiZcmzDzoeeoUNuSIiJycNVxB2MgFUJGCC/kfAmjPDr6jRS5ITq51a?=
 =?us-ascii?Q?D8Cw886BNKoOTLGJRpzAThB3xOjPuU9VB4Ql1mHhK5xPv+3kMX8ipU9sMzcC?=
 =?us-ascii?Q?Y7hlvtdvbpbf+M5Xqzxg4gsDdG+BHPF5zF/M1O0Rm0uoJUpYuBPVGBCklUKL?=
 =?us-ascii?Q?QMV5nb3KQlZ7JfFrU6gT1CO6RBskOlUd78ZEEpMZ53Et2Frtj0YMWAhtUJPX?=
 =?us-ascii?Q?Xk4vmY1Qyax0f8hFiwgKfYp/SIFHDJztpXaNCbG6z/RY/ixye6juMHRWCHXj?=
 =?us-ascii?Q?U7/ls6L/uqj0OKIMcrnfZNlvBzUhOpXNkt8k/c5OEb72k5JWFqPFJkihq/mP?=
 =?us-ascii?Q?fCK+Gon6TAj6K1y1P7nGt53/hFYaFfQ8zpIOJVcMfEe7P9efKW1CDShwCokC?=
 =?us-ascii?Q?hB3lyQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A39E899216ACA24BA1182EBEF2B3A2D3@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2892a34b-b1e9-4e49-d938-08d9dbd0127b
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2022 04:48:15.8485
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cXebSHVn+8KR0pXynj0kIcStF7Xf0vcbxh/MlQTlJq9ELV3GHC3xzeVV3Gk7ogNYMLjr90MC5LZIsp5V+s3A3A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR15MB4269
X-OriginatorOrg: fb.com
X-Proofpoint-GUID: 73IUG35_htQpU9FQAZq9uOFjBnPp1KDf
X-Proofpoint-ORIG-GUID: 73IUG35_htQpU9FQAZq9uOFjBnPp1KDf
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-20_01,2022-01-19_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 impostorscore=0
 adultscore=0 suspectscore=0 priorityscore=1501 mlxscore=0 bulkscore=0
 spamscore=0 clxscore=1015 phishscore=0 malwarescore=0 mlxlogscore=900
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201200025
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jan 19, 2022, at 8:14 PM, Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
> 
> On Wed, Jan 19, 2022 at 03:06:19PM -0800, Song Liu wrote:
>> 
>> +/*
>> + * BPF program pack allocator.
>> + *
>> + * Most BPF programs are pretty small. Allocating a hole page for each
>> + * program is sometime a waste. Many small bpf program also adds pressure
>> + * to instruction TLB. To solve this issue, we introduce a BPF program pack
>> + * allocator. The prog_pack allocator uses HPAGE_PMD_SIZE page (2MB on x86)
>> + * to host BPF programs.
>> + */
>> +#define BPF_PROG_PACK_SIZE	HPAGE_PMD_SIZE
>> +#define BPF_PROG_MAX_PACK_PROG_SIZE	HPAGE_PMD_SIZE
> 
> We have a synthetic test with 1M bpf instructions. How did it JIT?
> Are you saying we were lucky that every BPF insn was JITed to <2 bytes x86?
> Did I misread the 2MB limit?

The logic is, if the program is bigger than 2MB, we fall back to use 
module_alloc(). This limitation simplifies the bpf_prog_pack allocator. 

Thanks,
Song