Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Jankowski, Konrad0" <konrad0.jankowski@intel.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Jakub Kicinski" <kuba@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        Christoph Hellwig <hch@lst.de>,
        "Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH] iavf: Remove useless DMA-32 fallback configuration
Thread-Topic: [PATCH] iavf: Remove useless DMA-32 fallback configuration
Thread-Index: AQHYDdRD8oH/E9S7X0m7KiBgTxInqQ==
Date:   Thu, 20 Jan 2022 08:03:52 +0000
Message-ID: <DM8PR11MB56216BAE634CBAB39F0F88E2AB5A9@DM8PR11MB5621.namprd11.prod.outlook.com>
References: <afb3317bc87677096e55fc96f317df29f2ff3408.1641752631.git.christophe.jaillet@wanadoo.fr>
In-Reply-To: <afb3317bc87677096e55fc96f317df29f2ff3408.1641752631.git.christophe.jaillet@wanadoo.fr>
Accept-Language: pl-PL, en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?u22u15VhPT1w+wyD1eWEBnx3rO97HoSukycvAbxTra1td5mtXUV+teMRdNoE?=
 =?us-ascii?Q?pRmuVwP/DXxn/jT7Uuq1qDNRH1fzcxvvPUlmEVlG4w6fCa3TLoIkz3c+MKvC?=
 =?us-ascii?Q?pKNtRom+xqa4L13oxmGr1hQh66G0jDfr+ckC/7Cqrf+Bktd6XJ3qprFCe1ZH?=
 =?us-ascii?Q?1i5Eh0RUCsajd9MHqC6TkGNoBEWTvy/2F8D3bIL4TkMIsArycSWkn6gsyx/K?=
 =?us-ascii?Q?jhTLerZOqUtrXzqhX39tAZSxrU+1yTr3OYeMRAROyENQ5rQlN5cfpu6tx7H/?=
 =?us-ascii?Q?mFdX+RKUmSHmSlWyY1b2a/RJrWYB+2uM+CYdybs64qtLRuK1gt2fSJ7oPoml?=
 =?us-ascii?Q?cBUgO4v1PhBj0Tr+pe3Lk9DSoKP9iAWAf94L6PU3oND/DEuq6yBbROhOUABB?=
 =?us-ascii?Q?Yb65Tm65c6i4MhAaE4I/Q31ImpX4mFHUpXAA57qUqbMTGP1cndoCgoZxuUKJ?=
 =?us-ascii?Q?XSCJDXYcepmFkS6WOPsn2PEZHjESKVhdklK+lcxTqsTd+JqYwG1ft32u5lem?=
 =?us-ascii?Q?toiaa3YMUyBfz6wYaDAZ/prcKax/+3E97HugngjWXK4/jQA0OcSuF/uUGozY?=
 =?us-ascii?Q?yJvBX6mhHHmcbD7p9yrCyy73fz+pk7f3I2bzDuEe7HIoki9AP1m4NJFQPtzl?=
 =?us-ascii?Q?oKO7SF0baieLWgBGpwrlkG+XWeffOI7A/M3Nh8JSdaGiSXshrO4UTh35g+h4?=
 =?us-ascii?Q?Npbircz+9Vf35viJfS3qPITN7YnN7JSlzdKIrRfTD8fwW3vPYbJ7FTbnBFVo?=
 =?us-ascii?Q?Rjr68/16tVd6WYHF7JRCqFpm4fLtIIUo5dHm9/pW6yfyZ+ExiueiixbTX2YP?=
 =?us-ascii?Q?WbsNG6nNu1aSrX01boZcfIHo52X129ZMpl5sRmWHh4kH0QAb3eVx0xgN9oTv?=
 =?us-ascii?Q?kPVRN3y+ClBEXSwJfj+ZwplRqLVS3epalc1r1RRGqMZTyCmLYy4yalagMdnr?=
 =?us-ascii?Q?P6IWdLl4eRzJE6AxXVzopNhmR2mnqbITIFwH1hl2Bi4nJYdBIuv1BsGhM0o3?=
 =?us-ascii?Q?cRNWpe0q5aS8p13wLGdER1ga0pqjHfK7GaydXGNxzQ3M0s881b6a+GVkWzyn?=
 =?us-ascii?Q?07w4gEPlty+1vAUKMDLPwYyVSmn5QPoI9cUW9K2vN4AIcdg71oGOZt5aKDPn?=
 =?us-ascii?Q?S24j8cxrLtoMAxT9E1p99L9gjFJkbze2vPqqJgSFpXniAciOrRv8Dt0C/Qcq?=
 =?us-ascii?Q?ZYEuEs6a/skpDfzT8LnueIgl/L4g/laWhUTu5eyhP0RD91dVnmdrSE77KS1R?=
 =?us-ascii?Q?cgA36HdQtQ2pS8/4kcJFtYd2Iwprse6SlPyS2wxayMokjAPWTph4SLMzfswf?=
 =?us-ascii?Q?0FCIBniSJwsdFV7nPl9qBDoLZhq580O/J7+VvuamHxysg+weVvNPBLS3LI7I?=
 =?us-ascii?Q?4ESxLrx8v/ZylklGLGHQvogBd6ivkPbj5qvvhAdrzJ+/f5TvlB4KUJi6qEO4?=
 =?us-ascii?Q?ZIlGkWghipcbOklYtjDKkN+Lc39iUQ3dVT3T6ygKQBjPdKcrF/bafgjEYKHw?=
 =?us-ascii?Q?18i5lUmufI+TvFEtcsFxfnmA5/nu+qvOcJFppexcL2L2yYRw77/66GEVrIE9?=
 =?us-ascii?Q?uhd8IWAOY/VnHJcXTi7Oa6M1eg2Cb7dWkZPX1ALOKZzSifFMdTmWI30k8Jdu?=
 =?us-ascii?Q?d7+A7gFfNvqZcVyXcPkV7qlOhyOfumKNpQrtIB/syeUzgKTYaQcrx5l9D82C?=
 =?us-ascii?Q?hKCqeQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5621.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d8d5de5-168a-497b-e04a-08d9dbeb6633
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2022 08:03:52.7328
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: S+X6if+RQqGcS2Vde1bNOWE97fLzATmG7EJUHa3PeFnh2QCqMtdheXQxgsFndpkBP0+2dMXaJNyef86c6gWbuOfpuDyviwx4AIGS51FQ50s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1331
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Sent: niedziela, 9 stycznia 2022 19:24
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>;
> Jakub Kicinski <kuba@kernel.org>
> Cc: linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org;
> Christophe JAILLET <christophe.jaillet@wanadoo.fr>; Christoph Hellwig
> <hch@lst.de>; Lobakin, Alexandr <alexandr.lobakin@intel.com>; intel-wired=
-
> lan@lists.osuosl.org; netdev@vger.kernel.org
> Subject: [PATCH] iavf: Remove useless DMA-32 fallback configuration
>=20
> As stated in [1], dma_set_mask() with a 64-bit mask never fails if
> dev->dma_mask is non-NULL.
> So, if it fails, the 32 bits case will also fail for the same reason.
>=20
> Simplify code and remove some dead code accordingly.
>=20
> [1]: https://lkml.org/lkml/2021/6/7/398
>=20
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Alexander Lobakin <alexandr.lobakin@intel.com>
> ---
>  drivers/net/ethernet/intel/iavf/iavf_main.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 8125b9120615..b0bd95c85480 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c

Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>