Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1243072pxb; Fri, 21 Jan 2022 13:11:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJwnURqg4BmxecV6HCbazAAOg26FDMNV6A6sryb9HQKe0xx027t9TvVRAYsdDXnv7sr62Ecm X-Received: by 2002:a17:903:11c6:b0:149:a969:7825 with SMTP id q6-20020a17090311c600b00149a9697825mr5544077plh.33.1642799471950; Fri, 21 Jan 2022 13:11:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642799471; cv=none; d=google.com; s=arc-20160816; b=i79RyBh0HOOEAJibFd2scJ2+cPiCnU09JH2slTiYnCRgcEaWfArwYXjIjsiP1mH5kE PAuAmoNlCDFPik6dXh+vwGVbH1w91sKeSOGp5kUZRvxgB2nQQS1UZ5noBuKHehaX3OZC oj6gVvQdZ4ODHqvxF+jAYwPjELgE+ZWoG+NNchhLXd+F/qUhqVzhWpwCqS8s0/b8YD/8 XlV2Z+dQ6lqXKURo+Yuzc07pP12XwHPSM+NwxDvbH820SL8CsNjTGE4HwWJsZ3dGG2pl bN124mTPIiBlkIikWi/DgQK92q+2TxsJAetaN20LkpNxh+5OVXbA6scWcMKPr/3ffUsB 4R0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=fNusMrWQ+iaAxCx5W24yZJ93BWZfAuFDm6S8/KGzbK0=; b=qQsgdBnR0hculzrWTUK47RiJrBlKqqXI5uh8JPs3c7HaLpq2/WClj2nkRoicsPoX53 vmeBHPcS2RPibNAFIVGRbS0yRR/YyjXgPHm/qHmf9kxlxRNppgbwWKDSXlMqSVHiefrR r4cPhPDH1Z4hdqkdiREL71gYOcMNXnQJTOm7SgmJ4js14BGPgv7zuJuXmeRuh2Rnwvfe YBwYrOL8PvhpJXBSM03z93n+G7A8epIl12yriUdXc0CyXJ4aAlF9Kgheoyrqr2KGNUcm CdPNovf4z7cMet3GTTjt8RsZ5/VnFgiNdlf3oZgUsTQtt/SF8vUkRZdjYMkJwn4eDZCC JcjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=D39kfHS+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u15si6155284pjr.84.2022.01.21.13.10.59; Fri, 21 Jan 2022 13:11:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=D39kfHS+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359408AbiATIr7 (ORCPT + 99 others); Thu, 20 Jan 2022 03:47:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359413AbiATIrq (ORCPT ); Thu, 20 Jan 2022 03:47:46 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 279FFC061756; Thu, 20 Jan 2022 00:47:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fNusMrWQ+iaAxCx5W24yZJ93BWZfAuFDm6S8/KGzbK0=; b=D39kfHS+T/0kWsqL02joFtiv09 ubeTypbD4543NiZpFkfezmtBZWQPlrZpYwm/nLxZD9YK8pWH41dX2UJdscRc7NmMJvro+lxKIaBId K7jnSerZ73JAr+mJgGNAbVwjVHOW9sFo2xVDGlluJ5YFRPbCzMgZWrwNKA1PwHpa3SU0W6DbeyEZM 8Jhb0XYD0mJ+HB19llClYpTW+tEqw/tkvKNOsFZfQsn8N3aCVrg/s/BVVvN1k/LtRGQa2vqe92Uv8 WYO1RKbzkm+czYu/+x0/YVypor1v53PG6zh7AENpjveWc5STtRuijyEz/bq9rbZuNmyIZsgE89SL4 P4DvTPTw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAT6S-009tud-Lg; Thu, 20 Jan 2022 08:47:32 +0000 Date: Thu, 20 Jan 2022 00:47:32 -0800 From: Christoph Hellwig To: Shiyang Ruan Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, dan.j.williams@intel.com, david@fromorbit.com, hch@infradead.org, jane.chu@oracle.com Subject: Re: [PATCH v9 07/10] mm: move pgoff_address() to vma_pgoff_address() Message-ID: References: <20211226143439.3985960-1-ruansy.fnst@fujitsu.com> <20211226143439.3985960-8-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211226143439.3985960-8-ruansy.fnst@fujitsu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 26, 2021 at 10:34:36PM +0800, Shiyang Ruan wrote: > Since it is not a DAX-specific function, move it into mm and rename it > to be a generic helper. > > Signed-off-by: Shiyang Ruan Looks good, Reviewed-by: Christoph Hellwig