Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 20 Jan 2022 10:46:06 +0100
From:   Michal Kubecek <mkubecek@suse.cz>
To:     linux-kbuild@vger.kernel.org
Cc:     Masahiro Yamada <masahiroy@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: kbuild/cert rework for 5.17 breaks build with empty
 CONFIG_MODULE_SIG_KEY
Message-ID: <20220120094606.2skuyb26yjlnu66q@lion.mk-sys.cz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="zlp7bthohk7hfvou"
Content-Disposition: inline
Precedence: bulk


--zlp7bthohk7hfvou
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hello,

while testing merge window snapshots, I noticed that after commit
b8c96a6b466c ("certs: simplify $(srctree)/ handling and remove
config_filename macro"), build with

    CONFIG_MODULE_SIG=y
    CONFIG_MODULE_SIG_FORCE=n
    CONFIG_MODULE_SIG_ALL=n
    CONFIG_MODULE_SIG_KEY=""

(as suggested in Documentation/kbuild/reproducible-builds.rst, section
"Module signing") fails to build as make executes scripts/extract-cert
with only one argument (the unquoted empty string has no effect):

  ...
    certs/extract-cert  certs/signing_key.x509
  Usage: extract-cert <source> <dest>
  make[2]: *** [/home/mike/work/git/kernel-upstream/certs/Makefile:78: certs/signing_key.x509] Error 2
  make[1]: *** [/home/mike/work/git/kernel-upstream/Makefile:1831: certs] Error 2
  make[1]: Leaving directory '/srv/ram/kobj'
  make: *** [Makefile:219: __sub-make] Error 2

Should this be considered a bug or is there a different recommended way
to get reproducible builds now?

Michal

--zlp7bthohk7hfvou
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEWN3j3bieVmp26mKO538sG/LRdpUFAmHpL1YACgkQ538sG/LR
dpXP2gf9HThoe4kKpmxYCoAAAJINNR9E2LNPlJgzbu7N47BQwYcS6hh/WDBTBoXg
Rrd6rZiiYWfteekWKbzYs/7UkSk1E8OmMg1PxjxGkjgYPlYvkvumAZcz5bTpAQo/
TwFzwWLhFVDRlT7k/FddbtJriHien79kumsm0lZtr68nra9jF7x8T6zCFrMoPQQU
QZllWyfweF1gIyW4B9VCNtvQtArriban+VhyssVKrmtn/8qwz7MQp16V2/JLIx3n
gwFvTYuNhchnM0f2wBJL6z93CnBfdHyneTTl4GNKceXSQwkLfZwjWdopWCzzDXs8
eSBtBDqnMns5jweRP4XjIzsiLXq7WA==
=MDME
-----END PGP SIGNATURE-----

--zlp7bthohk7hfvou--