Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1248968pxb; Fri, 21 Jan 2022 13:19:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJwZpepBj0+0mOt7DuYPb+britKXF0bdjKenjkjuPh3LCD01j8QFAyRLW1dR1FtByzlWp1DM X-Received: by 2002:a17:903:24d:b0:14a:677d:843a with SMTP id j13-20020a170903024d00b0014a677d843amr5280270plh.129.1642799997141; Fri, 21 Jan 2022 13:19:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642799997; cv=none; d=google.com; s=arc-20160816; b=IsRYDQzi2h0wLR26pWe22XDFetWPSLzB4v1po0nmpR86ggZR8AliKOOahXkUmW1knI beRhZMO1hFvEdrUoVJvBDBzCjd226sM1w6CWKV6emycMkW0Ycxu5Ye2sc9Jyrxfn2mFZ QBzNER2hTkcs9F+qkDk+XpthBikTQ/oHB/lPhNwce0im/TOJKF8ccUTX13Cy/uQ8lod4 czVYQSUG/ko3Bl0QyrqV7gK/TGOiZgHpdWjRArx9z4Bd1UHN7ea87gzjIRKeH3a4g/Vp yfUqH6T7MeZLHu056Y0HggPQSc3mxajKAPycjxlF6zOSpfHNykvpmoPMGhrtiPUdOKpw OQ3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=PWXf9U9ip1SlEBsO3DM5W2hgX/Z8F0qlAhGez6OXS/k=; b=RWcp4+cNk7X9ZLoDQdxyNAFa1vid7PtSDw8LUquVMU3czGubEFnUsQnFVFdrR3JM8l gWtMHYg6Z8MKRVNptV9uhqA/4uvJ48bvrDtxSFh47zuIIepC2xDAka7/d4Te5f1VE70U fZFXSEMwr1M23g756GUPR5HU81f+Kdg56nA3gRkC1yM7VPA2hOKkPwPqu3WCP75BaCTZ DA+N0AQt2mvVehjmtt9bV4CkJWBGXWzTb0cGFxdvIm9nIEqv8eGGyUbZAaUVBt5IbmlQ crQgjGHZ26lTkzJ5IXtbVxY4Rop+D6vqvGy0HphFvUWx2SU4G8Adt3CsrwsiPko0sBLp 0xXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=qy6SAarL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n193si5837173pfd.121.2022.01.21.13.19.45; Fri, 21 Jan 2022 13:19:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=qy6SAarL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229839AbiATKyU (ORCPT + 99 others); Thu, 20 Jan 2022 05:54:20 -0500 Received: from alexa-out.qualcomm.com ([129.46.98.28]:27014 "EHLO alexa-out.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229755AbiATKyQ (ORCPT ); Thu, 20 Jan 2022 05:54:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1642676057; x=1674212057; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=PWXf9U9ip1SlEBsO3DM5W2hgX/Z8F0qlAhGez6OXS/k=; b=qy6SAarL7xNSYLLaJe8M/HI2WnltMqZpRn+c0b0Y2yKlbqR0GEq0xPh+ K3be9VrLSOm33k74vBs6w27Y3zTl3n5EWcicWweEqiTJayRa5IQ1OjrIJ xuik23iAI8hGF4QuRrpVEW5cjIa5PRzNOq0Kyg/R2KCIAVfI2RaVRoWLY w=; Received: from ironmsg-lv-alpha.qualcomm.com ([10.47.202.13]) by alexa-out.qualcomm.com with ESMTP; 20 Jan 2022 02:54:16 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg-lv-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2022 02:54:15 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Thu, 20 Jan 2022 02:54:15 -0800 Received: from [10.216.6.136] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Thu, 20 Jan 2022 02:54:09 -0800 Message-ID: <2f208798-2ec5-4c29-1362-0de102f29718@quicinc.com> Date: Thu, 20 Jan 2022 16:24:05 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH 2/4] pinctrl: qcom: sm8150: Specify PDC map To: Bhupesh Sharma , CC: , , , , , , References: <20220119203133.467264-1-bhupesh.sharma@linaro.org> <20220119203133.467264-3-bhupesh.sharma@linaro.org> From: Maulik Shah In-Reply-To: <20220119203133.467264-3-bhupesh.sharma@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 1/20/2022 2:01 AM, Bhupesh Sharma wrote: > Specify the PDC mapping for SM8150, so that gpio interrupts are > propertly mapped to the wakeup IRQs of the PDC. s/propertly/properly > > Cc: Bjorn Andersson > Cc: Linus Walleij > Signed-off-by: Bhupesh Sharma > --- > drivers/pinctrl/qcom/pinctrl-sm8150.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/pinctrl/qcom/pinctrl-sm8150.c b/drivers/pinctrl/qcom/pinctrl-sm8150.c > index 7359bae68c69..499dd05c3e3d 100644 > --- a/drivers/pinctrl/qcom/pinctrl-sm8150.c > +++ b/drivers/pinctrl/qcom/pinctrl-sm8150.c > @@ -1500,6 +1500,25 @@ static const struct msm_pingroup sm8150_groups[] = { > [178] = SDC_QDSD_PINGROUP(sdc2_data, 0xB2000, 9, 0), > }; > > +static const struct msm_gpio_wakeirq_map sm8150_pdc_map[] = { > + { 3, 31 }, { 5, 32 }, { 8, 33 }, { 9, 34 }, { 10, 100 }, > + { 12, 104 }, { 24, 37 }, { 26, 38 }, { 27, 41 }, { 28, 42 }, > + { 30, 39 }, { 36, 43 }, { 37, 44 }, { 38, 30 }, { 39, 118 }, > + { 39, 125 }, GPIO 39 is duplicated. 39 is used with 118 PDC interrupt in downstream. so { 39, 125 } can be removed. > { 41, 47 }, { 42, 48 }, { 46, 50 }, { 47, 49 }, > + { 48, 51 }, { 49, 53 }, { 50, 52 }, { 51, 116 }, { 51, 123 }, GPIO 51 is duplicated. 51 is used with 116 PDC interrupt in downstream so { 51, 123 } can be removed > + { 53, 54 }, { 54, 55 }, { 55, 56 }, { 56, 57 }, { 58, 58 }, > + { 60, 60 }, { 61, 61 }, { 68, 62 }, { 70, 63 }, { 76, 71 }, > + { 77, 66 }, { 81, 64 }, { 83, 65 }, { 86, 67 }, { 87, 84 }, > + { 88, 117 }, { 88, 124 }, { 90, 69 }, { 91, 70 }, { 93, 75 }, > + { 95, 72 }, { 96, 73 }, { 97, 74 }, { 101, 40 }, { 103, 77 }, > + { 104, 78 }, { 108, 79 }, { 112, 80 }, { 113, 81 }, { 114, 82 }, > + { 117, 85 }, { 118, 101 }, { 119, 87 }, { 120, 88 }, { 121, 89 }, > + { 122, 90 }, { 123, 91 }, { 124, 92 }, { 125, 93 }, { 129, 94 }, > + { 132, 105 }, { 133, 83 }, { 134, 36 }, { 136, 97 }, { 142, 103 }, > + { 144, 115 }, { 144, 122 }, { 147, 102 }, { 150, 107 }, > + { 152, 108 }, { 153, 109 } > +}; > + > static const struct msm_pinctrl_soc_data sm8150_pinctrl = { > .pins = sm8150_pins, > .npins = ARRAY_SIZE(sm8150_pins), > @@ -1510,6 +1529,8 @@ static const struct msm_pinctrl_soc_data sm8150_pinctrl = { > .ngpios = 176, > .tiles = sm8150_tiles, > .ntiles = ARRAY_SIZE(sm8150_tiles), > + .wakeirq_map = sm8150_pdc_map, > + .nwakeirq_map = ARRAY_SIZE(sm8150_pdc_map), On SM8150 need to set .wakeirq_dual_edge_errata = true, similar to sc7180. Thanks, Maulik