Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1271066pxb; Fri, 21 Jan 2022 13:59:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJzW6JWEHf72tu0OM5elYe6mZ7vd4VBoU3Ysg3uK+72IOUScMf6gD/l3/gPqb5aLl0qP2RCn X-Received: by 2002:a17:90b:797:: with SMTP id l23mr2628315pjz.30.1642802390036; Fri, 21 Jan 2022 13:59:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642802390; cv=none; d=google.com; s=arc-20160816; b=ePQhvTVVlHN3+2aK2yagqMis9wMzBRLPk7f1Stt1xIxfumJUQWRWO+4P37FZSXI0LE JqQKvhbfQvDP3H7kJ1vP35zx8TFhrIr07OD3hPSF+BCQyP0sb8vbFC4jqJCDwKj7sszE PR7TMGDP990hHM6E/nS7xkBZ2oMy7kvPm5JKm+qIwpj/hBBMYp8fkHI0DnuRmh/Q0ybr BaOfOUJ0UlzS3WmmuA8wVbAyJVjlI5XIe8HNwpjcv/iTKa394ruDf2gbBj92kDlLjAKz 1mo5Q8XwmYZqfvNypkj79aiVGYhMwKrykcxXFf8w1+RECdDzme4mWF4yr4tQJTNhPSW0 up7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=3c+REvOXduf40ohZFQKP1DZ0gy+upNEXgXXn54qp3k4=; b=CLgII4FCMYeu1eecNPhNYtePLKTYUiuIyKTwdYwKY9J8qmns18HmuKAlddlvJD4OBu +EzEakp7XI4ytSovZDEKdX8CopoZvGbki1hlEVnKBlZqB422WG6wnUFN7VCt7u63ddDo v2Y8j+POnPo2Da9kHW6lHS2CQdFNoA1cMsDzuckM5zSo5FemLE1sQe6a9cr4tTuhdtxH An1gLMnynd/LEb2WQ//aV0OYW/Tufv4Ol2vt2azeSZO66K+Rv1EATUVOqrlc0Zy2Ikdv VWMtpmsl2DEcT8ao/fj8FrsuajV0NhSjvyzAoJw5qTTPxc0FnnLyPGk7MsRbl4hJTfpP Lz/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=AeaQ2LPg; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t2si7823730plg.360.2022.01.21.13.59.38; Fri, 21 Jan 2022 13:59:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=AeaQ2LPg; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241857AbiATMlM (ORCPT + 99 others); Thu, 20 Jan 2022 07:41:12 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:47136 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230448AbiATMlK (ORCPT ); Thu, 20 Jan 2022 07:41:10 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A8092218E5; Thu, 20 Jan 2022 12:41:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1642682469; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3c+REvOXduf40ohZFQKP1DZ0gy+upNEXgXXn54qp3k4=; b=AeaQ2LPgmeZrSs44oYV4ZXI2ZTlQVLiCw+NY1hvDhubOFReQNGVixykR2gkXK3k5E+501q O/vQ2uEZAaem3pxkNHBHCQ0J7CDedA3cR/nc4vc1nvNEPIOvgxTWUf/0Cm+ykuW4jE/yA6 g5RiLS61mvEvI0nMys+e+jrydsBSX6E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1642682469; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3c+REvOXduf40ohZFQKP1DZ0gy+upNEXgXXn54qp3k4=; b=d5LU8Ruad9lWCTeXy2igrAoSGWcMMJ/8V2+9YdSRj/EkZLxhbSFpV767hIJHi+yP5YYSBI 7Y+DYMs1guUxbgDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 976CD13E9E; Thu, 20 Jan 2022 12:41:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sQvPJGVY6WEaZQAAMHmgww (envelope-from ); Thu, 20 Jan 2022 12:41:09 +0000 Date: Thu, 20 Jan 2022 13:41:08 +0100 From: Daniel Wagner To: Hannes Reinecke Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jens Axboe Subject: Re: [PATCH 2/2] block: hold queue lock while iterating in diskstats_show Message-ID: <20220120124108.vux7fa6noipzr32r@carbon.lan> References: <20220120105248.117025-1-dwagner@suse.de> <20220120105248.117025-3-dwagner@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 20, 2022 at 12:18:24PM +0100, Hannes Reinecke wrote: > On 1/20/22 11:52 AM, Daniel Wagner wrote: > While this looks good, it seems to have been cut against an earlier > branch; the code in question looks different in my copy. This was cut against linux-block/for-next. Let me know which tree/branch I should use.