Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1281178pxb; Fri, 21 Jan 2022 14:14:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJyZ12dYIMQdwJBVFsiHT2IYkjJkVoCxn2yWJwylunn0WQu62KNb1ZNmJFDOxcd11jy/X6T+ X-Received: by 2002:a17:90b:4f44:: with SMTP id pj4mr2633847pjb.245.1642803281897; Fri, 21 Jan 2022 14:14:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642803281; cv=none; d=google.com; s=arc-20160816; b=iCjh1Cy+WQEgP3cgzCQowuNS5W0ug3iQ6u9dMhR71KWDC2DVH5cOggdlfB89oC2qce 95ojZmG3fQ0mGOBThhzHodj91yc/kIueEEREvdnTIlbAjNGNL+Wdu/L3WqjUZzdOdp6y +93BnsIQAEW2IdCZnPqE8QMcvYHuy9k3IDMMmEemKbqCm5KIJ0sJf2MN6MLr9Ge0DaDk cN65xAwgsr14krW7U8IiyEFXKLIshSO6AgEy1aTswtgQqkn+9K0JxczoMwseS/fbf4Dp JDV1tpHvV8rlBwsDUXz4YSmJX9eiDPyh1ES5DIeRYAEq5wipnSKSZd/rr8cowP+i2VQa Ikpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=To8BttLxoJklAEKbWFTWQDtm67ehUjdSCEtQCd+K09E=; b=qM7EBQPSTApL0e+oOARAa5lF7mKoB/drfLlVB28IEXxHjaLYXQsUHnjlFDoaxyeGKm sizviUXeoQIl43ROpM1Gafn9Z06Ggmbmo2o6lqUktRZVqAzaxM/U3eqUQeDC5VVCQTW8 gJP8b8/wCEQpKBE7xSEdItdC9BJ4LlJEshxl/WWG1GweAtBlqhnZDrqPKsvFGHNbZV3g Ibc7pCVJmom6xgKA0qrvsCfliZJNS7p862lB7wpjI7elXxJBLLidMbKx94rmKnq7G/6Q k0IaHzwNy0boL5Ris0ipHasBuS8Z8rG7GjgZk0lSMNq3V2EH6pUh+xchGo+molY7EwvN RT7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=x0Y2RJTm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k9si8761669pfu.226.2022.01.21.14.14.28; Fri, 21 Jan 2022 14:14:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=x0Y2RJTm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345723AbiATOVd (ORCPT + 99 others); Thu, 20 Jan 2022 09:21:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234745AbiATOVb (ORCPT ); Thu, 20 Jan 2022 09:21:31 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14460C061574; Thu, 20 Jan 2022 06:21:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=To8BttLxoJklAEKbWFTWQDtm67ehUjdSCEtQCd+K09E=; b=x0Y2RJTm8w8ZVWJWj09a6R4OQD +ub/tV/zUe8Un+t8m95v196Hs9r8JsWtEHggbt0yXDvk4uYeH7/wCBdbsvSVBL77H95MolCRmsrOb PflsuDByorsmqro07tdlWkzWSUC00tbaiM/vglV/Hbr2jteilahbJ8IttLJSLHunNYxfjLpxfdWGu Hzavcu4Bs+q1Cjc5wDkPyFeAG/Og1j2G7JRc2b9ovyycl4EJtJjP20AfNsVd9yj9Vf3Q4ji5nw5Pn ZfpXuyA1qmBlfbosr1NdqRS3iasKZWP3OiOCg3YkjsCCvlTQ8tCXSwGJHIWmRy765o7f+6Q5jL599 S6ha5Idw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAYJa-00BsNF-QB; Thu, 20 Jan 2022 14:21:26 +0000 Date: Thu, 20 Jan 2022 06:21:26 -0800 From: Christoph Hellwig To: Daniel Wagner Cc: Ming Lei , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jens Axboe , Hannes Reinecke Subject: Re: [PATCH 2/2] block: hold queue lock while iterating in diskstats_show Message-ID: References: <20220120105248.117025-1-dwagner@suse.de> <20220120105248.117025-3-dwagner@suse.de> <20220120131936.mlug7nhnoe73abx5@carbon.lan> <20220120140126.ntzvrcmczd7pph75@carbon.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220120140126.ntzvrcmczd7pph75@carbon.lan> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 20, 2022 at 03:01:26PM +0100, Daniel Wagner wrote: > On Thu, Jan 20, 2022 at 09:51:18PM +0800, Ming Lei wrote: > > Then Can you figure out where blk_mq_queue_tag_busy_iter+0x1e4 points to > > in source code? And what is NULL pointer? > > Here we go: > > /usr/src/debug/kernel-default-5.3.18-59.27.1.x86_64/linux-5.3/linux-obj/../include/linux/sbitmap.h: 249 That looks quite old. How does this look on mainline?