Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <f2836ee9-6261-a86a-b821-c9e3f75b9273@oracle.com>
Date:   Thu, 20 Jan 2022 14:32:50 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 4/9] KVM: SVM: Explicitly require DECODEASSISTS to enable
 SEV support
Content-Language: en-GB
To:     Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>
Cc:     Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Brijesh Singh <brijesh.singh@amd.com>,
        Liam Merwick <liam.merwick@oracle.com>
References: <20220120010719.711476-1-seanjc@google.com>
 <20220120010719.711476-5-seanjc@google.com>
From:   Liam Merwick <liam.merwick@oracle.com>
In-Reply-To: <20220120010719.711476-5-seanjc@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnhjWWd0Yk5rckk0Uk1GdGF4TzZpTzZ3b3BISWQzclpGcDFYV1RZZjRnWTN6?=
 =?utf-8?B?Q2pVc3A0clFmZEFCVkVrUzROWlFUR0ZFb1pBWGd2ME5TRXMyclduYm1GVnIv?=
 =?utf-8?B?UXBVV0FJRGhVbWdnd0wycVo0aStKVGg0OWpvSjJxTFhRQW1WakpYRDNNWC8z?=
 =?utf-8?B?VWY0RXVWeE1xSC9KSlpOZld5N1hHa2xGVDJVWVp4YWRXVHNBM0hEM1BkVXg2?=
 =?utf-8?B?WmswY1c2K25hcDIxTUtITksxWDJOZFlyd2JjRnc1Snh5ajJaajRyaTJ1Q3lj?=
 =?utf-8?B?TkdOQzBjdHp0SEpiZ2U0anRXaDl1UHlmNUFGc3dmNXczOXY3cU5iMmcrQTFo?=
 =?utf-8?B?djFFcEtEVUhkczNaTUw2TlZ1SVRzYndVRnVMRzBFQW5nM09MbkpwRFBHTUU5?=
 =?utf-8?B?bkxERWN0V3hTTVMva1ZheEJzZnlvVG1pOVNQWmtiSXJLelBraHV3dXppaVNZ?=
 =?utf-8?B?Y3NsRUIwQjNFb3psVy9mSG9IZForblBCcUJXMnZLWnMvV3k5VmZQRDQ1bTFS?=
 =?utf-8?B?QSt0a1lYZ1h4Zmt1bG8yeGVWN2RLK21SZmdrTzdveStHN0hLMEZJY2c2U2hX?=
 =?utf-8?B?YjJaOGdzeCtweU0rTkJvU1dmd05MdkNGczRXSnZ4eEh4WFIySm9FTEY0Y0dp?=
 =?utf-8?B?TzB4Vk10UVZXMEd4bGN0NVdqSFFneGNDVEZ2QkVJa1RNcFNFNUFEdlpnWVpr?=
 =?utf-8?B?ZXFHaE9Jc09qeVdXVzkvQ0hzbHRaOS9BcHpHSVBDMzBjVUZQN1FZY2hoWG5W?=
 =?utf-8?B?R2JEckZ5OVVibnhTY0liZ3F0QVdKcllIcUl3LzN3MjZqR1FOZE9PNVpsRkdr?=
 =?utf-8?B?cm1ZNWlWRHFDcnJMWExBRkJRRUc4MTE4WUlkeDFUWUNDOWNGWTQ5cDdVRk4w?=
 =?utf-8?B?dWtnelcyR2FSMFcyclZTV1gyL3dXRWhsZ3NyNW4zMUREdGEzRERXMzlYR21E?=
 =?utf-8?B?dTJkQThueEMvR0xEV01JVGtlQ0dCVmE4bVpsOW1kN1VObTA3ZmRrd2U4VXBu?=
 =?utf-8?B?SWhmTURkaXdjc2gvZHJMVmJ0bEpmbEJoNUxZdmR6bHZmNHAzaFRnQjI0YXVh?=
 =?utf-8?B?Qkw3SjJMQTZ5TkFjRUhqM1oyaHFQU2FCcDR3NG01Mjg2UkU5ekdBR0NHUDQ5?=
 =?utf-8?B?ZjNvLzNwQ1U5WWxieGdQaVJ3RW9wNHRkNlNDTmJMQ3dWNXI0enl5NWlJcUd5?=
 =?utf-8?B?VURick51WDY1NzBlSEdyTWVrbjc5L3dFZXgzY3lpZEltRWJLd1VLNytQZVQ2?=
 =?utf-8?B?L0xlTDFFU09KTlE5N1luWWs1NG5zSnZOZHo0ZVM2aE02MVc0NklMaGIraEhU?=
 =?utf-8?B?RzVidUZRQmVYc0YyQ0pXdm5HR2NsWnpmdzVnRzVRWTJuT1Z3NUpGT1VXNkt1?=
 =?utf-8?B?MHFteFd5cU9rNFVqSWx1RjhvK3dGL0pEZU9wYTlhQXhNbjhWbVM3RERoM0dJ?=
 =?utf-8?B?Q0dkRUh2WWpOVFNxY25JcStkNHV5OWl5Z0pYVk5QZ3NEekNrMUhTWHFMVGNQ?=
 =?utf-8?B?Y0k2SWo0Y050MFJwdXMxRnFVVm1UdXJCTTl4ejVwMzgvaEFOUWE0N3AxaFE5?=
 =?utf-8?B?dUYwSjFsakplTk1YTzh6clZLTmRDUXdxWmk3S3ZqaGoyd1Y2U3E1RWlGaFlP?=
 =?utf-8?B?enpIaTFDVnZPWCtaYWlWcjdxM01nRzlWZ0J0TVlGYllZRkxqWERCTzMzZyt2?=
 =?utf-8?B?SWdnMDhnQmNCZytNTWJNUHRKY2VvT3VIdVN4MXJRQ3N0Q1BFR3JPYlFxaDU3?=
 =?utf-8?B?ZHZXaUpZUml6bXptQXFtRXozUW5ZUEF4WVQwNmt0bXozdzFOMlhCY05aam0v?=
 =?utf-8?B?YmpvOVRIemN4YlRvWlFIZjdQSURNeGgxaC91KzBYeGhIUkVCTTMxZjE1V0JH?=
 =?utf-8?B?d2lJbms0ZDI0MmZsR2VQc0xWRUxLWjdhc2tkMHVOWlJkME8rR0ZaTGMwaDEx?=
 =?utf-8?B?cTE0emREclhPL1UxQmNEcytTdEhpWXBLaUhLVFhmc2h1Z2RCTVpBbmhmRXNZ?=
 =?utf-8?B?bkZYYUFWMURuOWpHd2JGeUdVT3daaUVJOU91UVZEaWFSbUVTNEF0Y0dXdW9y?=
 =?utf-8?B?UCtwQldTSkoyaWo1T2ZSeTRrYkpRL21ZTUc3YmFoK1NRcnVLdnVEcXdqTllB?=
 =?utf-8?B?b2psRklWYnp1ajUwTlhqcjVTMHJXS01ONS9rck55cXQ0cndRRlpTZkROdVlP?=
 =?utf-8?Q?dgI54OmxQ6eMv83NFnFrY4o=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 90387c7e-2373-4583-f890-08d9dc21c0fb
X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5038.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2022 14:32:58.1749
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AkMu0tdbizMQ1ROWtHoNKODtapaB6Ot6RTokQD3lJEqqMtNlKOHXYOlKNJiyqWmomYc3XNHynkpFguqC79y45w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3288
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10232 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 malwarescore=0
 mlxlogscore=999 bulkscore=0 adultscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201200076
X-Proofpoint-GUID: oN8iLpJQPa6IRB_KVczr8BeRqbaTZ17z
X-Proofpoint-ORIG-GUID: oN8iLpJQPa6IRB_KVczr8BeRqbaTZ17z
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20/01/2022 01:07, Sean Christopherson wrote:
> Add a sanity check on DECODEASSIST being support if SEV is supported, as

"DECODEASSISTS being supported" or "DECODEASSISTS support"

> KVM cannot read guest private memory and thus relies on the CPU to
> provide the instruction byte stream on #NPF for emulation.  The intent of
> the check is to document the dependency, it should never fail in practice
> as producing hardware that supports SEV but not DECODEASSISTS would be
> non-sensical.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>

Reviewed-by: Liam Merwick <liam.merwick@oracle.com>


> ---
>   arch/x86/kvm/svm/sev.c | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
> index 6a22798eaaee..17b53457d866 100644
> --- a/arch/x86/kvm/svm/sev.c
> +++ b/arch/x86/kvm/svm/sev.c
> @@ -2100,8 +2100,13 @@ void __init sev_hardware_setup(void)
>   	if (!sev_enabled || !npt_enabled)
>   		goto out;
>   
> -	/* Does the CPU support SEV? */
> -	if (!boot_cpu_has(X86_FEATURE_SEV))
> +	/*
> +	 * SEV must obviously be supported in hardware.  Sanity check that the
> +	 * CPU supports decode assists, which is mandatory for SEV guests to
> +	 * support instruction emulation.
> +	 */
> +	if (!boot_cpu_has(X86_FEATURE_SEV) ||
> +	    WARN_ON_ONCE(!boot_cpu_has(X86_FEATURE_DECODEASSISTS)))
>   		goto out;
>   
>   	/* Retrieve SEV CPUID information */