Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1282715pxb; Fri, 21 Jan 2022 14:17:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJzq4sLscolGoFslLJNL9PCnlev8/OrfDZ5a7vze9weA5+QNbPaBoYncUDKLkmx81zHrDhuB X-Received: by 2002:a05:6a00:114f:b0:4c5:72f6:d0b5 with SMTP id b15-20020a056a00114f00b004c572f6d0b5mr5220397pfm.61.1642803428821; Fri, 21 Jan 2022 14:17:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642803428; cv=none; d=google.com; s=arc-20160816; b=TJ9iUshuB4wJzgmOWcvH4opwHs8EqXrRfXM2KrikmAvhCxQG5+sm74T/71dV58hrrE 2ngtBWxEw9ir1egHp2Fg+YH0jQd43kXdEPYZdeHNDi/zw0aAr7mo7yMg0ytFtHt4yK5k RttX5qQngFZtFZ4oB5y2QYvg3VgFoU4rM1MRR7nDiAK/glH+kdQFZoW1L9ZjAe4lTagN I5QSmWKL2DnBTNS0uReG/c1b1cloHpSucVE94HvGXus5AX/Ie3J9ZEpp+JgJKDYmVZCs k1oxLKJ539q0UTWhWL+fPwM5BDm3Q9mMfoud99Xmu5Wk28cThgSP9VpGbuPdAA8VlRIj jfFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=A7QZvgfmovRXKCVwJRDvreahMT4oFNvJVL9csHd2AmY=; b=M+OEKWrXb8lZXULFHYwmwuAHwMwj/GZ3KjNyiYpiK7MV+r8P2zWHwSGNQsxBx8g5p5 6MJqatBwHEbpQHL8dQPeUrt9MtHddayvXWQcmYJTpQQI7CX6Ye/YzFIxoJ0GeUUkcrof 8Uz0wkjmXVk/j6kvSzuOEtzwIveLkahoumFtDOHBRXWtnbUISdc5PBm2DUFVwbIaTe+w F3Pbhxb5DO9Uf9XbcSIvPmkwzjKy6O9Pr96JH0XPPSvP3sdoDh03q1ga3mr4ukuamlHp bCQuLQv9rzJ7EFqqr+UtlD0Hwztz4vBF6kjfMz92NWY97eQuKsXUh9pG5a8n1WmD5Pyg 8YrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=V61k07tM; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=fDFrOTtM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n6si7058998plk.619.2022.01.21.14.16.56; Fri, 21 Jan 2022 14:17:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=V61k07tM; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=fDFrOTtM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349938AbiATOeG (ORCPT + 99 others); Thu, 20 Jan 2022 09:34:06 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:52356 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348319AbiATOeE (ORCPT ); Thu, 20 Jan 2022 09:34:04 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8A2FB1F388; Thu, 20 Jan 2022 14:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1642689243; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A7QZvgfmovRXKCVwJRDvreahMT4oFNvJVL9csHd2AmY=; b=V61k07tM9+FfVRRxeLwcpgxq7q5C/ItrveiK0teqVaCHwh24yhfRi7q01ZsV4+JfQ+or5E prD3GLjbAEqGOLyAScN2OBWplgSKAho2wBH+Neh3t71bG/9wgg4ugp46YsBKVAtCYalCTj b0ZeArRIH++QxVZteICY/6Ki6Y6RPuU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1642689243; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A7QZvgfmovRXKCVwJRDvreahMT4oFNvJVL9csHd2AmY=; b=fDFrOTtM7hKmoHdem1Tor3swgWS3vn+sqcH8p8RxTKcBn9Hmq2j9jsu+dx2dmX381D6TBq kPOGwAGUow3xz8AA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6718C13BC6; Thu, 20 Jan 2022 14:34:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id M7gkGdty6WGjIAAAMHmgww (envelope-from ); Thu, 20 Jan 2022 14:34:03 +0000 Date: Thu, 20 Jan 2022 15:34:02 +0100 From: Daniel Wagner To: Christoph Hellwig Cc: Ming Lei , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jens Axboe , Hannes Reinecke Subject: Re: [PATCH 2/2] block: hold queue lock while iterating in diskstats_show Message-ID: <20220120143402.ihjacsucn3t7o3pi@carbon.lan> References: <20220120105248.117025-1-dwagner@suse.de> <20220120105248.117025-3-dwagner@suse.de> <20220120131936.mlug7nhnoe73abx5@carbon.lan> <20220120140126.ntzvrcmczd7pph75@carbon.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 20, 2022 at 06:21:26AM -0800, Christoph Hellwig wrote: > That looks quite old. How does this look on mainline? I am still try to reproduce it locally (on our SUSE kernels and mainline). So far 'no luck' using nvme-fc. I'll try now with nvme-tcp maybe it's transport thing.