Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1285506pxb; Fri, 21 Jan 2022 14:22:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJwobeL4T6itfPgE/Dk3VfKnitFqGIforFxwTFCncr/Qad8ZccMiKJmB8tAAHv3V5EzbLRQU X-Received: by 2002:a05:6a02:18a:: with SMTP id bj10mr836473pgb.132.1642803722709; Fri, 21 Jan 2022 14:22:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642803722; cv=none; d=google.com; s=arc-20160816; b=SvF5VHbagPmpGrjzStOl7tiZACPKNfeK0CYshEPPoXvswt6jM/XkVs5VdpDAQxLO3v GUSdMtwPR5bDpXmqrIqN5xvuf2uJMa7fGC4LiDmU7y+AynEk8MnG9y9/nlAjTegVRYvm p2N3iZuYhH/vBH+yCc4a8tF3g9Nq2gzg2YADr7v3RYThes45LP1SKyBlDp/2MsT1+T5V dssPJKwPPYJlq3LpwGbPy0o38VgK0DCFcjONq/pBAa6g4nuAPu7Lsjm6gEgZUKnzgEj/ oxDzbLn68fLujoGGRI+LnS6YzluGdSUmeY0P5EWQ8bPKap0nRMusCvQXbzRw39G5RB0T l5Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=+LkrWWlY/+N71bE6y5wLkGtS9lGgFsYTimakbpd7tEg=; b=e9WcpxVdAbsPGpYxLiagHW0kTvu+s/Wa3soTTc5jSq5jIg6XVyXDyTHlWCxpFKyWD2 78cS6ZzVLnklITKPs2tt8gNt1bEza7MKQ3KHaut3GTs/iSZ/a3fN0j7olksdtTH9X93h K+pE6RGwr5iqr5GM2AoxZrU8LeryLYIel0nugnwoCxdI8hHRREgox0Mz/7Ov1NQe1zG8 znpeWsvS/fyOIrDZj+LYrpPHmH3CZVJ8dcoHWBQv/LzfjzoZ8H/BFRGjxeMIdggJBM/D wl6eRnKE3FJL5FpmOMcxW8Wp3VaJSxMwIeONl7fA6N9q77EDEk+IXtbGQKGxnTXlhusn S9wg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n8si8015573plh.598.2022.01.21.14.21.50; Fri, 21 Jan 2022 14:22:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346939AbiATPoV (ORCPT + 99 others); Thu, 20 Jan 2022 10:44:21 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:35101 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1376771AbiATPoU (ORCPT ); Thu, 20 Jan 2022 10:44:20 -0500 Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net [108.7.220.252]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 20KFiBdj027858 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Jan 2022 10:44:12 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 545C115C41B6; Thu, 20 Jan 2022 10:44:11 -0500 (EST) From: "Theodore Ts'o" To: adilger.kernel@dilger.ca, Xin Yin , harshadshirwadkar@gmail.com Cc: "Theodore Ts'o" , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] fix blocks allocate issue during fast commit replay Date: Thu, 20 Jan 2022 10:44:07 -0500 Message-Id: <164269344019.116615.4300998611120334540.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20220110035141.1980-1-yinxin.x@bytedance.com> References: <20220110035141.1980-1-yinxin.x@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Jan 2022 11:51:39 +0800, Xin Yin wrote: > when test fast_commit with xfstests generic/455, one failed case is > after fast commit replay, fsck raise ’multiply-claimed blocks‘ issue. > one inode's etb block may share with other file. > > fast commit replay procedure may allocate etb blocks for inodes, but > it may allocate blocks in use. This patch set fix this issue. > > [...] Applied, thanks! [1/2] ext4: prevent used blocks from being allocated during fast commit replay commit: 8484c37da00dc121c5a9a3613b17a9c0b7b760e1 [2/2] ext4: modify the logic of ext4_mb_new_blocks_simple commit: 85c6392fef63e20fa2a3e82383dc57a605d6e5df Best regards, -- Theodore Ts'o