Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 20 Jan 2022 16:38:02 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Soenke Huster <soenke.huster@eknoes.de>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver core: fix null pointer deref in device_find_child
Message-ID: <YemB2pdWSey1mA52@kroah.com>
References: <20220120150246.6216-1-soenke.huster@eknoes.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220120150246.6216-1-soenke.huster@eknoes.de>
Precedence: bulk

On Thu, Jan 20, 2022 at 04:02:46PM +0100, Soenke Huster wrote:
> Similar to device_for_each_child, device_find_child should not ooops
> if parent->p is NULL. While fuzzing the Bluetooth subsystem, I got a null
> pointer dereference in next_device, which is prevented by this change.
> 
> Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=215497
> Signed-off-by: Soenke Huster <soenke.huster@eknoes.de>
> ---
> I found this while fuzzing the bluetooth subsystem and reported this bug
> in bugzilla. As I feel more like a kernelnewbie, I am not sure whether
> this needs to be patched in driver core, or is just an issue of the
> bluetooth subsystem itself. If the latter is the case: sorry for the
> spam!

bluetooth should be fixed, this is an indication that something is using
a stale pointer and this would be the least of the problems here.

thanks,

greg k-h