Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1286033pxb; Fri, 21 Jan 2022 14:22:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJzXJ1/WaF3sk+wZCVxbDM3DTwGK4kmDLN4WHasUzw4LXDKx9niBYi+qoGd8vbZ71o2zwKck X-Received: by 2002:a17:90b:4b8a:: with SMTP id lr10mr2690924pjb.58.1642803778230; Fri, 21 Jan 2022 14:22:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642803778; cv=none; d=google.com; s=arc-20160816; b=R6+14G4JlDhucz9woMP57UBSGgqU/CbFIpNzvg1Ctxl2nb2BomJzP7HEBTbkhrZItJ DNwj5FJbPGOhf77oYuDhgTAlSRu/ToaJ+lCkAGwkvqonvJfgCpiRGgQwfl6e+Nbrui2N kQDqw2MqaZdtcX2zt1H12KaQdpPg1e8SK6O5qovpLjGzPFoG9deb9UleaWoTxW57tHlv vfZP9o6JJIMva0lxa4yS0/i+Bs6v9RA76UKJXwd5hL0S2MbTIUMYfNRUGiKE572RhZd6 WjnRZv59zAe23qV10btmAQTbHPbyL+lUqEIuVatUEpE8+LuUUMqAlQ9AnPf9Ts4Qb2I5 HaBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=u+pkfmvYVc/2T49A8upLbRF9p2AWxrkDmyYRSDiEoHA=; b=CGilWpbIUaALi99CsWCyewPun1WyonjkGQBKmYFTpvjVS7cYKxOaQz33dsFy//VpN/ Ko96aaGBCY92rc3GyNIR+Shcebz3theyoxsoHQjrVDAxF5hKVinAlqfmuLmM0p8AAmDA IdMqmhmWNzpeDwAPLXNHUvAQ0bAzX2pUJuyOv83PTYk+XNglLdk9+gqoeJ0dMEGVz7UV S5iVR942J0EeHj/Kh/7uvKsYeS1ITVLZWMmznwGOZrtsiGBnz6GNYmcwKVvDyuMYVE0j wrXntdXmxkpZHwVMCnMY82SDIfmJ4vhzN1DbhN3DKc8/kqDpmBCdlVa1oLn6F5ZTIAch 3csQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g21si7557943pfc.252.2022.01.21.14.22.43; Fri, 21 Jan 2022 14:22:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233010AbiATP6b (ORCPT + 99 others); Thu, 20 Jan 2022 10:58:31 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:37526 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S243632AbiATP6W (ORCPT ); Thu, 20 Jan 2022 10:58:22 -0500 Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net [108.7.220.252]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 20KFwDfQ001102 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Jan 2022 10:58:14 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id CF09C15C41B6; Thu, 20 Jan 2022 10:58:13 -0500 (EST) From: "Theodore Ts'o" To: linux-ext4@vger.kernel.org, Ritesh Harjani Cc: "Theodore Ts'o" , Andreas Dilger , linux-kernel@vger.kernel.org, Eric Whitney , Jan Kara , linux-fsdevel@vger.kernel.org Subject: Re: [PATCHv2 0/5] ext4/jbd2: inline_data fixes and minor cleanups Date: Thu, 20 Jan 2022 10:58:12 -0500 Message-Id: <164269428249.194735.9368808618979556408.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Jan 2022 17:41:46 +0530, Ritesh Harjani wrote: > Please find v2 of the inline_data fixes and some minor cleanups found during > code review. > > I have dropped patch-6 in v2 which was removing use of t_handle_lock (spinlock) > from within jbd2_journal_wait_updates(). Based on Jan comments, I feel we can > push that as killing of t_handle_lock into a separate series (which will be on > top of this). > > [...] Applied, thanks! [1/5] ext4: Fix error handling in ext4_restore_inline_data() commit: 2fdd85005f708691a64270ecb67d98191d668c4c [2/5] ext4: Remove redundant max inline_size check in ext4_da_write_inline_data_begin() commit: c7fc77e512a432bba754f969c4eb72b33cda3431 [3/5] ext4: Fix error handling in ext4_fc_record_modified_inode() commit: 6dcee78ea266fb736a3357c2e04d81ee7ec7b6e4 [4/5] jbd2: Cleanup unused functions declarations from jbd2.h commit: 16263b9820b0d40c778c8ee867f853d3fe638f37 [5/5] jbd2: Refactor wait logic for transaction updates into a common function commit: b0544c1f23ddeabd89480d842867ca1c6894e021 Best regards, -- Theodore Ts'o