Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <d02e3982-b34c-c529-11b5-4c788af480d2@oracle.com>
Date:   Thu, 20 Jan 2022 16:58:07 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 0/9] KVM: SVM: Fix and clean up "can emulate" mess
Content-Language: en-GB
To:     Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>
Cc:     Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Brijesh Singh <brijesh.singh@amd.com>,
        Liam Merwick <liam.merwick@oracle.com>
References: <20220120010719.711476-1-seanjc@google.com>
From:   Liam Merwick <liam.merwick@oracle.com>
In-Reply-To: <20220120010719.711476-1-seanjc@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUhWeFJhNVhHZUQvWndteWdzamdJWC9hYmd4NzNVSUlLK21NUDNLazBFWElQ?=
 =?utf-8?B?cHFjOExrbjlGTHZQTkVvbC9YNXhkclprSEJzODRPemkvUHFWQWNoMWNUY212?=
 =?utf-8?B?YkY5MW1tMVhYMzdRUjVTRVYxendoOWdTS0tZU1RJY2Z0NVRrZkNSUUJyUVRW?=
 =?utf-8?B?WGppUmQzb1BFcWVPVEF6OFBsWmdmMGN1OFBpMEFaSCs4empuZEVvb0FTdjNa?=
 =?utf-8?B?NUNYR0M2alhlMlh6ZzN3ajlLM2l3cnBWOW9ERzhPTlRrbnYvMk1WN3dndzRo?=
 =?utf-8?B?L1JPaHNJTFphVFNoZExFSkswNG5NM3pHVVJVRldLb3QwMnhjMkhBelNPcis5?=
 =?utf-8?B?dzJHYWQyLzZScU0vZG82a0pzaGpxbDZCdFRHZ0xnODIzWXBLS0lyT3d2OGNR?=
 =?utf-8?B?RXlZSndtalZQNzdPbWVlYlZiMmZaU2lpU0loQkd0bmY4VEFERTlqbzJ5L1Q1?=
 =?utf-8?B?a1U1dUpyRGhBTE5yOGhvRW5ZTHlITUlYcElRQ08zVFIwMmViVVpHYkZHUGdH?=
 =?utf-8?B?UFV1dXdBUGVwL0E2NEtma3hnT3lSYUZZS1N2dktjZkt2ZzJZL3V0OGxzM2Qy?=
 =?utf-8?B?UWxzOFJEazdPcFYwOGdqdExjSVVvYkpEdWZzWGZwazRkYzlBUzVxdHhxT2V2?=
 =?utf-8?B?eFJXa2MvdFRQc2UyYkxheUpkbmZnSTZ2RjViRWlkZndNOTdsaXFiR3YwZ0FE?=
 =?utf-8?B?YWZ6OEdtOTR1b2Njd0pLOXh4MHhieTA4WnlXMWkzOW1QNSsvUDlnb3o0ZWZC?=
 =?utf-8?B?SkhjTkJ2NytscGdObmJQdjZHdzhzS3VGdTJaZlQveFZQTGx3TTU1TUNzRzFI?=
 =?utf-8?B?UFFXOXFRSXpZckpwdHpEd0pFTWNIdWdocCtIMkZZT29IU2VFdnBjanNUZGNa?=
 =?utf-8?B?enZoYkUvVCtFT0syM0lnUzFqWEVJNmZoTXVyZVFPd25wY0lTU1N6aXNtUy8x?=
 =?utf-8?B?RHl0TnpQUVhtSlJ3TlpyRzVFWG9JR29jdXBVeERCcEdMMlZJa1hFak53RTZR?=
 =?utf-8?B?YUxEYldraWpwYnMwdkNSSEU4M2R3WkE3cVFvSjdwS2RTNDB3ZUV3enBab1Fa?=
 =?utf-8?B?MDRZWC9uMHFTNkx6enpCejIwMGh4YmZtd1g3YnNHTzRxYWs3aXhhNlhUUlBi?=
 =?utf-8?B?N1pETmd2a0dLK3FOVlJIWmlMbHF3MDF1OVQ3blVGSVVTYmx1Q2FtbS96VVUv?=
 =?utf-8?B?M2VGb2VRUlRQK3pRYW5BNktULzJCcSthZWxmczcwRmUwTU5iYmdoOTAvNGM1?=
 =?utf-8?B?dzNyQkl1Y2JFY3FpODBjekVYSmFnR0svdFVBUW1FM3NwRytFR0hkK1orQ29O?=
 =?utf-8?B?dmhHVUt6NTloRzMzZ1E1Z0lJTEVONXM3ZHFjbVNPc1Q4ZjFlTFlOUmN1alkz?=
 =?utf-8?B?dzEvQXVkaTgvbVJtSzNKRStHZ0lMd3UzOCt5dzMzRGwvSWptR1RQZnZULzgw?=
 =?utf-8?B?OGtNTFlKaHgvZnZRbjZKT2trQzJBeTN2eTlPcW5MamRmQjEyaXhNQVhhbGxK?=
 =?utf-8?B?VENTcDVoNUVhVWk3OGhJWXRhSDZyVVdRUmRQeVJDa1JmSTA2VUxNOEFxS2dY?=
 =?utf-8?B?QWppRkwxL05lTjVTcStjcFAzRVpVRHZxQXpqYmtSczh5T0I5L1MwQ3pTYXdR?=
 =?utf-8?B?VWFqTFIzaVJPT3NDNjFwTnNPdVpUZDlxL1hLT0NvenBkNmhmQmR2ME52STdC?=
 =?utf-8?B?dDB3d1JyUVkxeXVZUEJ3TjE4NjNEdGlNMEx6ZE1ON0tlMm5haHhwalFvRzU2?=
 =?utf-8?B?Q3NGSE44M3ZPZWxGcCtsQlNKMkE0akFPWWUyKzkydDJKb0RkcXhkdjdRTXZa?=
 =?utf-8?B?OXhnUXlEMDFxczVjak5NSmtxVDMxdkFkSmxtRlVuNVZnVlpSanRTM3BoN0Zi?=
 =?utf-8?B?SFhPRTBlZW1obFJaVVhXcWVHdWgvTlg1VE9Na0VTNHdFUUwwY0NvOVVKdVp6?=
 =?utf-8?B?TUxscXFKYit2bjd3a0lPY05TcXBDZlJJTTVjWUhjMFJaNW4vVFdaK2JJNksv?=
 =?utf-8?B?ZUFyTkxSL2w4WkFDMlpjNEUzdzlpb1h5MnNTbWc2U1g0d0wrRG9hZlRQeGlM?=
 =?utf-8?B?SmZscTR4NXhMZ00vcW1WV0h1K3pLQUM5dENPM0pGT0ZIUDBwUHpHS2JzdXFD?=
 =?utf-8?B?QlZCTGd4a1RITFVJcEY3NmJ1NFE3Mk1ramlPd2FMWEpaQXdwZ0VTUXhDbkNj?=
 =?utf-8?Q?/5NIfr43o2hdGN+xBWCT554=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c886bba8-fa18-42c1-a6de-08d9dc360bef
X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5038.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2022 16:58:13.8579
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jxp9KsrgwOcbwE9zcf4x8fFkEU8A9lsNuWxcP5aOISWdda8qAiW3EsU9wPmDiqsoOozDn2+90q5JCmscKaBqVQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1249
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10233 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 mlxlogscore=999 malwarescore=0 bulkscore=0 suspectscore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201200087
X-Proofpoint-GUID: 37knbwBVK8n_ruZm_SaBT3Mpf9sFsp0-
X-Proofpoint-ORIG-GUID: 37knbwBVK8n_ruZm_SaBT3Mpf9sFsp0-
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20/01/2022 01:07, Sean Christopherson wrote:
> Revert an amusing/embarassing goof reported by Liam Merwick, where KVM
> attempts to determine if RIP is backed by a valid memslot without first
> translating RIP to its associated GPA/GFN.  Fix the underlying bug that
> was "fixed" by the misguided memslots check by (a) never rejecting
> emulation for !SEV guests and (b) using the #NPF error code to determine
> if the fault happened on the code fetch or on guest page tables, which is
> effectively what the memslots check attempted to do.
> 
> Further clean up, harden, and document SVM's "can emulate" helper, and
> fix a #GP interception SEV bug found in the process of doing so.


FYI: I've applied all 9 commits to a 5.15 based branch (applied cleanly)
and the 3 stable candidates to a 5.4 based branch (applied with minor
contextual conflicts) and have been running my SEV test case (sysbench)
and kvm-unit-tests without issues for a number of hours now.

Regards,
Liam


> 
> Sean Christopherson (9):
>    KVM: SVM: Never reject emulation due to SMAP errata for !SEV guests
>    Revert "KVM: SVM: avoid infinite loop on NPF from bad address"
>    KVM: SVM: Don't intercept #GP for SEV guests
>    KVM: SVM: Explicitly require DECODEASSISTS to enable SEV support
>    KVM: x86: Pass emulation type to can_emulate_instruction()
>    KVM: SVM: WARN if KVM attempts emulation on #UD or #GP for SEV guests
>    KVM: SVM: Inject #UD on attempted emulation for SEV guest w/o insn
>      buffer
>    KVM: SVM: Don't apply SEV+SMAP workaround on code fetch or PT access
>    KVM: SVM: Don't kill SEV guest if SMAP erratum triggers in usermode
> 
>   arch/x86/include/asm/kvm_host.h |   3 +-
>   arch/x86/kvm/svm/sev.c          |   9 +-
>   arch/x86/kvm/svm/svm.c          | 162 ++++++++++++++++++++++----------
>   arch/x86/kvm/vmx/vmx.c          |   7 +-
>   arch/x86/kvm/x86.c              |  11 ++-
>   virt/kvm/kvm_main.c             |   1 -
>   6 files changed, 135 insertions(+), 58 deletions(-)
> 
> 
> base-commit: edb9e50dbe18394d0fc9d0494f5b6046fc912d33