Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <cb82c739-b496-670a-13dd-0f1a37c085f8@gmx.de>
Date:   Thu, 20 Jan 2022 18:27:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH] parisc: pdc_stable: Fix memory leak in
 pdcs_register_pathentries
Content-Language: en-US
To:     Miaoqian Lin <linmq006@gmail.com>,
        "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
        Greg Kroah-Hartman <gregkh@suse.de>,
        linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220120121812.14943-1-linmq006@gmail.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220120121812.14943-1-linmq006@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 1/20/22 13:18, Miaoqian Lin wrote:
> kobject_init_and_add() takes reference even when it fails.
> According to the doc of kobject_init_and_add()=EF=BC=9A
>
>    If this function returns an error, kobject_put() must be called to
>    properly clean up the memory associated with the object.
>
> Fix memory leak by calling kobject_put().
>
> Fixes: 73f368cf679b ("Kobject: change drivers/parisc/pdc_stable.c to use=
 kobject_init_and_add")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

applied.
Thanks!
Helge


> ---
>  drivers/parisc/pdc_stable.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/parisc/pdc_stable.c b/drivers/parisc/pdc_stable.c
> index 9513c39719d1..d9e51036a4fa 100644
> --- a/drivers/parisc/pdc_stable.c
> +++ b/drivers/parisc/pdc_stable.c
> @@ -980,8 +980,10 @@ pdcs_register_pathentries(void)
>  		entry->kobj.kset =3D paths_kset;
>  		err =3D kobject_init_and_add(&entry->kobj, &ktype_pdcspath, NULL,
>  					   "%s", entry->name);
> -		if (err)
> +		if (err) {
> +			kobject_put(&entry->kobj);
>  			return err;
> +		}
>
>  		/* kobject is now registered */
>  		write_lock(&entry->rw_lock);
>