Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <CAGS_qxoMRsvx8HDex9Aq9KUALAQrdNe3VVYikyzT59TEYfbLdg@mail.gmail.com>
References: <20220120052303.2098394-1-sboyd@kernel.org> <CAGS_qxoMRsvx8HDex9Aq9KUALAQrdNe3VVYikyzT59TEYfbLdg@mail.gmail.com>
Subject: Re: [PATCH v2] clk: gate: Add some kunit test suites
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Michael Turquette <mturquette@baylibre.com>,
        linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
        Brendan Higgins <brendanhiggins@google.com>,
        kunit-dev@googlegroups.com
To:     Daniel Latypov <dlatypov@google.com>
Date:   Thu, 20 Jan 2022 09:51:39 -0800
User-Agent: alot/0.10
Message-Id: <20220120175140.D8989C340E3@smtp.kernel.org>
Precedence: bulk

Quoting Daniel Latypov (2022-01-19 22:26:50)
>  On Wed, Jan 19, 2022 at 9:23 PM Stephen Boyd <sboyd@kernel.org> wrote:
> > +
> > +static void clk_gate_test_exit(struct kunit *test)
> > +{
> > +       struct clk_gate_test_context *ctx =3D test->priv;
> > +
> > +       clk_hw_unregister_gate(ctx->hw);
> > +       clk_hw_unregister_fixed_rate(ctx->parent);
> > +       kfree(ctx);
>=20
> I think we forgot to drop some kfree's now that we're using
> test->priv =3D ctx =3D kunit_kzalloc(test, sizeof(*ctx), GFP_KERNEL);
>=20
> This will result in duplicate kfree's.

Good catch! I forgot that it was a managed allocation like that. Doesn't
help that I had to go all the way to the kunit_kmalloc_array()
kernel-doc to read that test managed means it is freed when the test is
done.

> > +
> > +static void clk_gate_test_is_enabled(struct kunit *test)
> > +{
> > +       struct clk_hw *hw;
> > +       struct clk_gate_test_context *ctx;
> > +
> > +       ctx =3D clk_gate_test_alloc_ctx(test);
> > +       ctx->fake_reg =3D BIT(7);
> > +       hw =3D clk_hw_register_gate(NULL, "test_gate", NULL, 0, ctx->fa=
ke_mem, 7,
> > +                                 0, NULL);
> > +       KUNIT_ASSERT_NOT_ERR_OR_NULL(test, hw);
> > +       KUNIT_ASSERT_TRUE(test, clk_hw_is_enabled(hw));
> > +
> > +       clk_hw_unregister_gate(hw);
> > +       kfree(ctx);
>=20
> ditto
>=20
>=20

Thanks! Next time can you trim your mails? It's quite long and I have to
scroll down to find everything.