Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\))
Subject: Re: [PATCH] mm: reuse the unshared swapcache page in do_wp_page
From:   Nadav Amit <nadav.amit@gmail.com>
In-Reply-To: <747ff31c-6c9e-df6c-f14d-c43aa1c77b4a@redhat.com>
Date:   Thu, 20 Jan 2022 09:48:52 -0800
Cc:     "zhangliang (AG)" <zhangliang5@huawei.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux-MM <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        wangzhigang17@huawei.com, Matthew Wilcox <willy@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <C8734D0B-B855-4323-A7DF-2D96245951B2@gmail.com>
References: <20220113140318.11117-1-zhangliang5@huawei.com>
 <YeA5oP/iaxtVPHb3@casper.infradead.org>
 <CAHk-=wjB0i-B=U-DhpAajQx3f6bp1X==neLOrg0jwq29mgz=3g@mail.gmail.com>
 <172ccfbb-7e24-db21-7d84-8c8d8c3805fd@redhat.com>
 <a93988da-80fb-dd32-4717-a6a0bae9e4ee@huawei.com>
 <dc415c4a-63aa-19b0-0fbc-795989970f6d@redhat.com>
 <fb02087a-b102-c91e-ab65-fb02cc8ee0a2@huawei.com>
 <9cd7eee2-91fd-ddb8-e47d-e8585e5baa05@redhat.com>
 <b6df4f7f-c080-ad6c-d1ad-098115f016f3@huawei.com>
 <747ff31c-6c9e-df6c-f14d-c43aa1c77b4a@redhat.com>
To:     David Hildenbrand <david@redhat.com>
Precedence: bulk


> On Jan 20, 2022, at 6:15 AM, David Hildenbrand <david@redhat.com> =
wrote:
>=20
> On 17.01.22 14:31, zhangliang (AG) wrote:
>> Sure, I will do that :)
>=20
> I'm polishing up / testing the patches and might send something out =
for discussion shortly.
> Just a note that on my branch was a version with a wrong condition =
that should have been fixed now.
>=20

Sorry for being late for the discussion.

David, does any of it regards the lru_cache_add() reference issue that I
mentioned? [1]

Seems to me that any solution should also regard this problem, or am I
missing something?

Thanks,
Nadav

[1] =
https://lore.kernel.org/linux-mm/0480D692-D9B2-429A-9A88-9BBA1331AC3A@gmai=
l.com/=