Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 20 Jan 2022 10:17:24 -0800 (PST)
Subject:     Re: [PATCH] riscv: canaan: remove useless select of non-existing config SYSCON
In-Reply-To: <20211229192458.25138-1-lukas.bulwahn@gmail.com>
CC:     damien.lemoal@wdc.com, Paul Walmsley <paul.walmsley@sifive.com>,
        aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
        lukas.bulwahn@gmail.com
From:   Palmer Dabbelt <palmer@dabbelt.com>
To:     lukas.bulwahn@gmail.com
Message-ID: <mhng-d060c520-cef0-454b-b6b6-0c75282bf8e0@palmer-ri-x1c9>
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 29 Dec 2021 11:24:58 PST (-0800), lukas.bulwahn@gmail.com wrote:
> The config SYSCON never existed in the kernel repository; so, the select of
> that config in ./drivers/soc/canaan/Kconfig has no effect.
>
> Presumably, this was just some mistake, assuming some symmetry in handling
> and naming of configs that simply does not exist.
>
> Remove this useless select of a non-existing config.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
>  drivers/soc/canaan/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig
> index 853096b7e84c..2527cf5757ec 100644
> --- a/drivers/soc/canaan/Kconfig
> +++ b/drivers/soc/canaan/Kconfig
> @@ -5,7 +5,6 @@ config SOC_K210_SYSCTL
>  	depends on RISCV && SOC_CANAAN && OF
>  	default SOC_CANAAN
>          select PM
> -        select SYSCON
>          select MFD_SYSCON
>  	help
>  	  Canaan Kendryte K210 SoC system controller driver.

Thanks, this is on for-next.