Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 20 Jan 2022 23:51:28 +0000
From:   Prashant Malani <pmalani@chromium.org>
To:     Alyssa Ross <hi@alyssa.is>
Cc:     "Mr. Chromebox" <mrchromebox@gmail.com>,
        Benson Leung <bleung@google.com>,
        Benson Leung <bleung@chromium.org>,
        linux-kernel@vger.kernel.org,
        Tim Wawrzynczak <twawrzynczak@chromium.org>
Subject: Re: Null pointer dereference in cros-ec-typec
Message-ID: <Yen1gP6XB6bRo7OW@chromium.org>
References: <CACeCKaeHAV1RLovgMt43uFtHioOeKNrqEbaPq8ZtKNiCS_tTsQ@mail.gmail.com>
 <CACeCKac0BctZae4n2CiAnpD4J-Dn+h2ROkx7CEVA9EmnobbNUw@mail.gmail.com>
 <CAFTm+6APx0PkRgp+7LLEOi=2E-7ZSgYdQ824U1XB+q1wMPNg3g@mail.gmail.com>
 <CACeCKaeAaS3QcLwvcPNYVtkKxaBViij53TBjOXvwcpKQk+NDbA@mail.gmail.com>
 <CAFTm+6BC--tNjbez_f_A_ckK7gjkbBMWHYSExxQcp9+u60Z2WQ@mail.gmail.com>
 <CACeCKaeAUy8JCO9hv7XjeQA_P_At9SN_Cuw2v=YD01gfwvGXFQ@mail.gmail.com>
 <20220119023752.ad34u6hgjpkpk4dw@eve>
 <CACeCKafA4eDNgEbACjorCHBdrLaG6YviRS+gA=Xr-XD+GVaxZw@mail.gmail.com>
 <CAFTm+6DMuxx_qiPEU4VwweZVvuFhReWTogYMychH1gXnn47xHw@mail.gmail.com>
 <20220119203243.3zh6mcb2fauczn5k@eve>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220119203243.3zh6mcb2fauczn5k@eve>
Precedence: bulk

Hey Alyssa,

On Jan 19 20:32, Alyssa Ross wrote:
> On Wed, Jan 19, 2022 at 12:44:06PM -0600, Mr. Chromebox wrote:
> > On Wed, Jan 19, 2022 at 12:24 PM Prashant Malani <pmalani@chromium.org> wrote:
> > >
> > > Thanks Alyssa,
> > >
> > > It looks like the right fix here should go in coreboot.
> > >
> > > I'll wait for a response from Matt regarding whether those EC commands
> > > are supported on the eve EC firmware image Mr.Chromebox releases.
> >
> > looking at Chrome-EC branch firmware-eve-9584.B,
> >
> > EC_CMD_GET_PD_PORT_CAPS is *not* supported
> > EC_CMD_USB_PD_PORTS is supported
> >
> > no difference in this regard between my updated EC firmware and the
> > latest stock EC firmware provided by Google for EVE
> >
> > > I have a fix but I can't test it since :
> > > - I am not sure how the Mr.Chromebox eve BIOS is compiled.
> >
> > same build system as upstream coreboot
> >
> > > - I don't have an eve.
> >
> > me neither :)
> 
> I'd be more than happy to test Coreboot patches on my eve and report
> back on anything that needs to be checked, if that helps?  I've built
> and installed it from source before.

Yes, this would be very helpful! Here is the link:
https://review.coreboot.org/c/coreboot/+/61262

Thanks a lot!

-Prashant