Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220120012553.23295-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20220120104029.wenol7qdfjl2f53n@uno.localdomain> <Yek8Vk7hyK0FvcXC@paasikivi.fi.intel.com>
In-Reply-To: <Yek8Vk7hyK0FvcXC@paasikivi.fi.intel.com>
From:   "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date:   Fri, 21 Jan 2022 00:16:02 +0000
Message-ID: <CA+V-a8ucw1q7vLNwrWT1dWfogj7kPOwb5wdY5URO+55V87O5bQ@mail.gmail.com>
Subject: Re: [PATCH v2] media: dt-bindings: media: renesas,csi2: Update
 data-lanes property
To:     Sakari Ailus <sakari.ailus@linux.intel.com>,
        Jacopo Mondi <jacopo@jmondi.org>
Cc:     Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        =?UTF-8?Q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        linux-media <linux-media@vger.kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Biju Das <biju.das.jz@bp.renesas.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Sakari and Jacopo,

On Thu, Jan 20, 2022 at 10:41 AM Sakari Ailus
<sakari.ailus@linux.intel.com> wrote:
>
> On Thu, Jan 20, 2022 at 11:40:29AM +0100, Jacopo Mondi wrote:
> > Hello Prabhakar
> >
> > On Thu, Jan 20, 2022 at 01:25:53AM +0000, Lad Prabhakar wrote:
> > > CSI-2 (CSI4LNK0) on R-Car and RZ/G2 supports 4-lane mode which is already
> > > handled by rcar-csi2.c driver. This patch updates the data-lanes property
> > > to describe the same.
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > ---
> > > Hi All,
> > >
> > > Instead of adding uniqueItems:true into SoC binding doc's I think we could
> > > add this in video-interfaces.yaml for data-lanes property. Any thoughts on this?
> > >
> >
> > As repeating items are not allowed I think it's a good idea.
>
> Could this be put into the schema instead? The same holds true for all
> devices.
>
I just came across this patch [0] which does this! Hopefully this will
get merged soon. I'll resend a v3 dropping uniqueItems from
renesas,csi2.yaml.

[0] https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20211223191615.17803-13-p.yadav@ti.com/

Cheers,
Prabhakar