Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <a34aff19-4530-7f44-c849-4b3eb2aa3d00@oracle.com>
Date:   Thu, 20 Jan 2022 20:01:57 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.0
Subject: Re: [PATCH 1/2] xen/x2apic: enable x2apic mode when supported
Content-Language: en-US
To:     Roger Pau Monne <roger.pau@citrix.com>,
        linux-kernel@vger.kernel.org
Cc:     Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org
References: <20220120152527.7524-1-roger.pau@citrix.com>
 <20220120152527.7524-2-roger.pau@citrix.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220120152527.7524-2-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzRoSlJhNWlxNU95a0V3aXJKL3BTNXRORExDRmlBbUN6VlpwMmtMaFMyaUFh?=
 =?utf-8?B?aWVjNGJhS3VsQjFUWjBBQi8yK3NKaGJicnNwZlBzejBLS2NheTJvVTlFc05L?=
 =?utf-8?B?NG0zUXF6SXJuU3FpQVEzS3I3Zi8vN0UvUzIyL1hXNmI1U0NUZGFIU3VRZnF3?=
 =?utf-8?B?MkhSdzlkaTRBbUpKOURFWk4wdnhZV1B6Z0ZxVXB6ZGpxb3BZQXNTNnYxaXdh?=
 =?utf-8?B?bmU4aFJsODFSaGJ5b3ZqWnpHWGtKUk1ZY3lrd2VRNzhaRWhwV0gwYTFUVHc5?=
 =?utf-8?B?c28wNDNYOWFOWkFJTHBUME13cHYySUxKOTh1WTRDTFQzUGZRMWJtQ29XaEFU?=
 =?utf-8?B?cXBlOWFpaE1maGJiNFVKOU5rZW5aV2xIb2FhTE90Zzkwck1KWGdDVGdMQ0xK?=
 =?utf-8?B?ZnYwOXdKS0VjVU52QnFhbTRhSzRFZUs3OVVNS0laNUprL0E1OHJqSG9mbW9P?=
 =?utf-8?B?TlVmVjNGdEVGTUpjcmUyTVFnS3IreHFuT0Y4bm9XMVpXTzJXZjNLRW1US2Zt?=
 =?utf-8?B?TWcxRWovcEhwZmFrK0RhTTNFNmhzeXNETldDeUhFczJmWUczYTJMaHdqOStj?=
 =?utf-8?B?RXZJS3JUVUJUUkxJSUJLY0xkUTlrTWJsZUU0ZThsZDVnVTFjemc1QkRXcUE0?=
 =?utf-8?B?a2hwR3AvSVNMbk04MGlWQnpLYnhkVEljc2ZUanJPRFlHYlA3YWJlaUs3YW9z?=
 =?utf-8?B?UHJVU2ROYnhRSVFSYnlySG5CRkFBNFAyaUpWeXJUTHUxY0w4dE1HeDJObGxa?=
 =?utf-8?B?emNCUVlTTmZyRlcveHI4bGtYbm96WjMrcEJyOUgwYUNhdVZmVFlKRUhxTlJB?=
 =?utf-8?B?SWV5YjZLenp1NXlZeWgxVElzUVFaay9nTjg0TVlmVHN6THI4V2M2MlJWa0dj?=
 =?utf-8?B?dmV5dGtWQUxqc1U1TlNCWnI1OC9zQ3I2bjMwNkozUVBqQi9KMWlGbVgwYU0y?=
 =?utf-8?B?ZnRvSUdIWGdRQm1qUTBaUWgrVkFrRnZQbXRNS2hXUzB6VmRib0Z6NDlaOXpn?=
 =?utf-8?B?dVBGQTJzWDRDUExMWTQxQzc2WlNDRzg2N1FyUEpoTmJTRHNsdTF4dzh3dWcz?=
 =?utf-8?B?K1VUMVI0NHZLWW4wY2FWL2pzVmpXOE83WU5CYUd3VlZvRHJseWhvd2lZYkwz?=
 =?utf-8?B?b2gxd0x3d1QyMm10VjBobkV6b29VSFVMTkRIdDJPV2pRWTkyUll6Wk0rcEFk?=
 =?utf-8?B?OUNwTXVjMHd1NnJhVWVGb1ZUTi9Ndm1GUklnRDFyWlFLdGlyUFIzRVltUHox?=
 =?utf-8?B?Ym40VkdnYUpiNVIrMXh3VDZubjV2SlJKVXhGb3pQV2JhaHh1WW5PaG1EU3hM?=
 =?utf-8?B?T0VoS2prOUhWMGV6RUhORXVXbXBXak14SFVoUjVhZ25GR3JtVjdHVTIyVkl3?=
 =?utf-8?B?cVppWlhFL1hOM1NCTmo2SjgyZW45YmxyMERMaFhLSTRLSER5M29XRGNmeGtT?=
 =?utf-8?B?bDk3aks5NU1OQ2IyK09tNjF0VktvVEpURVRTWkxxZXI2VFZuYmtBUFlIeGU2?=
 =?utf-8?B?TnhUWm40cXMyWjd1WDlBZS92V0lSSUJ2aWdMVnQ1dzAydTA3MXdVTFEzRzFs?=
 =?utf-8?B?a2pGRW1zMTFlL3dWcWxDYThydEc5YkZCbUFZeGlWeldMREtoelBFWU9Fdk9K?=
 =?utf-8?B?MzRDWDFLODJ5NVYvWGY1SkMrSHI1RE40MlZwVWhiWjRuby9uMG8va2RLSHFT?=
 =?utf-8?B?Z1JHM0tXVG1FWCtiOUxUbFJvbXN3UWZPZWFhU0Frb1ZvRDQreHBSVVh2dVJR?=
 =?utf-8?B?WndCSC81WFQ4Mjk3S0NJYTgzZFd3S2ZDRjdiVDgxd2F0c0JSQk55d0pxM08x?=
 =?utf-8?B?SGpIclhhM1BhSXBQUXZQaWF4V3czVlU4UTltaDhiQk1RVHhGdmU3dE9KbzNw?=
 =?utf-8?B?Z0NiMk9WUDBpNllrc3J0a2JXSkdBdWV4OXJhUlZIeWJOOHphVzdkWEI5L2dZ?=
 =?utf-8?B?VHpjdkNLbGU3ZS95a2NvSlJESTI3Q1Uyajk3cHVJc0t6dm1nS2NoQnJMYmxT?=
 =?utf-8?B?cDUwbWduWHlTV282T1VJRTlkenRsZnZlbU1TOEJuczFSSStyWDlQUVloOU1a?=
 =?utf-8?B?UlB0UGEvL29hV1J3VHlQVHRGZnJONzNyVmtuNnNMN1NmZlhFK0RySzNRcTVQ?=
 =?utf-8?B?Tyt2SGVPRVNzM0hyZGV1bzNtMTBEc1B1dmoraFI2NjAzcnhKaEJhL3dWY3dZ?=
 =?utf-8?B?bWEzNnFabmZBYU81N1VjZVZNSUZSbzJDV29KMkYwT3N6a09wU2VaTnhSZlV4?=
 =?utf-8?B?RVZrRm1QeFBCOTBuNWdHVURoN2FRPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c388b255-6a9e-4bcd-542a-08d9dc79a338
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2022 01:02:03.8104
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zuIda0lIDMSmVkvJykZpqkz5HHg/S/7LWajs/5QGFXSN/SvLilDTegyQEihWHtlhVT/tlOTbbh02syRzhtNMnQJISzcA6822562bUOfDANo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3955
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10233 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxlogscore=999
 malwarescore=0 adultscore=0 suspectscore=0 mlxscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2201210005
X-Proofpoint-GUID: WmDM26DaljLu4PaiTRlQoC7Al4i5fFyp
X-Proofpoint-ORIG-GUID: WmDM26DaljLu4PaiTRlQoC7Al4i5fFyp
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/20/22 10:25 AM, Roger Pau Monne wrote:
> There's no point in disabling x2APIC mode when running as a Xen HVM
> guest, just enable it when available.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: x86@kernel.org
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: xen-devel@lists.xenproject.org
> ---
>   arch/x86/xen/enlighten_hvm.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c
> index 42300941ec29..ab8171cbee23 100644
> --- a/arch/x86/xen/enlighten_hvm.c
> +++ b/arch/x86/xen/enlighten_hvm.c
> @@ -9,6 +9,7 @@
>   #include <xen/events.h>
>   #include <xen/interface/memory.h>
>   
> +#include <asm/apic.h>
>   #include <asm/cpu.h>
>   #include <asm/smp.h>
>   #include <asm/io_apic.h>
> @@ -248,7 +249,7 @@ bool __init xen_hvm_need_lapic(void)
>   		return false;
>   	if (!xen_hvm_domain())
>   		return false;
> -	if (xen_feature(XENFEAT_hvm_pirqs) && xen_have_vector_callback)
> +	if (!x2apic_supported())
>   		return false;
>   	return true;
>   }


Then it seems this whole routine can be reduced to just

	return x2apic_supported();

and then dropped altogether and x2apic_supported() moved to xen_x2apic_para_available(). Domain type checks here are not really needed since this can only be called on HVM guests.


-boris