Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Peter Ziljstra <peterz@infradead.org>
CC:     bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Kernel Team <Kernel-team@fb.com>, X86 ML <x86@kernel.org>
Subject: Re: [PATCH v5 bpf-next 0/7] bpf_prog_pack allocator
Thread-Topic: [PATCH v5 bpf-next 0/7] bpf_prog_pack allocator
Thread-Index: AQHYDjHK6zwTvlFaXkKfSpJd3u7b6KxsqdyA
Date:   Fri, 21 Jan 2022 01:06:33 +0000
Message-ID: <6B6AC9AB-A09F-43E7-BF53-E0C7DEF45767@fb.com>
References: <20220120191306.1801459-1-song@kernel.org>
In-Reply-To: <20220120191306.1801459-1-song@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QYxr7+Kr3qemE3gPRAPbSwCrm96pyuO1vTEXH7ogzd4HbTqmkip0iGFY3m4P?=
 =?us-ascii?Q?v8lAFH2qk1qNsbTNTZeI6bidqtLp9AlwOF8LfA6pkq7z7i5ww3GeSnyJruq0?=
 =?us-ascii?Q?KcJhkFAfET/J3oatLQ3B7T1UqGU5wSKjYr+81SlL123i50K0PhbOGS/QaGIY?=
 =?us-ascii?Q?34cfkFxDSFMYAiCmNQAgLo8iVsVKV5uk+NHMzdTe1sVV7CDFfUt9we/lqk2w?=
 =?us-ascii?Q?mf0kDIP/k8LJMdZs45hyLlMALtKHn5+8Ap5KgOef2TQr0kJHdl2oSIrwigiO?=
 =?us-ascii?Q?F1JNhpK7hmMkHWbwDjuCaRzQgZnCOnnQjgeuFvrjWJJ8TrwyYwP/K7GuY9uQ?=
 =?us-ascii?Q?j8kQg+WCBQCQXDBKmGEEMSgMi/WR5T7CvgVHgj/zPVxBN71uFP1Kd1IFRRpf?=
 =?us-ascii?Q?CaaoqwJQrt79FsH0hemhX9mm640FWNZFn5nbiu044jh4I96YoogGVT3MK9gG?=
 =?us-ascii?Q?SJz2hSSWLe127slKnSv8XWm2uzTGGYDfBNq4rR7qJHaqdwb/WbvrkpsVXK13?=
 =?us-ascii?Q?+JFj848550YpWxdfmkWDEpw9LFHJcvXlBj8acMR21lKijd1Gg4tL4fB25tF+?=
 =?us-ascii?Q?a2AUY+X5m+N6uTjlSgSrN0t6tCeZUYcaqqnNDcNEDKpXFQ983+0rdHGwCIMW?=
 =?us-ascii?Q?Wo3LdPs/j7nvGcMlBqQBQHwGaHcwSR4H0PVs/yDVXUkMrFLE5pPiT8rCVMLI?=
 =?us-ascii?Q?IFSuLUlieqS7X7YQs/hXE9hTJI7+ItaxMsrwASOuGpbvLuRZixbcobknksCg?=
 =?us-ascii?Q?PKgRtGJ74rev9LGVKyRilRin/6yegoZ1mIpyprt9AHx0H+XOipkTTTNzLgfO?=
 =?us-ascii?Q?B36RBj6OOv8IvLviTg6vbmGjtFQLYOH1QNUDDrLXg2MmjVqd1hvD9dOTWoCy?=
 =?us-ascii?Q?PPeMECvVErmYhjLPEiSmKPHMEPzigDqW562jQL1a0LyfM/ZlbBocQQCTcZR+?=
 =?us-ascii?Q?Zef/chEDN9/saAHufLox+4LHfceo/JMMoLPTuZLcCjySJVwVQ6iIOsN+9W/i?=
 =?us-ascii?Q?77NLUChDhRafs00ywH8U+Dwm0eXZbcNA63Fsbg1McHi9GlS7xUZyCWMJv2hf?=
 =?us-ascii?Q?tU4EopDiSGxRPyE0wtBH2iTLfs0rQyJUxtZSpUwtC+/fQqyqCWlQOq8V7kyB?=
 =?us-ascii?Q?udmvwugw1oyFG00GOSVxNXgIZeSMZwhypcu5gt2Qf3cIpuefohofrTH3llrP?=
 =?us-ascii?Q?vie6Gas8yT2KmRm3OaDqW94qCMF8KpnB/BzzU9a2t+XHJCnvTMg3x9dEMYm/?=
 =?us-ascii?Q?8ZlE0y2PcZiea3afRIq1ox46IM6PZqgkMEyQuu0mYTCGoSTRyXnrwSp50L94?=
 =?us-ascii?Q?xzHPqRKnr0A9UMTA5hRGlmlyrscm1DNRXrXxW9n6KsEW/xr9P/SiYjS7JT2d?=
 =?us-ascii?Q?C4RLiIn6+MRMSmxw05rFcY0Jmw1Xj+lUT4cmzdp88XfXnYdZf6d3cm8ho04I?=
 =?us-ascii?Q?FGvamdydNSJUwj2Wh6X0mP2ffTCNPFgdp/SDdzUOjjBsPjczShLPmtHVrRe7?=
 =?us-ascii?Q?KsrBAuEawBKpXFS+ubY1G3jfNR8YxZ9glCTjo1NK9qodHt57TzPN1VHfk3bQ?=
 =?us-ascii?Q?SUNE4uBMLYaw7evLm91Mxl/HfllL3LHFSi39Lhq2BHqhMvGtN/AgVSav3v70?=
 =?us-ascii?Q?5CCucvIha2e9FBaMtFTjLT7gMPG52U9IboD1SAvOhyvh0nXxMTBeF+nRL6e4?=
 =?us-ascii?Q?rSdmdw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <EDBFACBF13F0494D8ADAB5BCE4D939A9@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR15MB5117.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 046768ea-3356-409f-d350-08d9dc7a43e5
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2022 01:06:33.1642
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qFy3Q5pcU66o3ZvR0+QAoRqZT5RkFONAS07K3IfRjI50FnOqMPtwPedQew04gUnD8tdtCSXNK1Y3JJdTSV+vJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR15MB2719
X-OriginatorOrg: fb.com
X-Proofpoint-GUID: wtCVAVJdmOWGi4fLM6pPOOPqKpiw3Rqz
X-Proofpoint-ORIG-GUID: wtCVAVJdmOWGi4fLM6pPOOPqKpiw3Rqz
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-20_10,2022-01-20_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 impostorscore=0
 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 mlxlogscore=894
 spamscore=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2201210005
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

> On Jan 20, 2022, at 11:12 AM, Song Liu <song@kernel.org> wrote:
> 
> Changes v4 => v5:
> 1. Do not use atomic64 for bpf_jit_current. (Alexei)
> 
> Changes v3 => v4:
> 1. Rename text_poke_jit() => text_poke_copy(). (Peter)
> 2. Change comment style. (Peter)
> 
> Changes v2 => v3:
> 1. Fix tailcall.
> 
> Changes v1 => v2:
> 1. Use text_poke instead of writing through linear mapping. (Peter)
> 2. Avoid making changes to non-x86_64 code.
> 
> Most BPF programs are small, but they consume a page each. For systems
> with busy traffic and many BPF programs, this could also add significant
> pressure to instruction TLB.
> 
> This set tries to solve this problem with customized allocator that pack
> multiple programs into a huge page.
> 
> Patches 1-5 prepare the work. Patch 6 contains key logic of the allocator.
> Patch 7 uses this allocator in x86_64 jit compiler.
> 
> Song Liu (7):
>  x86/Kconfig: select HAVE_ARCH_HUGE_VMALLOC with HAVE_ARCH_HUGE_VMAP
>  bpf: use bytes instead of pages for bpf_jit_[charge|uncharge]_modmem
>  bpf: use size instead of pages in bpf_binary_header
>  bpf: add a pointer of bpf_binary_header to bpf_prog
>  x86/alternative: introduce text_poke_copy
>  bpf: introduce bpf_prog_pack allocator
>  bpf, x86_64: use bpf_prog_pack allocator

Could you please share your feedback for and/or ack this set?

Thanks,
Song