Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1361296pxb;
        Fri, 21 Jan 2022 16:31:20 -0800 (PST)
X-Google-Smtp-Source: ABdhPJw486Y7rSJ/DfAjh+BpBhtWMeogechk0qOi4gfhRFpWUI60CI9kiCZ3MCsDgc+f7vy0c4Lx
X-Received: by 2002:a17:903:18b:b0:14b:2aa6:d36 with SMTP id z11-20020a170903018b00b0014b2aa60d36mr2519202plg.127.1642811480493;
        Fri, 21 Jan 2022 16:31:20 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1642811480; cv=none;
        d=google.com; s=arc-20160816;
        b=bCgRivRJxNw/9UfXqHrlLO05ziPtuycgd+5lnPOoMRKCwtb8OhEEoG6fNvQX1JKmOH
         TgmXmAuO5eO1+R7WxRWhl+2gAkyGgdpQ0LYg67QuxNFxuJbKCxPJ2p75xrlMYaETpAVe
         I6Hbnbdu4gFWK4ltZ8OA+TkPC84v/m1CDLlBe82t4RJPav+oESmDaVjkrEFYdhOsxlPV
         OCjCtaIZzUeTj57Y1qhoKzx/5BD2XGnOZWrIw6ceAUv+U/z2IyRTy0TB4xoJVdMs47em
         2u43sNQCnQ0h+s4Q448AA+UtTd6ESZCOGbUciM9O4IiGnvjALFmYeYw6NZTKbyPG0AR8
         jVUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=P3Uo00mOqHK474mLsKgzfGc/0IpMp5XxK3VnBuhQ6dI=;
        b=VFRvIbnoI9+Eje0mCN0m8X/qA68Ic7AGb9fq19IETh2HR0Su8PslV++rA0cHlSB+jf
         x8Qqzx0MEsbiC/f2Tzgu6xc974yOZPxcRS0a7YTyPgyesj5+uX3DSiIsKSiEr7BxuIr2
         X8nyXq8l3Y5dgIexX9zhBmIiEpq60lToOCuLH7uqDtw4xdUK9/ArAZc/jUZLkixLqiCM
         hE9vwmKLmUYIY05yAIOCMmqtFTEFOJHrb1+mcLuJ898Bjjb+nBI7OC66N9viw5aNSrKy
         pakccqjt/IjP5y5b6U4guwnDRHuidzKhOZM+/dQmAiJ8M43lRwOlaK32cfQByFM0hCgd
         MFZQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FUOKjZhJ;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id j13si7598453pgk.413.2022.01.21.16.31.08;
        Fri, 21 Jan 2022 16:31:20 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FUOKjZhJ;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233612AbiAUDrk (ORCPT <rfc822;stevenley.huang@gmail.com>
        + 99 others); Thu, 20 Jan 2022 22:47:40 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41620 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S232662AbiAUDrj (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 20 Jan 2022 22:47:39 -0500
Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03E31C061574;
        Thu, 20 Jan 2022 19:47:38 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id B4DEDB81EBD;
        Fri, 21 Jan 2022 03:47:36 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D172EC340E1;
        Fri, 21 Jan 2022 03:47:34 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1642736855;
        bh=YDuyQkVmbuc2qf5yPjTcF9uLN8no0wj1OEdJl9khO5o=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=FUOKjZhJNMMxQrUmpHwb1nEsx06Q87ZendqFezA1/yWcTBDIsDEKwnY84wkcPVRSb
         mO0Zvzpp5VmHU7F9xEIq+wEBdvZRYhM4FbynFjvakxsKqwePBbvxCJcX1wOmwo1hyi
         PpR5EAiBoP+wZ4ZOm/prMWoaLwSsxi2YpNEq1ErxDqFSJqbOAxn2aHvhiHzfATtGsj
         C1unOWwH+ckzWw5Fb3TA+udGZ/qwwPpc57z8oC1FM3/KBR3hmysYP98m9rsvqtUxYR
         aPXNP9aWD7EAXIaoSRtFj0KPvysJ/FNV+0Sw3yDevIvktdapWM3gDxVAzMxZYe3QpX
         w4ZRilrVRoGEA==
Date:   Thu, 20 Jan 2022 19:47:33 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     ycaibb <ycaibb@gmail.com>
Cc:     edumazet@google.com, davem@davemloft.net, yoshfuji@linux-ipv6.org,
        dsahern@kernel.org, ast@kernel.org, daniel@iogearbox.net,
        andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        bpf@vger.kernel.org
Subject: Re: [PATCH] ipv4: fix lock leaks
Message-ID: <20220120194733.6a8b13e6@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <20220121031108.4813-1-ycaibb@gmail.com>
References: <20220121031108.4813-1-ycaibb@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 21 Jan 2022 11:11:08 +0800 ycaibb wrote:
>  			if (seq_sk_match(seq, sk))
> +				spin_unlock_bh(lock);
>  				return sk;

Heh, also you're missing brackets so this is patently buggy.