Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1361990pxb;
        Fri, 21 Jan 2022 16:32:24 -0800 (PST)
X-Google-Smtp-Source: ABdhPJx2blYJUfUGdxhKC9qr4YPoUquXR3Bdmvn+szQTCpyHjZsbt0gkv4Jf7YsOxvyiWhpnscso
X-Received: by 2002:a17:90b:1bce:: with SMTP id oa14mr3023264pjb.209.1642811544009;
        Fri, 21 Jan 2022 16:32:24 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1642811544; cv=none;
        d=google.com; s=arc-20160816;
        b=EG/w43HIGffsiBvd9zXnchtzuc6pCIsVedlmI4nz/pZga9TDDyRaPRvQJKzIyMl6dF
         MQ8E6BAyLLsLiH19iTDZLnC6ykKWozq43PLREh82hVtyPV5E4RBOxPdBV6fQQJ5T7PGD
         vitvTNvnXyMuJAg04r+PyxSn1/uejAXU9IM0o34u+5rSknwNuexQN669Tx/vsNrMWsxI
         s2+AS/Ww9i3jLyCbeKyYDx29icGycplbX1npRzMK7nUZoKE0Tsf3WxgvGuQgfcwrx1Db
         /x7o4n9iX9zDv88uT32VHcnDYxyzkoa1zHxiCgq50qZo+9aa68sk+onIv19QiEZORxBf
         DKIw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=ATAUcceI9G1zO4y/JpaByVJWD17hb8YRQyenvvUBM40=;
        b=dtCuSxHgrNyGjSouEz+CxNCgB6Ssc0hC97Ll8X8+2ELjQWMwInNL9tdsCaABf9CskB
         L4BBl+Iwp+T9eaGNP2HYadvLgUni8K43VG4MNKsTrZOgBYERPiG5qAk0hfqHslWY8moB
         yo+B7pRNlP01ilkC1mcUoJBPSYkc7eVFx7YcHio3OqRN69rbNImoLAISidmYpN7+CEGi
         1V4tMcM43ByaETzu9z08HBm1q5zZoSe5aRedp+4+qy/zmk0sZ/K81vB4K6B5z14QI1I0
         +pEPnFNcnH3MmC6T10hr68CUKFTV2ppcpw/w8DPzDi3IEks4Ok75ur/IfqYLdfoH2Drp
         nTcg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Yg54iRJR;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id t14si7862751plb.321.2022.01.21.16.32.12;
        Fri, 21 Jan 2022 16:32:23 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Yg54iRJR;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233588AbiAUDqV (ORCPT <rfc822;stevenley.huang@gmail.com>
        + 99 others); Thu, 20 Jan 2022 22:46:21 -0500
Received: from ams.source.kernel.org ([145.40.68.75]:49700 "EHLO
        ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S232662AbiAUDqU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 20 Jan 2022 22:46:20 -0500
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id 30B42B81ED3;
        Fri, 21 Jan 2022 03:46:18 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F4C8C340E1;
        Fri, 21 Jan 2022 03:46:16 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1642736776;
        bh=/SrJvAaNpNb/s+KiB9GJfur39sK083tmIid3c+5q0Vs=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=Yg54iRJRlaucqQWBrWUadksFgFBxUZt0J0Lp98UbsN75fBEYn3dY5MLHYk2iE++4N
         LlJ5rFKiYOvTp3GzH3Dp+rY/NJ4L8rl8e8pstx/ThYOUirzNaK1gscWjfmM/qN9ZQc
         YlQRKdS/vMruvEBLaC52JSFZ2J1/jkoEcG7szqnpUaf28X7iFNrxK7zhsWOPXbRZJV
         a8eAcp7nCJ/4gOILg5hQv7qu4Zcpw4Mu0Gcd1ISeEjvJ4AkUzQwE44MoR437k/mxul
         mqV2L2XMtyWWQ+O94pgbBA1OOapqcP7+CBODd2Sb/GxztwJ/GVWY3AZLnulSuSmfWn
         juXxzcQD3MLYA==
Date:   Thu, 20 Jan 2022 19:46:14 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     ycaibb <ycaibb@gmail.com>
Cc:     edumazet@google.com, davem@davemloft.net, yoshfuji@linux-ipv6.org,
        dsahern@kernel.org, ast@kernel.org, daniel@iogearbox.net,
        andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        bpf@vger.kernel.org
Subject: Re: [PATCH] ipv4: fix lock leaks
Message-ID: <20220120194614.379f5f30@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <20220121031108.4813-1-ycaibb@gmail.com>
References: <20220121031108.4813-1-ycaibb@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 21 Jan 2022 11:11:08 +0800 ycaibb wrote:
> From: Ryan Cai <ycaibb@gmail.com>
> 
> In methods listening_get_first and listening_get_first in tcp_ipv4.c,
> there are lock leaks when seq_sk_match returns true.

This is on purpose, please read the code carefully and try to test 
your patches.