Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1362380pxb; Fri, 21 Jan 2022 16:32:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJx0XYVZWyi831aCgEp7VPcD9Wxk0vTZ8OSeHRlo1PSnWpxgEy/FTP2dEZxWAEEhbstqau61 X-Received: by 2002:a63:e805:: with SMTP id s5mr4603873pgh.369.1642811579273; Fri, 21 Jan 2022 16:32:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642811579; cv=none; d=google.com; s=arc-20160816; b=sdzAC+7mP5W2giSAEWk1K1pVoaUbuanWCQugdWvtohL92MjbxZQ3KSjSd60SAeaDgg jFxcs45ckOIEPGbj3y1y6IIrU741aJIHz1+K5FZbw4DadB/Pd0/51N4DxO+A1vmG74r5 r2lLWhJxWnjvt3SJwcDSgWSHTQab+70mtH/PvhdhbZKUgcpgL6omsXF3yHj1FbZY3W9f tyBEgOImqkSAy+PuNlM8M2SnhOWbFMMhSpHfFe+JR8+N0HOkF3f1o3N5wYmlEkv0HP3X wxOPfa6Ob30QJ079OZSiX95dndCmlAAICntNupSt+33Af6sRQk4ltsBZNsd9oEpFAPmr k6Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :in-reply-to:references:thread-topic:message-id:cc:to:from:subject :date:user-agent:dkim-signature; bh=8+X6EhAbzBhA2wQmYG1k4Og2aMdttrSV1A0aWDvQLhI=; b=OMfEnMW1FQqVhyvzi3cUP281sccY8MKm1EdHedwYnuY2yxIL/bbuwoPFm7wd+/C3uI E/e2+u822AICgFVjjlzDiTCZ49cjB+D0VoIqiIf4XMuq1X/0T+h1BurlvXvPTS6z8U0N MMpHNv1/qBf/eb2rX6AzQV9jCLoOmfzMLe6pSpxQ5a/HvQpkJ2MUBxyZg1QrbP3gPuFc Drzhpxi4rtK1wK/8zCQ6sbKqX/lzeJsG+dI/RS5IbxQ/QmUfrf7maLMgSn0U1ACq9bKB IobjktV9yHc7oeIHV6exDReDoxuZL1V/PkunCX5nB4wi9LrgMT4lTLS7M2Pv+OFOVq9+ +unA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=JVEFPAff; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i69si2296399pge.619.2022.01.21.16.32.47; Fri, 21 Jan 2022 16:32:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=JVEFPAff; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233877AbiAUEGW (ORCPT + 99 others); Thu, 20 Jan 2022 23:06:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231519AbiAUEGP (ORCPT ); Thu, 20 Jan 2022 23:06:15 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C022C061574; Thu, 20 Jan 2022 20:06:15 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id 192so4295642pfz.3; Thu, 20 Jan 2022 20:06:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :references:in-reply-to:mime-version:content-transfer-encoding; bh=8+X6EhAbzBhA2wQmYG1k4Og2aMdttrSV1A0aWDvQLhI=; b=JVEFPAffj9UhWIsMNUTKT8sKFatG3vC/bQtYcujpKlUHNRpDdpnTh1C7rFjfO0hEsV eBuvgTr9oDbe0Iqk+f58SVjyeoU/TjHwwo0RaZ5EolviAgvRL2sPIsPoWEXmcgCLsn5K 9bvT8+4jUrJAIMM9l8ouu8NENjypeIraySAOE/NQo7l9XxdQ5XEz7NT0rO18GOjTolvf KZU0gSj8vNAa7+TDj6fI7nJRyYEJLbRCoAoaiE81fXw+Bl2NDMwi+GHHG+eMq6vX7KMT y73ZnXw70JyjUFEuYPrCaEcUmw7carb5uPQOQ2rAQ9xHzA5arHH1nb4MODWV274gj9AE GPdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:user-agent:date:subject:from:to:cc:message-id :thread-topic:references:in-reply-to:mime-version :content-transfer-encoding; bh=8+X6EhAbzBhA2wQmYG1k4Og2aMdttrSV1A0aWDvQLhI=; b=se6ZbRHX/Ep/viWkil4GbrXjoou2AkDx8JLzZxDVkxW+1EF9Sr5rzm3QDQ1LKL/p8E 4VB+86AgSZJLlFs+d1t1pizoYWjZNQHn1iKNUAw2Zim8y08apPyQM0Gvz31d8rQsE7DA V2etQNrcIDe492utdN/sbkYwigdDH6CpumZqp0OfbtxlppTvclwI36UF2UWAVQyIQkOn MIcq2RNGVK3F4GC7S0tNRiaSO6dokQI2cvnFeIzlxv9eyxwPJhCtbRnFCFrtXi04d0+k N25ugbLy62XAdBrzUDEP9E8l7ZnH0lB0VpvV/3Tw17XkTnDqkMlBL8/XrDrY0jBjtGZs ywCQ== X-Gm-Message-State: AOAM5311hq2wmnI0Ed436EwQnsobkMFgTp8hmj1TXfeFqrYHLmtgpBEa O+AlsPmVIqWTNjx+uRF3LhQ= X-Received: by 2002:a63:211a:: with SMTP id h26mr1608979pgh.239.1642737974681; Thu, 20 Jan 2022 20:06:14 -0800 (PST) Received: from [30.135.82.253] (ec2-34-221-172-227.us-west-2.compute.amazonaws.com. [34.221.172.227]) by smtp.gmail.com with ESMTPSA id ml16sm3554097pjb.10.2022.01.20.20.06.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Jan 2022 20:06:14 -0800 (PST) User-Agent: Microsoft-MacOutlook/16.57.22011101 Date: Fri, 21 Jan 2022 12:06:06 +0800 Subject: Re: [PATCH] ipv4: fix lock leaks From: Ryan Cai To: Jakub Kicinski CC: , , , , , , , , , , , , , , Message-ID: Thread-Topic: [PATCH] ipv4: fix lock leaks References: <20220121031108.4813-1-ycaibb@gmail.com> <20220120194733.6a8b13e6@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20220120194733.6a8b13e6@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry for reporting this false positive. Would be more careful next time. T= hank you for your checking. Best, Ryan =EF=BB=BFOn 21/1/2022, 11:47 AM, "Jakub Kicinski" wrote: On Fri, 21 Jan 2022 11:11:08 +0800 ycaibb wrote: > if (seq_sk_match(seq, sk)) > + spin_unlock_bh(lock); > return sk; Heh, also you're missing brackets so this is patently buggy.