Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 69W2gPcL7qp09eWa9K0rbWCjNmjPILj0N+tJEmmmbgyaPdsm7exDi/iqVo0v/cgCoG3PMZwBCX
 pYzloXBvGz0Y9hXmK0i2EOyOauXZr9uN5276e2RoEVx/pPd/sQs4gxUtBNI1cPiIxSUoG27mRu
 qlX93Lcx79YQJAH1CRQKOEMiIbPGlvfghLrpkbGcNp+sgBetV3tuRWMpwXoLr9yb1mrfvATCCY
 bJBi5rFPNiLYUeahZJIODSogbblFZO2ArkXcdgydl2wrWLwDkDgJBQuOSDA3YvEpyGIqDxLcBI
 PMpYIx5zJrxK+TyDsHK7TCE3
IronPort-SDR: WGte4rypfIfzD5MuM5fmWKT4GrqNaII24jMZI0yqSqRmunQxOKBXINC9dhxpT1GEEct7Mxtdai
 HCJhNGLNOqZFOIPs4zBqexMZqOBtm3hqB5MlF6fUBqSEpgp4WQn1zIhafF8OI8LJfb6deUaJs7
 iWIDhRDUR+eCXNAn1qqKh7WMX7e9UEeBXwt9jHmS6vzUYibM3ZaedDPdb0jtiB1qq0CQqbKaRl
 LHuGISi8BOMGz+LZ7F/lMbNH0ilga7inECSJh1Kh7z0FNstnkW2Z85h20oUiMcV9KPhNgDLmeg
 BgU=
WDCIronportException: Internal
Message-ID: <b239d566-1134-a063-4727-65c0f092400c@opensource.wdc.com>
Date:   Fri, 21 Jan 2022 18:57:59 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] block: fix memory leak in
 disk_register_independent_access_ranges
Content-Language: en-US
To:     Miaoqian Lin <linmq006@gmail.com>, Jens Axboe <axboe@kernel.dk>,
        Hannes Reinecke <hare@suse.de>,
        Keith Busch <kbusch@kernel.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Damien Le Moal <damien.lemoal@wdc.com>,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220120101025.22411-1-linmq006@gmail.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220120101025.22411-1-linmq006@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/20/22 19:10, Miaoqian Lin wrote:
> kobject_init_and_add() takes reference even when it fails.
> According to the doc of kobject_init_and_add()
> 
>    If this function returns an error, kobject_put() must be called to
>    properly clean up the memory associated with the object.
> 
> Fix this issue by adding kobject_put().
> Callback function blk_ia_ranges_sysfs_release() in kobject_put()
> can handle the pointer "iars" properly.
> 
> Fixes: a2247f19ee1c ("block: Add independent access ranges support")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
>  block/blk-ia-ranges.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/blk-ia-ranges.c b/block/blk-ia-ranges.c
> index b925f3db3ab7..18c68d8b9138 100644
> --- a/block/blk-ia-ranges.c
> +++ b/block/blk-ia-ranges.c
> @@ -144,7 +144,7 @@ int disk_register_independent_access_ranges(struct gendisk *disk,
>  				   &q->kobj, "%s", "independent_access_ranges");
>  	if (ret) {
>  		q->ia_ranges = NULL;
> -		kfree(iars);
> +		kobject_put(&iars->kobj);
>  		return ret;
>  	}
>  

Looks good.

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research