Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 21 Jan 2022 12:41:30 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Moses Christopher Bollavarapu <mosescb.dev@gmail.com>
Cc:     laurent.pinchart@ideasonboard.com, mchehab@kernel.org,
        gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: staging: media: omap4iss: Use BIT macro instead
 of left shifting
Message-ID: <20220121094129.GN1951@kadam>
References: <20220121093722.320082-1-mosescb.dev@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220121093722.320082-1-mosescb.dev@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?N6THzXAZ7VtpfV3WJygsbTZ+vqV1xoAi8En8uO1ICzbC8AhbWna9ZPKje9dO?=
 =?us-ascii?Q?9ly7kMRcJ5U+7KuUb7HEe3UZd07QgpmnKZ2RddLtYFQLxAUG3S2hefS0jK6X?=
 =?us-ascii?Q?f5M5E4N5kOBQuq4j0PxuhWv0xxvZnPNz57AvUnyVF+20OXCSSdG1Uywx2hUW?=
 =?us-ascii?Q?qlzKdZq0S1RMiQOKBfmYwYryQ2DFTyn9O1OqeRi/2AlEb8L44SnkIQwco4qe?=
 =?us-ascii?Q?nrflAN6vNlBb4cBOvl7higA0phlAdD0H9T5K1go3NrPiPmNpenQTBFNvsRT/?=
 =?us-ascii?Q?3LP1jlrJpjndhe1zNNcxUaqESy7yJObjpaEU7VLVuoMYxmSVm3qKXOTl3D1I?=
 =?us-ascii?Q?MyDCM8iouDIOR2j/lWr6OEg3EhMKgIldYTSPszu+uuqIKkercTsOctzEuby0?=
 =?us-ascii?Q?RUNlJmJhDcL4q/DqZdxR51NXU9/A7+hzEOFz+90UHq03wppDGvGy4RQo0vXy?=
 =?us-ascii?Q?pLr7V5gZGsUAoc6Xe83AmC0qHO7cqB2fCY19OCD+EKwHMy63GhgqV+KetoeJ?=
 =?us-ascii?Q?SPF4Nbd9WLY9QgRshK6p+m5LmKA/QQ7LKuH2pp3tni9Kl5HA6DLFyUU0DbLO?=
 =?us-ascii?Q?hUX5iK2P8fFr/qsxLeracOpe6m23jausRQ2mAkCBAqM+MlmmnGFqRiP5y44s?=
 =?us-ascii?Q?lNx2Pf0LNaZYbTrD/oBtqsIxcxgXOn92306lDs5h3no1Inek4nAt6HTdIGYA?=
 =?us-ascii?Q?xEoLd2J04a110r+jPjwnMO3aXlzKi1km6LvXP/CeoifwuSwz4Cb1k+3Vhbe4?=
 =?us-ascii?Q?Sh095lfMsFOYJa8LwU++pFGPRIcwHmIHngM+urdue+58ElrGCHpwkcdkxIgZ?=
 =?us-ascii?Q?0dG1u9hwg49sbh4UISGVODjh78qEhmGQ9eKysc+VFpDB0AmzngJpqDG6x1NH?=
 =?us-ascii?Q?qkvwz02u4uWuTC8tC/45siAQF4t/qr8IrPqROs70Qr2+vi09nhrDkW+ouAni?=
 =?us-ascii?Q?H9wzHSkE6hpXQqkXZvFLk4e8WLY4luPfM2RW5ZYx0KoYmEjVX6tIt2NhZiHM?=
 =?us-ascii?Q?kWsRW+m7leyIyTwQrT7vaMLIK6J+NYRp06QI0Em0uZ6DC3cjG0ihDj+j7Nsi?=
 =?us-ascii?Q?bvHt+RoHe+4n784K7mV2bcMkAvKMaAHXJ1p4n/PW3QoWDCDY0hUyGBPpz13w?=
 =?us-ascii?Q?4JJ58ngVaxyWOZoRg3GmjtuN829alvHz1MDh1WltmNa0zD5Oda7e8TDltauk?=
 =?us-ascii?Q?b8F7ytyx9MqdbqDSHEe0nc6Xno4zGUFnxVVAR9bwkVlHXn9E8cPnuG/GWgS3?=
 =?us-ascii?Q?nOwxaiGq/md4CRHvIXAJQB8xYMU2RUBUmSAhZKtW3fMOrKF1wgiacfT/oNr2?=
 =?us-ascii?Q?K3V1bV+CZfE/d3O8Ugn5Qqd0AuDKRqZ+Fzc5g9M45vslIkHYstWZLoHoGNoA?=
 =?us-ascii?Q?0TQGt08uZSIDSSByqXkpMfYq5sDObnNNIt9gU0Q6lu+2ldSMHH/oJ50SdUyU?=
 =?us-ascii?Q?9GKTtsO0mQXb+xX39oH+6gFu1fQRSi1byJnzfhuN4+QsIZgID4poAzBC5VEB?=
 =?us-ascii?Q?XBZ91aGcr/niZogEDNfQ3eSjJq0uMUyedeuI0rrq3WodRGRcs5I7MOPKL3DX?=
 =?us-ascii?Q?r1vEhXMeNAQeo3XQ+C2SZ6VTyn/wyP4SPK5JRFe2siIaCyifYSvhV8MG2IxV?=
 =?us-ascii?Q?/ieavP+8zIigaaxDSb28uLiIVI5qWveIH+iSKb0+dFdfEuZ+thHff+MLoUXs?=
 =?us-ascii?Q?AONTpsZ9xP+DaGQqoIKTIz7ycEY=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5981b4e5-242c-4a6d-0217-08d9dcc23fd7
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1001MB2358.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2022 09:41:50.8238
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sG4eWCKqW/6vN9lN8TuzbyyIucQAk9yK3+FYcmPvdloY0qr7GSw5ns1UY0lv40KsVeqCbYNVyDLhnsRm3JwTFpHf2jHGo0UfmCsIJYvZYG0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB3784
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10233 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 suspectscore=0
 spamscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2201210064
X-Proofpoint-ORIG-GUID: z2ae2C-zfnt3kBACXdsfZr8xbczvy96e
X-Proofpoint-GUID: z2ae2C-zfnt3kBACXdsfZr8xbczvy96e
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 21, 2022 at 10:37:22AM +0100, Moses Christopher Bollavarapu wrote:
> There is a BIT(nr) macro available in Linux Kernel,
> which does the same thing.
> 
> Example:  1 << 7  is same as BIT(7)
> 
> Signed-off-by: Moses Christopher Bollavarapu <mosescb.dev@gmail.com>
> ---
>  drivers/staging/media/omap4iss/iss_video.h | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/media/omap4iss/iss_video.h b/drivers/staging/media/omap4iss/iss_video.h
> index 526281bf0051..ea1cc311384a 100644
> --- a/drivers/staging/media/omap4iss/iss_video.h
> +++ b/drivers/staging/media/omap4iss/iss_video.h
> @@ -55,17 +55,17 @@ enum iss_pipeline_state {
>  	/* The stream has been started on the input video node. */
>  	ISS_PIPELINE_STREAM_INPUT = 1,

This should be BIT(0).

>  	/* The stream has been started on the output video node. */
> -	ISS_PIPELINE_STREAM_OUTPUT = (1 << 1),
> +	ISS_PIPELINE_STREAM_OUTPUT = BIT(1),

regards,
dan carpenter