Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220121041428.6437-1-josright123@gmail.com> <20220121041428.6437-3-josright123@gmail.com>
 <CAHp75Vc9pJMNfW2roUbdrcxCSvyGboTsJC0oTDCcTAS5bmF08w@mail.gmail.com>
In-Reply-To: <CAHp75Vc9pJMNfW2roUbdrcxCSvyGboTsJC0oTDCcTAS5bmF08w@mail.gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 21 Jan 2022 12:41:50 +0200
Message-ID: <CAHp75VcV4F_qLJXW_dZ3t2MGLt0ddKX6m6NzapLtVwvNXaH19A@mail.gmail.com>
Subject: Re: [PATCH v12, 2/2] net: Add dm9051 driver
To:     Joseph CHAMG <josright123@gmail.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, joseph_chang@davicom.com.tw,
        netdev <netdev@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andrew Lunn <andrew@lunn.ch>, Leon Romanovsky <leon@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jan 21, 2022 at 12:37 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Fri, Jan 21, 2022 at 6:15 AM Joseph CHAMG <josright123@gmail.com> wrote:

...

> > correctly use regmap bulk read/write/update_bits APIs
> > use mdiobus to work to phylib and to this driver
> > fine tune to arrange the source code to better usage
>
> This is not tagged properly. Also, I specifically removed everything
> else to point out, please, read finally the article [1] and write a
> proper commit message. And move changelog under the cutter '--- '
> line. Without doing these two things nobody can do anything with your
> contribution.

Next comment, remove all those `unlickely()` calls. Otherwise you have
to justify their appearance.

> [1]: https://cbea.ms/git-commit/


-- 
With Best Regards,
Andy Shevchenko