Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 21 Jan 2022 13:40:55 +0100
From:   Olivier Dautricourt <olivier.dautricourt@orolia.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Stefan Roese <sr@denx.de>, Vinod Koul <vkoul@kernel.org>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        dmaengine@vger.kernel.org
Subject: Re: [PATCH] dmaengine: altera-msgdma: Remove useless DMA-32 fallback
 configuration
Message-ID: <YeqiPomFySvcl+FL@orolia.com>
References: <01058ada3a0dea207212182ca7525060a204f1e1.1642232423.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <01058ada3a0dea207212182ca7525060a204f1e1.1642232423.git.christophe.jaillet@wanadoo.fr>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QrJtIeadhbQbDvi7fLQ8nbPn2L2Ca/GrrL06/BqERhjO/Rw8T/X1Swh+/Qr9?=
 =?us-ascii?Q?u6/93T3C6AwjmkHPmVYqrtKOt5OZ59OMpFbTIWikg6t2GpgIpdz+Gt8QizVf?=
 =?us-ascii?Q?MoHv+w8qlB2B1Fx5Jndd9yF1F/ti2kRBSBLxJ3M3UYkGCfF3d2MQqjsROYDz?=
 =?us-ascii?Q?P9TNzB2R6j5VLnsDAnPa7GGHhI8NsBxviCyjONGCltGsGDIg7ED9AS04FzCD?=
 =?us-ascii?Q?Fd7VUmSqHVMtOBcr2ZnrNDaaHQQEvfXURTX/aunAmhrzFqXQJm4TH6+JZGso?=
 =?us-ascii?Q?Pj1lrWig5zPWzS9Zqh55PkBuPnZZrxELeBIPCUhgrepsnD6VFj262nRovbhT?=
 =?us-ascii?Q?NpKdr4cyANI1ej3VATpoBkSvyj6bakvG6Y2HeXGVdW/EhZRVR34RwBLzrMy2?=
 =?us-ascii?Q?ao1dGfVtw/u9/yNuq9NbDtQu/tFVGdSaQAdr//RbuHReSqNdv5uVdB1JvLG8?=
 =?us-ascii?Q?dZsQkgozfmajhU+Q9rocz1slvmQC4L7oq5jnFBpDNtsY4dJOrFVtI9K/nKSe?=
 =?us-ascii?Q?0cnOKRklta6AkoihVh0aRkkiu572EDQLbBIerHuGziB/MVfdgZCOG0ZGWdIF?=
 =?us-ascii?Q?8NClJdZp+oelEjFJERGFPoUPQDjAWtMWewBUElUwIFBuEHRXGK6GZ4FANnQa?=
 =?us-ascii?Q?AuKNt0fGHcqDq79GKihGxiDxYTQdOYrsWCQZD05tRIDfGTDsrZxB0CGH5/DH?=
 =?us-ascii?Q?HgkNAPT3bWhBirsRRfpdhpk548nXpbyqglkyOzjR2FJDQ6Ts4hwRckQ/KB+G?=
 =?us-ascii?Q?IKzv5lVc/gGA7q7bzmrts6A+odnbB8WD17BrmEJZOdaT/JEFnUgTcbEz2WDu?=
 =?us-ascii?Q?pe7nr19LXaw7BIY5fuhnO0sc89MG6IZXMUJ59uRRYJ+gq+35S2hrD4i3YHRa?=
 =?us-ascii?Q?lkf5OK8lsjCjH//KoqmgDjvwTPtvUCb67Lj0x/dUkpiyv7k9OrwbAuyp32lC?=
 =?us-ascii?Q?w6tQKyja6ZIcUgdFJdqo8hgo3CK+O7gTassQaFy/O7/Qv3iuWIeGa1k+0zU4?=
 =?us-ascii?Q?w/38qjFuqIQ6Vb0Ih63l6N0kt8NX+hiUxsvcV7r4YUP++9JYHs6wI8lI1ug+?=
 =?us-ascii?Q?Hs0Y26BI2NH5TbeU54bz1QrqfOGwx2uFBrYnhyPBGQTRk2PMeLqzOnvFIGxk?=
 =?us-ascii?Q?qvETsc/PvjFqVz1lwDPxlAB5AohzWhhobG1w2+vBK8YYsovgd3k9u/czVDP5?=
 =?us-ascii?Q?HJHna6K2d7TD6Vyyg4RTkfu63soN2u/i7dafvVsRmlR+oWiJl7WyK28GZ5fe?=
 =?us-ascii?Q?Q5oXKd5WXioTW8kQvkuXgvDn9zdvZhbcl0sf7ydhGemdqK/6wUBb+NlRe1Qf?=
 =?us-ascii?Q?jiI/dVk/LFvmMRBggCqMZXOHaya/nJ1WGA/+5eIK70/iZ5phxzKKQYcLJctn?=
 =?us-ascii?Q?P9JweXbCc8rOixSLHulg2Nnr5VLTR1upBYTToS6Xk5HKjcFhlVwMOHbX4Ng1?=
 =?us-ascii?Q?TNmq6K9By48ibm9WDJV3rQ88UuE8FeVnNPuwHD2pRF6dmoZ8fuCwlcfu09Hb?=
 =?us-ascii?Q?Gs0B/SM9kmKnreov+sSiVMpLDU92GT5KDMsDtbO6paMc6CxysdIJXsmEtPmo?=
 =?us-ascii?Q?OgaRbpPd+VzSaYLClG0zMScJusb56oFaaCSGLN9fDbJ0OFOCvcADIWMA+DPF?=
 =?us-ascii?Q?CxMpbvrUMXGM9Wxl2IjeHnIpAMl3ysOo5EoAjpX3TlsAZvjFzeagPn7r8vpu?=
 =?us-ascii?Q?atFPFRoHQXhwV1Tuq+SsxHy4H2B4GA8LoChBRJP9cNZyykDnOEMaXvRRROja?=
 =?us-ascii?Q?DBUpbwwfxg=3D=3D?=
X-OriginatorOrg: orolia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bbc6d8e-ce67-4c36-0e52-08d9dcdb47bc
X-MS-Exchange-CrossTenant-AuthSource: PAXP251MB0319.EURP251.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2022 12:41:01.0496
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a263030c-9c1b-421f-9471-1dec0b29c664
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ns7iyQ2+WsE2gIF8/fCbINDQgqhGuOOH32+FQjOvU7t7UrIGRoY8PCiDmWCYoIn8GWqfhH+8wPpkRPNqJdZv55D3mCvNr87WLTOcciZRvIU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9P251MB0206
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The 01/15/2022 08:40, Christophe JAILLET wrote:
> As stated in [1], dma_set_mask() with a 64-bit mask never fails if
> dev->dma_mask is non-NULL.
> So, if it fails, the 32 bits case will also fail for the same reason.
> 
> Simplify code and remove some dead code accordingly.
> 
> [1]: https://lore.kernel.org/linux-kernel/YL3vSPK5DXTNvgdx@infradead.org/#t
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Acked-by: Olivier Dautricourt <olivier.dautricourt@orolia.com>

> ---
>  drivers/dma/altera-msgdma.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c
> index f5b885d69cd3..6f56dfd375e3 100644
> --- a/drivers/dma/altera-msgdma.c
> +++ b/drivers/dma/altera-msgdma.c
> @@ -891,9 +891,7 @@ static int msgdma_probe(struct platform_device *pdev)
>         ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
>         if (ret) {
>                 dev_warn(&pdev->dev, "unable to set coherent mask to 64");
> -               ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> -               if (ret)
> -                       goto fail;
> +               goto fail;
>         }
> 
>         msgdma_reset(mdev);
> --
> 2.32.0
>