Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1401108pxb; Fri, 21 Jan 2022 17:44:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJyXpC++/WQXFaowXjLDAmpGEuGpPkcIhEYele07PQ2raWrRhZk9j+ehtarWhX8waXBotydP X-Received: by 2002:a17:90a:5896:: with SMTP id j22mr3306683pji.182.1642815886826; Fri, 21 Jan 2022 17:44:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642815886; cv=none; d=google.com; s=arc-20160816; b=Al6Ntq5IyOU1hrujRjwROyrgew94uH3fHCvWkbesAh325I8JxbHAPI4HArJj+h7kj9 6GWYEJH7VeUhNe9OUoBZ0cdytoXa+094U34nhyUC2yNAHtwN0CH7bTSW70vHLKZupjgi uP/L0pzXqJdmclxHepKOSjwr1A3XtWIkWLCCARU/QduR4fUcV5o6KVKJIHdVka6YrXoE bqqE3kw++XRsCc9TE356ANd8MrR19cGm9qW62ZJfbMI0gEqRJa9mPA9osYK4KWJ3CPys H2OM420co0IXCG5PP6mWrVFsUk81/iWHK/ACU62Q1iR2rRDG3vW14sTEKObTj5hG+Jn0 TInA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7TYpd5MPsV4XMXjedjn/9mFjuoXURQUFFcd+giqMMTY=; b=rcwGhEXQBvlLzKDS9p/ui+3Z9R8hXe8mnHSpmiE0XA+Fx3+PkyFTloIHSH1o12gHVn TH6gAa1l6Z81ToVpddbdTXF29O9Jpq6MyvVqPC6yCZn8uVh8NW90/d2r5zTrhQOEi6Ms xcjJ3kec16MfMK7XQJk/vUlTnwZm6jO3KlsheaUn3PVybHkLp/1yIWiYyB51ZqJeHg4O pAkSnBtGzvU1LpkVy41+JXuvOyK21r9+qIa+GYwIyxyPx5ZsIypdxW9lj3sqkSIOtZ2Y gQA0FBHnAOZ9cHChuc8zgQYXVD3CKQDkittCRUUzb75Bbrfscqg6frldqfPQxeGc6w5U VbmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=DNrMBFUc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r187si8556252pgr.87.2022.01.21.17.44.34; Fri, 21 Jan 2022 17:44:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=DNrMBFUc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381237AbiAUOaB (ORCPT + 99 others); Fri, 21 Jan 2022 09:30:01 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:60330 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348743AbiAUO3p (ORCPT ); Fri, 21 Jan 2022 09:29:45 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 20LETeIo047925; Fri, 21 Jan 2022 08:29:40 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1642775380; bh=7TYpd5MPsV4XMXjedjn/9mFjuoXURQUFFcd+giqMMTY=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=DNrMBFUcREuYMk0vTQ8xpPRRqXZbCjk8dYPE3DWaRU1a1EAgo1Iw/73TpPtzPfudk nrlimZphJaIxnCCbZSMspi7QhMpbJVE5jV9u6JXVFi9xRw4UNJFFbA6XZj4K8k4QV3 Yc5zXGbsI2d5nXIOYq7f1o9ctO+QjbeFu4lxfjKU= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 20LETek2065125 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 21 Jan 2022 08:29:40 -0600 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Fri, 21 Jan 2022 08:29:39 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Fri, 21 Jan 2022 08:29:39 -0600 Received: from pratyush-4F-325.dhcp.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 20LET4Ht072129; Fri, 21 Jan 2022 08:29:36 -0600 From: Pratyush Yadav To: Mauro Carvalho Chehab CC: Pratyush Yadav , Laurent Pinchart , Nikhil Devshatwar , Tomi Valkeinen , Benoit Parrot , Maxime Ripard , Rob Herring , Sakari Ailus , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , , , Subject: [PATCH v6 08/14] media: cadence: csi2rx: Populate subdev devnode Date: Fri, 21 Jan 2022 19:58:58 +0530 Message-ID: <20220121142904.4091481-9-p.yadav@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121142904.4091481-1-p.yadav@ti.com> References: <20220121142904.4091481-1-p.yadav@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The devnode can be used by media-ctl and other userspace tools to perform configurations on the subdev. Without it, media-ctl returns ENOENT when setting format on the sensor subdev. Signed-off-by: Pratyush Yadav Reviewed-by: Laurent Pinchart --- (no changes since v5) Changes in v5: - Add Laurent's R-by. Changes in v2: - New in v2. drivers/media/platform/cadence/cdns-csi2rx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c index f072e5111240..28fb2078d10d 100644 --- a/drivers/media/platform/cadence/cdns-csi2rx.c +++ b/drivers/media/platform/cadence/cdns-csi2rx.c @@ -677,6 +677,7 @@ static int csi2rx_probe(struct platform_device *pdev) csi2rx->pads[CSI2RX_PAD_SINK].flags = MEDIA_PAD_FL_SINK; for (i = CSI2RX_PAD_SOURCE_STREAM0; i < CSI2RX_PAD_MAX; i++) csi2rx->pads[i].flags = MEDIA_PAD_FL_SOURCE; + csi2rx->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; ret = media_entity_pads_init(&csi2rx->subdev.entity, CSI2RX_PAD_MAX, csi2rx->pads); -- 2.34.1