Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Richard Cochran <richardcochran@gmail.com>
CC:     Andrew Lunn <andrew@lunn.ch>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        David Miller <davem@davemloft.net>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Joakim Zhang <qiangqing.zhang@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Miroslav Lichvar <mlichvar@redhat.com>,
        Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH RFC V1 net-next 3/4] net: Let the active time stamping
 layer be selectable.
Thread-Topic: [PATCH RFC V1 net-next 3/4] net: Let the active time stamping
 layer be selectable.
Thread-Index: AQHYAPlHUZ7+aaeSVU6jmUK14JiGzaxsOSsAgAC1gICAAAeKAIAAtFaAgAAKjACAAA9mgA==
Date:   Fri, 21 Jan 2022 16:23:27 +0000
Message-ID: <20220121162327.4p3iqbtt4qtnknhp@skbuf>
References: <20220103232555.19791-4-richardcochran@gmail.com>
 <20220120164832.xdebp5vykib6h6dp@skbuf> <Yeoqof1onvrcWGNp@lunn.ch>
 <20220121040508.GA7588@hoboy.vegasvil.org>
 <20220121145035.z4yv2qsub5mr7ljs@skbuf>
 <20220121152820.GA15600@hoboy.vegasvil.org>
In-Reply-To: <20220121152820.GA15600@hoboy.vegasvil.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OT87O2T/5z29xygX69mAIwMqeZHQgEjzjog6cpTVYRtRblq+P4lkrv4JQdO8?=
 =?us-ascii?Q?LqJUFfw1JYZ2y+4tSasnFyMFCeHh8MMwhpZ/JQBO7sWHo2JAph2J0C6b/zoq?=
 =?us-ascii?Q?M3oPUe4bJoKjTkKIJzw01hQYXHZbAMxHbe29+ShQYqAYxtL01DsQ3MPHtAJY?=
 =?us-ascii?Q?GNGcSkS3gmWhElV8SAfCtFhargPKLudeEd0ydR51dEEcQqHft9pjfCph9KUR?=
 =?us-ascii?Q?u2KSWuED+Hb9jV6ZhrW0pVwRChqXVjxXQPNE11BX/FfxQbb/JGwdA0HZRyeY?=
 =?us-ascii?Q?yJTHcRYqLowaCmEWwpc+QO4egQaHdOgI8/D9XGZxRDGuya2b/DamDk+fOeUq?=
 =?us-ascii?Q?95rfZWFACW+JE+tb7imZnOfr4PmgHcwsikDcpig3D6WcN84R5q+kNMVDYJWX?=
 =?us-ascii?Q?5Fgo/zdQ6laBmJ1sJ82zt9sYXKYyXkMN8T3rTLzEtU8w/p13rcQ+MzYMTrJn?=
 =?us-ascii?Q?TXfw7cKYDoacUSqvwnNj9M7wjoFfHLw7kZBpxV29eCYgXy6B9oyS9/e+1VRF?=
 =?us-ascii?Q?j3WyT1gdwRCzETIXi0pyu5xCYAVFls/OZwHzXjatX+hLPzM9cZRgdUXgVEFW?=
 =?us-ascii?Q?ZtRypiGFqDdYpPYyEY+C2E96MvwWSkgbpuSZg63lx7xM0SjNnXxR1uhlFrde?=
 =?us-ascii?Q?5MWr0XiyvGStYyk4ag6gybhW8pbVIaE1qExpVZACFunPBg7NAPrTyJD+rpq8?=
 =?us-ascii?Q?Yb6LHPjp/ofLAVwQEGG16iAy61Ux7IQAw+YD18ODWprrOaFogHTKULjX3weD?=
 =?us-ascii?Q?mp/vv9yyUahmksWtZ5eJyRy1Gr7EZgsibn0iT4mRJYBR5bn/gaG6W2kgzObt?=
 =?us-ascii?Q?HrWWpoTO+J21F/FXyzk7pBvBNnMmaCIMxFepDt6QTjct5Tb4RE/Trm6S2kop?=
 =?us-ascii?Q?2u2fkdLawCOyMwk643ljjb2ual7N2yKCOfs/NmClZwjg0dvjQzoz38i7aZ3A?=
 =?us-ascii?Q?oV/rkuy8tsonag/0IDBnjbtxecRBMrze7z4ZFT00u6bbMP7DUBj65683qjhv?=
 =?us-ascii?Q?KmtGxwsdI0+m7ddRoJ3B6Zno3E+HR0n3bPBaR9xNhb6pyHls2cUGGFhGbq6+?=
 =?us-ascii?Q?DrDrKbUqmKaXk5eO4CoW36ixetgSbU69bK0CwhK7dianr3RdanJMrtjGxyyx?=
 =?us-ascii?Q?S+TszOEe2NXKeaxoLac+OiD9eyHjTUhCW9iCez30IB7tUsw8Lm0ZtQ0ooDzy?=
 =?us-ascii?Q?DP+TC0/Hl0rdHkMMWxNXryZWq9Oz+QnCCnuWl0CWQMzChA48eUqTeHsHNmr2?=
 =?us-ascii?Q?fMZmHXJB8DKUoLVRVXX6bEyXARS9vQ1CvJh+ucBESLcxZjJtveNlf+9m2lRT?=
 =?us-ascii?Q?zRxYbhEFleWduvTr6nXfcXt22v413ecDAo3CeutyQ6R/mqfL0U720eQcjE6F?=
 =?us-ascii?Q?jhHyZvcC+8AVFiDKy9VjbbZg7toGbX1oKBpNgNQTQbWOK/bvB0OLMCdPoDVh?=
 =?us-ascii?Q?sqkK124TqjVlAgg5f+64gnMwAgiPDlNs5AM0I5RD4heU7SbA/++Juju2uj8e?=
 =?us-ascii?Q?UROubqVtlbtuohTyZhUG2w6S0F8y9H1MEQNZKbKFaUvXFIitEG6AgKuWUgk6?=
 =?us-ascii?Q?bJwURFzlQ1R0GT8rElLh/a44ZvhtLJAwE5EmzqrZsCKrOx6G/CHevkCi9vrC?=
 =?us-ascii?Q?4TS1wAWcGGrbeUau17actX0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2773BAB5E6BCE94ABDE184A97F424738@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a050f50b-350f-4475-f1ba-08d9dcfa5b44
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2022 16:23:27.9409
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SFucUTXJbvB8IjM6/FpqYCvA7EGIO0DBQuHN7CHhbaTCClTFf0I8n4T2duPwcTDUJSwEUgk/zB6kwNUN9SMs2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2311
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 21, 2022 at 07:28:20AM -0800, Richard Cochran wrote:
> On Fri, Jan 21, 2022 at 02:50:36PM +0000, Vladimir Oltean wrote:
> > So as I mentioned earlier, the use case would be hardware performance
> > testing and diagnosing. You may consider that as not that important, bu=
t
> > this is basically what I had to do for several months, and even wrote
> > a program for that, that collects packet timestamps at all possible poi=
nts.
>=20
> This is not possible without making a brand new CMSG to accommodate
> time stamps from all the various layers.
>=20
> That is completely out of scope for this series.
>=20
> The only practical use case of this series is to switch from PHY back to =
MAC.

I don't think my proposal is out of scope. It deals with the same thing
as what you propose: the kernel makes a selection by default, user space
can change it. The need for PHC identification in the cmsg arises as a
direct consequence of the fact that there are multiple PHCs in the path.
It isn't a requirement that I introduced artificially. Your solution has
a need to deal with that problem too, it's just that it omits to do so:

|               When changing the value, some packets in the kernel
|               networking stack may still be delivered with time
|               stamps from the previous provider.=