Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 21 Jan 2022 17:05:40 +0000
From:   Daniel Thompson <daniel.thompson@linaro.org>
To:     Luiz Sampaio <sampaio.ime@gmail.com>
Cc:     Michael Hennerich <michael.hennerich@analog.com>,
        Lee Jones <lee.jones@linaro.org>,
        Jingoo Han <jingoohan1@gmail.com>,
        Helge Deller <deller@gmx.de>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 24/31] video: backlight: changing LED_* from enum
 led_brightness to actual value
Message-ID: <20220121170540.w6c4wqwrqzpde2lm@maple.lan>
References: <20220121165436.30956-1-sampaio.ime@gmail.com>
 <20220121165436.30956-25-sampaio.ime@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220121165436.30956-25-sampaio.ime@gmail.com>
Precedence: bulk

On Fri, Jan 21, 2022 at 01:54:29PM -0300, Luiz Sampaio wrote:
> The enum led_brightness, which contains the declaration of LED_OFF,
> LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports
> max_brightness.

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>

BTW it looks like this patch might wants to land in one tree (I can't
see since I'm only on copy of this one). If so please discuss with Lee
how you want to land it. Put more directly, please don't treat my
Reviewed-by: as an Acked-by: ;-) !


Daniel.


> ---
>  drivers/video/backlight/adp8860_bl.c | 4 ++--
>  drivers/video/backlight/adp8870_bl.c | 4 ++--
>  drivers/video/backlight/led_bl.c     | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
> index 8ec19425671f..063be4189e7e 100644
> --- a/drivers/video/backlight/adp8860_bl.c
> +++ b/drivers/video/backlight/adp8860_bl.c
> @@ -261,10 +261,10 @@ static int adp8860_led_probe(struct i2c_client *client)
>  		led_dat->cdev.name = cur_led->name;
>  		led_dat->cdev.default_trigger = cur_led->default_trigger;
>  		led_dat->cdev.brightness_set = adp8860_led_set;
> -		led_dat->cdev.brightness = LED_OFF;
> +		led_dat->cdev.brightness = 0;
>  		led_dat->flags = cur_led->flags >> FLAG_OFFT_SHIFT;
>  		led_dat->client = client;
> -		led_dat->new_brightness = LED_OFF;
> +		led_dat->new_brightness = 0;
>  		INIT_WORK(&led_dat->work, adp8860_led_work);
>  
>  		ret = led_classdev_register(&client->dev, &led_dat->cdev);
> diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight/adp8870_bl.c
> index 8b5213a39527..b04faf8d631d 100644
> --- a/drivers/video/backlight/adp8870_bl.c
> +++ b/drivers/video/backlight/adp8870_bl.c
> @@ -287,10 +287,10 @@ static int adp8870_led_probe(struct i2c_client *client)
>  		led_dat->cdev.name = cur_led->name;
>  		led_dat->cdev.default_trigger = cur_led->default_trigger;
>  		led_dat->cdev.brightness_set = adp8870_led_set;
> -		led_dat->cdev.brightness = LED_OFF;
> +		led_dat->cdev.brightness = 0;
>  		led_dat->flags = cur_led->flags >> FLAG_OFFT_SHIFT;
>  		led_dat->client = client;
> -		led_dat->new_brightness = LED_OFF;
> +		led_dat->new_brightness = 0;
>  		INIT_WORK(&led_dat->work, adp8870_led_work);
>  
>  		ret = led_classdev_register(&client->dev, &led_dat->cdev);
> diff --git a/drivers/video/backlight/led_bl.c b/drivers/video/backlight/led_bl.c
> index f54d256e2d54..1b869624b4f8 100644
> --- a/drivers/video/backlight/led_bl.c
> +++ b/drivers/video/backlight/led_bl.c
> @@ -46,7 +46,7 @@ static void led_bl_power_off(struct led_bl_data *priv)
>  		return;
>  
>  	for (i = 0; i < priv->nb_leds; i++)
> -		led_set_brightness(priv->leds[i], LED_OFF);
> +		led_set_brightness(priv->leds[i], 0);
>  
>  	priv->enabled = false;
>  }
> -- 
> 2.34.1
>