Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1412743pxb; Fri, 21 Jan 2022 18:05:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJxJBL9NMTPG+OTJV0FlluY3YNsemq1sL0yjq3nCpzKNevk2KuMdiIW6qtDupLYIivJmTOl6 X-Received: by 2002:a17:902:f54b:b0:14b:2aa6:d2b with SMTP id h11-20020a170902f54b00b0014b2aa60d2bmr2727591plf.152.1642817119776; Fri, 21 Jan 2022 18:05:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642817119; cv=none; d=google.com; s=arc-20160816; b=g/eIzu/KB4oPbNe06XEHtZpNi2mGMBTaoHncliFiRQxpYxYgfXHSWLYij2j5XtxvkU V954SpP9fqZQCc4dOhYjqXnIZbNOhAm445OF19S5g0yshusTjzKNMzL5YRMwceMu2COT XtkkSy1P3Mpno5eYHjhJHe1pBUZJzJIrcdD7Bc0hdCJkKBhLNczqKoxJIbmkWRg6rrZJ KTbSRaqrFvpP7S0PWJK5d+3uzUrnpIADaJb+0mXySUp27S5MwRQ2TojOj886fkWEjvNS SvFA1j0T35+cFHCJTCi1nQqDptMXqSDMelveUb+2h44gz9psnL77sg3DpQVStYuyTiRQ 1qiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:to:from:dkim-signature; bh=BvgJ1KhQ09zgjMCeIf9WRh/NdcZGH1G7T7wldmYjdSE=; b=IS7hSWTN0RQ3OcLxp4Noygw51+s0y1YNEOphVJPEv+kbMDj4luktO3njEtjcQTWQjp KfSHQv7QGdtjY/X4qpKIvG1E8C4z380G3s1jEW8Tw9+Zgl77kFV1P2L/ogHLq5FH9i7q GW5mRWHjy61n/1zu6FHW8OUe9lfv1S2xc7TujOiGYuI9I/ztPyNkFZpG+1bLJuGpXMz8 IQXwKTHru4LZLroxgr3wXjeNgoYSN+axVJa3wKRP7SDl6zETQbI3Qz55qlNhAArYtydi Ll1ZJP92FusqQ53r/8BvFaPEYCrNmfClsk4tdGCgup4NSDPyVWFpj3kErB0Y5++oNRmk A2yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=cNENdJj9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f11si7991100plg.261.2022.01.21.18.05.08; Fri, 21 Jan 2022 18:05:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=cNENdJj9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382029AbiAURsz (ORCPT + 99 others); Fri, 21 Jan 2022 12:48:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382045AbiAURsH (ORCPT ); Fri, 21 Jan 2022 12:48:07 -0500 Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3897C06173D for ; Fri, 21 Jan 2022 09:48:06 -0800 (PST) Received: by mail-io1-xd2f.google.com with SMTP id s11so11605370ioe.12 for ; Fri, 21 Jan 2022 09:48:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:in-reply-to:references:subject:message-id:date:mime-version :content-transfer-encoding; bh=BvgJ1KhQ09zgjMCeIf9WRh/NdcZGH1G7T7wldmYjdSE=; b=cNENdJj9VCARwTzDZtisAhMuzRAldSqAvbGoQbnJu32rHz0Q1fS52L8cwBPwk6voZU dMUT7Gpa3TD8uvgwbpI5R5rHhp0CQspe1jE4mdX9yocZtgmKiKpdZC5U9/9EkgW3HOc/ w+ACPfBlyX+zmaNQnqLEedOWd+iA6Dpgdlqcncu4Pk6EM7VKuZTaS2OKWdnaC/Aqvdih cGZZc/y2zEQr1hC9BX5DfDPBk9ULLQWsDB70O5+iM1iUvdf0S+eX/Cy1Tv0pkoL976dX W77cuSpyDlMW2gpriOkOEVtNUqoc0fly/P3AcRB0QS2FqZk/VHVOwu8++g1u/WVC/N6u CqPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=BvgJ1KhQ09zgjMCeIf9WRh/NdcZGH1G7T7wldmYjdSE=; b=aSljji6GZJS15WTXPTBOvcR2BS678Pd/oZl015GHWmardZLASjadWnh/a1KvVuG82o 6dxZNzaGjqolvmAHL5j9blV/tkUM67jRtNbodmn5llw6uBQLwznLsTtTkPCE4F7irTI7 gAjhQfQoBj6xoOqtD0C5Dmfqg20UHW+EuCPb2SSnpo6/aJ+g1AIowl+jTbHioSwTxpd7 9ApKZ9jkEKxr3jmi0ZZVTOCEttwNNG6HyPjAPW8iHEqCxKJrdzsrQw5ARbIzqDr42NEV FNthQUbae6tFoyXtRIxzBMZop+P51jLPMbsrM0g3cE4OEAw4FTHy5n1aezWBV4Y4T3Cg 0mQg== X-Gm-Message-State: AOAM531dMCQe0pUz4KUjR8Nz1Kc6uc4XwC7x2H7jcTldr+jr5bvst1xT JNVgY/RYcU6FBvJvwtc5KRz/MFphGKB4RQ== X-Received: by 2002:a05:6638:a3c:: with SMTP id 28mr2396405jao.281.1642787285706; Fri, 21 Jan 2022 09:48:05 -0800 (PST) Received: from x1.localdomain ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id h12sm1549324iok.25.2022.01.21.09.48.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 09:48:05 -0800 (PST) From: Jens Axboe To: Hannes Reinecke , linux-kernel@vger.kernel.org, Miaoqian Lin , linux-block@vger.kernel.org, Damien Le Moal , "Martin K. Petersen" , Keith Busch In-Reply-To: <20220120101025.22411-1-linmq006@gmail.com> References: <20220120101025.22411-1-linmq006@gmail.com> Subject: Re: [PATCH] block: fix memory leak in disk_register_independent_access_ranges Message-Id: <164278728249.232198.7158002983506256334.b4-ty@kernel.dk> Date: Fri, 21 Jan 2022 10:48:02 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Jan 2022 10:10:25 +0000, Miaoqian Lin wrote: > kobject_init_and_add() takes reference even when it fails. > According to the doc of kobject_init_and_add() > > If this function returns an error, kobject_put() must be called to > properly clean up the memory associated with the object. > > Fix this issue by adding kobject_put(). > Callback function blk_ia_ranges_sysfs_release() in kobject_put() > can handle the pointer "iars" properly. > > [...] Applied, thanks! [1/1] block: fix memory leak in disk_register_independent_access_ranges commit: c321e650a45c4228cce1107680ac74e06f014906 Best regards, -- Jens Axboe