Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1578403pxb; Sat, 22 Jan 2022 00:07:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJxZ0yi+Y2SBY9P1+CGvqMXyp1ha93Fo7dtLlh6Tz2D82wpGJSUBJgPEfk92wrrmR+qsJvbV X-Received: by 2002:a17:902:7597:b0:14a:b4c8:23ce with SMTP id j23-20020a170902759700b0014ab4c823cemr6654115pll.170.1642838839244; Sat, 22 Jan 2022 00:07:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642838839; cv=none; d=google.com; s=arc-20160816; b=YF4B4skRqoJDj5A6i3mznJVKXDdaDayJKNrFg52kZDGE1uin8yGadVaQ1rFr7XhPvG yROIQyTMgjhxYsMjibhLGaddB3Zg8H5v+e8JbLl61xhqfbMQbFwgr1g9JLRekLoA7kql r4nVSyUlrXgPyFceyLUWoiPe4QmdKjcIUPRvxBaCQMsKKxHnWxSsS6EHLshEGS5m+MFi 5NqNYClABh+xQydAkkQjcWvEsRQvRTGedbPCkYyWR0W/0OMsXm/LjXSG+cnp1p5pBKgS EfCfwldqFs1VuAzOnbNXrhlIpyUF29/DxZMCPIs6xRIjejIOH82eQSPZf9oytNk9Cjrz V/7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=oBqGV4H7K/jCpP8PTz6+aYreOz0jHaQWza7NI4+WEM4=; b=jsvU2mT+u3j6o6VuF82VWi2zFUnP77aA0JFJXQmgIujUB0AnC6vLWwcUGtkZy0Jc47 rSapQBH8bKkrvYd1w+FgsQm24deUC/HHqrCW3A23nE6kL5lFTAvckS5Lh99Ko2TUpF6N pGgoxSX3ACxsRhTR/958rFyYeq17RVgHlSHkjsQIYC3DfWaiXzAv0IeKFOTQj6Eq0Im+ TwWl5kNIgiTQq7Q46EwVm1QnDnQsSZONGBLmgUn4V26C1dzxXc1PxXYo+xxusEIQgrNa MqUBvXa5uWobboa/+8DLAEyrZzCjt8tcpNYSNnD26mD7QSFDXeuUoLDrMnaeg28ENH0q yGiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=BMscvUpi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s5si8237227pgj.155.2022.01.22.00.07.07; Sat, 22 Jan 2022 00:07:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=BMscvUpi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233088AbiAUUXQ (ORCPT + 99 others); Fri, 21 Jan 2022 15:23:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232988AbiAUUXP (ORCPT ); Fri, 21 Jan 2022 15:23:15 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8CBCC06173B; Fri, 21 Jan 2022 12:23:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7771961770; Fri, 21 Jan 2022 20:23:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 926E0C340E7; Fri, 21 Jan 2022 20:23:13 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="BMscvUpi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1642796591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oBqGV4H7K/jCpP8PTz6+aYreOz0jHaQWza7NI4+WEM4=; b=BMscvUpigkybSXqmm6pvM0d9nar+niscgkEtK7t6AlZ255cvnXWJHE57oPKT94a5SPmziW 3qepWhXljuII19w3iYazpQ4TNYxTBsozuR+Qndq7tczbA5JNAqthomyKT3EP2LdKS3gw4T Wb51lIEedSU3FGf5ad1TdX9AuUw/FHQ= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id d9286d3a (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Fri, 21 Jan 2022 20:23:11 +0000 (UTC) Received: by mail-yb1-f171.google.com with SMTP id k31so29193052ybj.4; Fri, 21 Jan 2022 12:23:11 -0800 (PST) X-Gm-Message-State: AOAM533ssxZKzIk3cGE78ZyTrLoct89FNtj8ed+O2ROTPy8wGYDO5N6s USxuG+1aOkJUfmmmbiHh4glJy7p/7uTLFKQ5lqw= X-Received: by 2002:a25:244b:: with SMTP id k72mr8936181ybk.638.1642796590031; Fri, 21 Jan 2022 12:23:10 -0800 (PST) MIME-Version: 1.0 References: <20220119135450.564115-1-Jason@zx2c4.com> In-Reply-To: From: "Jason A. Donenfeld" Date: Fri, 21 Jan 2022 21:22:59 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] lib/crypto: blake2s: avoid indirect calls to compression function for Clang CFI To: Eric Biggers Cc: Miles Chen , Ard Biesheuvel , Linux ARM , Linux Crypto Mailing List , Linux Kernel Mailing List , linux-mediatek@lists.infradead.org, Nick Desaulniers , Sami Tolvanen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 21, 2022 at 8:54 PM Eric Biggers wrote: > There are some lines over 80 columns in this patch. I'll fix that up. > Otherwise this looks fine. It would be really nice to fix this in clang, > though. I agree. I'm wondering whether it makes sense to roll with this patch, or to just not change anything and lean on Clang upstream to fix their bug. Full LTO is marked as "experimental" still. On the other hand, Android ships with it turned on, so how "experimental" can it really be? I don't have a strong read on the Clang ecosystem to know what makes most sense, to apply this or not. Do you have an opinion? Jason