Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <533df35d-fc61-e196-f01f-01da5294440f@oracle.com>
Date:   Fri, 21 Jan 2022 15:30:07 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.0
Subject: Re: [PATCH] xen/x2apic: enable x2apic mode when supported for HVM
Content-Language: en-US
To:     Roger Pau Monne <roger.pau@citrix.com>,
        linux-kernel@vger.kernel.org
Cc:     Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org
References: <a34aff19-4530-7f44-c849-4b3eb2aa3d00@oracle.com>
 <20220121090146.13697-1-roger.pau@citrix.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220121090146.13697-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UW9tZVVxNjd6eVRnT2xPb29wTWxWSmdRWDRvZm5KZVNBSHk5M1RSZEg0SzJa?=
 =?utf-8?B?L3FNQW1TU2gwaThqVkVVVDJWcnluN1RHWlQvcWNYOSt0SW02dHFRbFRDcnFZ?=
 =?utf-8?B?bmRCM2ZEY3hUVitxNXRTMGFPSHo3U1dMelVuaUpUT1A1ZEczaThmaW5jckdv?=
 =?utf-8?B?Qk5PTUFpMFpMRGFjbTFSem1wL0xkT1hDUnZDTE5uMlF3emUwejFENEFNMkpZ?=
 =?utf-8?B?T25MWXZ3N1IxcjVtNHRZM1hrNlVMVUhUVzJpc3poZXdsTEM0aXBLdUo1U25T?=
 =?utf-8?B?OS9CenZNZmY1K0RmaUFqRThRSjU1TGdtNjQ0WmF2QVN4bFI1SjZFYnQ3RlJm?=
 =?utf-8?B?Y0VOUWRlUWwxejVtZndsdTY3cUZzdTZXWGFObmkrblJkcTBjSTkvZkMxSUl4?=
 =?utf-8?B?WVVZaytXYTdjNG55K1RmSjcvMnpxUEJham0yUlVqUFpRYkw1SFVHMURjMVNW?=
 =?utf-8?B?bkpUYmlBZ01pcFd2RDVIYkxyZWNOclNpMElxTTUveWZsQ2VObERLUE5GTlVj?=
 =?utf-8?B?eENOQnl5ODdoT1ROWnU0Y1NDK0ZzRjVoYmsvTXlqaWd0MDV2c25HMlJqd1M5?=
 =?utf-8?B?dFBaWGRCT3Z3MUxRdHRxMjFJWDR1ZHFDd21MY2NNZktFRHRUd09pNUVPbXlo?=
 =?utf-8?B?YVMrbFFlUWFEMnA2UmM2VHJVWnh2eXNRK05rbWdPbHFRY0tsbjgwa3JlZTRi?=
 =?utf-8?B?bG5lVFFlZFlrTFV1bERIZzNXNjBaMkNTWUxLL0dVMjc5VnRGYzU0ZnV4WWls?=
 =?utf-8?B?akQ0YU5FbXV1M3ZSVit2eHZOS0pWa2l1bFdOSnMrZmZjaTZRSTk5VkRkRUtW?=
 =?utf-8?B?YmJnZEFkYTBCcFN3SXV5UHZCNzAyR3F6VFZCMTFpc1pQbTZCVmdMN1haOFVh?=
 =?utf-8?B?RzJvR3dmTktZT05idUJGYXBDYkhXQThGUjFHa1dsbzNMSzRFTytYSGdrNHJ5?=
 =?utf-8?B?Rjg4YlJDTzUvZ3lneUhaZHgrK0JLUDFPSW0zYWliTEUrak1Td2k2SHBNNXBC?=
 =?utf-8?B?Tm9rN2c4eHJrcUZQR0pKTkwzRVZZVXlUT2ZwUnR5Uy9SN1lRWm5IcStZK2dI?=
 =?utf-8?B?K0xvYllURFhxcHp4ajZtM0lrbGxRU2UxeVFTdGVMeTk2QnhyaGx4SmhrYXRt?=
 =?utf-8?B?em0zdUZ5NjRSS1BIQWEvTUNpelJnWXhkVENnUS9BU28xYmI4dFRaQnl1ZU80?=
 =?utf-8?B?cmptV0MyWUxNQnE5LzBEWXl3N3h1OFM5SXhLdHdDNE00ZWZ3bEtiQURMRGNs?=
 =?utf-8?B?aytWMDFISm9JandxRS9RZ2twSUxtUXZXOTkyelRzNWdxZkpPY2xWcXRTMTZS?=
 =?utf-8?B?QzlVMU10MXIyd0tLa0Zuemw3WmhtOXROQko5L1l0RmIxVmU4T1pOdlZreEgx?=
 =?utf-8?B?QzQ4ajd1RFlXaW5vOHFQTVEveTJHU2hndjlRMnVFK0V4aWZQd3o0bWJtNVpI?=
 =?utf-8?B?NUlVVDdaZXpsSjdoRkZzOW5jNjEwOG5GSWJlWEJKbUxwTUppR1RxREtURkd1?=
 =?utf-8?B?aStqMUJqN3F6Qk9rdS9HSXZ5bVJyNHFzSXlBZWZpS1NsZ1pMR0FTUVlJblpR?=
 =?utf-8?B?V2VhdUlDSjFXeXNEdFRuTFAvZ0ZBd1lQV0NYSnhkMHpDVGlkdnJoOXE1OUox?=
 =?utf-8?B?TklvcStwbHFSN1d5MHBwSUdJZTZkT1IydUhtU1dITDlocHVPamhtS3JtaThF?=
 =?utf-8?B?SUJPeU1XZm5wZnNrdzJCT1lBeUlNVVJVTDhpWE45akMzYUliTDhxZDhwdjkx?=
 =?utf-8?B?OTZHVklYTTcyRjcrL0JQYlJpKzdBSk5GNk52bU9WRXNaVUhBRy9IckNPcHVi?=
 =?utf-8?B?Ui9mOXlpdTVrL0N3bytTbkhkZHNwcVFCRXdPM0R1QVRLaFRkT2V6VDE1QWxN?=
 =?utf-8?B?ZW81ZU5Cb1VINXl2SENwRnRDSWM0bm42TllQN3RRRmZzYzJXUkQwc0xpaGJH?=
 =?utf-8?B?TURlR1lwK2FTV3BaMTFaMDdJNDVXWGgxTXdYTUdTbUJvZ2pRUzJNYXdaM1ph?=
 =?utf-8?B?V2R5citqZHR3ekg2Q3MyejFLREFnRGhwRGdqTFFxdExpZ0dVckNMY1ZITDVy?=
 =?utf-8?B?Z3hoeEk4VE5LU1pPWXdIc3JhZ2drVVR4M2FoaWZaKzRDNStlYmoyTXpDN2Q0?=
 =?utf-8?B?VHp0NDJBY1hmMnY1OEZIM1ZoaVZqZE5sdTNNMlAyTW5ucFRMVXFXUngwRzBn?=
 =?utf-8?B?NEhwZ01UZ0oxTnVsTmlEVTAxV0VBNEovb1F6OGNhMHNVRVZXb2pHMXNkanhj?=
 =?utf-8?Q?32HsPwHW0ckmgxEzJp3VOB4WRSzaqbipwPPzX1cZzE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5371b998-cfa6-4b57-8cff-08d9dd1cd3d7
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2022 20:30:13.4295
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W1F9UGYnpxegQR8NHJO7PK9wy2x1mZHexkpA+56Y1ITT2Vfu9baFIVF2azUYPuzkYo2uuhK8t38dbt5/7hozfl4CrQyVvBEdB/w8UUx93HM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2798
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10234 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 suspectscore=0
 spamscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2201210129
X-Proofpoint-ORIG-GUID: D_uzoI0Oo47GmcuTfH0RO8ugxOSaEMBf
X-Proofpoint-GUID: D_uzoI0Oo47GmcuTfH0RO8ugxOSaEMBf
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/21/22 4:01 AM, Roger Pau Monne wrote:
> There's no point in disabling x2APIC mode when running as a Xen HVM
> guest, just enable it when available.
>
> Remove some unneeded wrapping around the detection functions, and
> simply provide a xen_x2apic_available helper that's a wrapper around
> x2apic_supported.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>