Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 2/3] dt-bindings: pwm: Document clk based PWM
 controller
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        Nikita Travkin <nikita@trvn.ru>
Cc:     thierry.reding@gmail.com, lee.jones@linaro.org,
        u.kleine-koenig@pengutronix.de, robh+dt@kernel.org,
        sboyd@kernel.org, linus.walleij@linaro.org, masneyb@onstation.org,
        linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        ~postmarketos/upstreaming@lists.sr.ht
References: <20220120161442.140800-1-nikita@trvn.ru>
 <20220120161442.140800-3-nikita@trvn.ru>
 <CAJKOXPc249vbZZwjXxfg+mEgqQe0P8uhf1GTg8Db9sBeMY3+tA@mail.gmail.com>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <1d9b1db0-981d-f77a-063a-69c8a4d53343@seco.com>
Date:   Fri, 21 Jan 2022 16:34:03 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <CAJKOXPc249vbZZwjXxfg+mEgqQe0P8uhf1GTg8Db9sBeMY3+tA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVZ6ZVh0SzVaM3pwRmZWV1pqT1R2ZWJHVWVYU2xtSmZ4STIrQkcrQmFLTFZ0?=
 =?utf-8?B?MVdwaGU5MFc5aVkvbllMb2pTV052WGhzSldRZlFreHNDYTV4eGZIRjlmMjJH?=
 =?utf-8?B?cGNaU2MyNTZkU2RHKzcxOGRzVHpYblRlbElnY0x1L0R2ZEdKWEhuV1pUaXZS?=
 =?utf-8?B?ZWl6Q2xuVVUxUlFGZFVHYXVGVHdvS1dibXVDQlovT1RHaVJ1S1ZMUmRVbkFK?=
 =?utf-8?B?dnBPU2JkWkRERzA4NTExUVdSekdiTEhPMzN5Qmx4anEyMWNGNWh0OXJZK2F6?=
 =?utf-8?B?MnNFS3VYNVRIRFM4OThBSE1tQklEWkJ6ZzM1VlJXblRlVE54cGpSSTVqWWF1?=
 =?utf-8?B?VFM0cjRUQ1IvZE8vbFd0blRkVnlOaVR6TzU2aUZIZVlRdmg1WVAzOTg2MFNC?=
 =?utf-8?B?TmJwQ215ejBpQURyczE3Sk1kb0RXd0JnanphTnFkZFZyS1lsNWkyMDNIRklP?=
 =?utf-8?B?V0NjNGprSG5QN0FhN090SkNoQzVrWkdFNUNGcGg5K04xak9oUVYxWHFmNUlm?=
 =?utf-8?B?ejNydHk0TjQ1YnhwZWxMell3T1NDREdxcnZhWTZFRGdMNE9HWXhVamZWY21i?=
 =?utf-8?B?dkowRTFiSU5JUmc1aERLL05PMklEYXdkdEpEVThPZEJIOEQyZjVpSmZYTTg1?=
 =?utf-8?B?c3p4Q3hLOFV0K2RoVm1RWE5rNU9JdXF0NEdtSXZjKzkxd3JDS0JPRFNEVlZp?=
 =?utf-8?B?cjhIdWlISnNkSk5hMWloSDJqT2J2N1VNc3JmR0N4WHlNbGVQdkJTM1RCOWYv?=
 =?utf-8?B?c1VlRGdJek8rbW8yWTdvSWZrOG1RekVrTEhEbDZ1NGNqVFRhTzJab0lXZllw?=
 =?utf-8?B?cmZxUStudk84WWptSE5RREdSYUx3ZlJFYi91SXg0VWk5bWJQdlhpYjVyeUdh?=
 =?utf-8?B?cllNQzJLUzMwd2lza2k2dlZ2SDJzMUdZTjMwRXplRkMxaWwvVDFuV2RLNnNO?=
 =?utf-8?B?ODZubnBjOW5KandnMmxtVGRETkg3Y1ViRlkwMm9BMFM0cGkxTVNmMk9qb2M3?=
 =?utf-8?B?em5GbFVib1ZyaDRKdHBBL1Fyd1ZtMGNRbkJGNHRLbmVjcFB4VUp4T3N2ajda?=
 =?utf-8?B?cFZrMGVxeDBJR2hnRTdVM3kvZmFENzJVazBwNjN4ZzhBSU84d25yajNYaUVQ?=
 =?utf-8?B?a3RCWmNvd0J1Tkh2MXVoSmJ4b3ZHSGNEVy96QTRSK2tmSTVZWkpHQVZ2NVFE?=
 =?utf-8?B?ZkFpckRZTE9ocFRSOGZ2dDJGYzB3clNWVGpsM2EySzVEVXAwTEhsNVF6cncx?=
 =?utf-8?B?UkhGa1dJc0E0ZGdaeFdxMnN2MFhvcS81UXBkcDZMNEtTR0p3RWtTeURaSmZT?=
 =?utf-8?B?WUpRb0Y3THpDU25CZWFrVWgrd2RmNzdlZFRpT0ZSL29ua3BYYVc4VThFdms2?=
 =?utf-8?B?WXpRUkZTampnYlEvVExkVFgvUEhQS3VSMmJjaE1iSEhzRjFzU1hnYktPWTlr?=
 =?utf-8?B?QU9ZMXRKbXNTblY0dmliL0NhWVBTdjA5WC9oSFBQbm5URUZQeVU2V3ZJSHd0?=
 =?utf-8?B?Q0owNWh5U0FFYnorUEJRQXFvUmNnOHFRdE1FaWR4N29adVJyMXZSWWh1U3ZS?=
 =?utf-8?B?alYvSUpuU1lxUlRScm5ibDYrV0tXdU42UmtlVDBMWFgvbzZjUDl5TzFXUm9D?=
 =?utf-8?B?VFppMlpaMXFNZUJNVGRCeENZdCtaV05ZQklkSkNYMHhsYWcxNlA2TGJIVnRp?=
 =?utf-8?B?MEhEbUhCeW5KaW1UMCtWMFpJT1NhRDVrbWdoRHk5SjBBMUJKYTB5NDdwUFda?=
 =?utf-8?B?MjlEK09wYS91N3U1SlFJejkvVk5RRWxJRGpSTExaM0F5bVdIU2ExTWhNVnNR?=
 =?utf-8?B?UWdsOElvSDdJR1NoRS8zMlFCUFRRalBlMGtnNUJ3K0lIdExaZWYzTnIrbGZJ?=
 =?utf-8?B?Vk9WZll1U01mYUdqZy9XNWc1SlVNVGduczB2V3NSU2xsS3hCZys2RUU5SDZY?=
 =?utf-8?B?ZysrN0hiNG9FMzd1Zm1JYjNnNGZHMjlNTmg2RTNtNEhtTlc3czdFNXc5ellX?=
 =?utf-8?B?MGYzLzJ5YXVZdlFUYllJU2Z3cFowWmcwZFlJTEp3QkllZktCeG9zYUVjaFJD?=
 =?utf-8?B?Slloc1VUZmdvbGV0T3JyYk5TMU5MZzJtMFMvV3dsQWZ5bFBPcjFVeEdhM2Vy?=
 =?utf-8?B?ekQyUXJvbFdndU9rNDlvbklVWjY5dnc0Qm40RDRlSmc3UWc4a0REeDdLUCsv?=
 =?utf-8?Q?1x7zQahFPbUJBRKc95UmBTU=3D?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8cac6701-3aa2-40cb-2bb9-08d9dd25c19e
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2022 21:34:08.4032
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LGI/xHc+85gMcXrsjdJ5RmH8Y9v3xFUoRknzwSFc1pBvf2f0Fcr8MdTQ9s9ApIAfOQjcf/LSICsKYvX98pj/bw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR03MB5195
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/21/22 2:34 AM, Krzysztof Kozlowski wrote:
> On Thu, 20 Jan 2022 at 17:15, Nikita Travkin <nikita@trvn.ru> wrote:
>>
>> Add YAML devicetree binding for clk based PWM controller
>>
>> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
>> --
>> Changes in v2:
>>  - fix the file name.
>> ---
>>  .../devicetree/bindings/pwm/clk-pwm.yaml      | 45 +++++++++++++++++++
>>  1 file changed, 45 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/pwm/clk-pwm.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/clk-pwm.yaml b/Documentation/devicetree/bindings/pwm/clk-pwm.yaml
>> new file mode 100644
>> index 000000000000..4fb2c1baaad4
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pwm/clk-pwm.yaml
>> @@ -0,0 +1,45 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/pwm/clk-pwm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Clock based PWM controller
>> +
>> +maintainers:
>> +  - Nikita Travkin <nikita@trvn.ru>
>> +
>> +description: |
>> +  Some systems have clocks that can be exposed to external devices.
>> +  (e.g. by muxing them to GPIO pins)
>> +  It's often possible to control duty-cycle of such clocks which makes them
>> +  suitable for generating PWM signal.
>> +
>> +allOf:
>> +  - $ref: pwm.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    const: clk-pwm
>> +
>> +  clocks:
>> +    description: Clock used to generate the signal.
>> +    maxItems: 1
>> +
>> +  "#pwm-cells":
>> +    const: 2
>> +
>> +unevaluatedProperties: false
>> +
>> +required:
>> +  - clocks
>> +
>> +examples:
>> +  - |
>> +    pwm-flash {
> 
> Node names should be generic (see devicetree specification), so just "pwm".

And then what will you do if you have two clock-based pwms?

--Sean