Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <81487bcb-6f48-9a15-2884-fb1441210d2f@oracle.com>
Date:   Sat, 22 Jan 2022 05:50:41 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] btrfs: initialize variable cancel
Content-Language: en-US
To:     trix@redhat.com, clm@fb.com, josef@toxicpanda.com,
        dsterba@suse.com, nathan@kernel.org, ndesaulniers@google.com
Cc:     linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev
References: <20220121134522.832207-1-trix@redhat.com>
From:   Anand Jain <anand.jain@oracle.com>
In-Reply-To: <20220121134522.832207-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0dnS1UrUDlDcGt3T3NFZ215ajVwVk90NVBiV2RkY2orTDlIUEVPZmV5eWht?=
 =?utf-8?B?MkNaK0xkMm51YzNidGR2R0U0SUJ4YlhFMGNnRjlZTDV2V3B3MG96MG56alRW?=
 =?utf-8?B?cEQzeVBqT21UMy9obHJpU3ZSZWk2djlTUjNzbnVYNkFIeklYOVFxQThkSUJZ?=
 =?utf-8?B?ZmxCNldvZy9ucWhUTUhrMWR4allZMVNEK2NkU3ZLYXk4aE5mbjNSdGE2K0k5?=
 =?utf-8?B?N1RjanNPRDZaQlVYU0dQQVlTaHJuTVhEV2pKR0J4bTR5clJpRXVHYkJJMDl2?=
 =?utf-8?B?STM5NW43Z1JQby9ic1d5QUg0QkRpSlNIb1NHWGovV3gvZ2ExMGk4NlJLclFq?=
 =?utf-8?B?aENXbklicjRYZ3J6dmFrZnQ5MHVuOWFpRW1uS3VKSjlVWnNFWlIvNVZDc09k?=
 =?utf-8?B?bTdiQjNrc09YY1h5aklIeVNTT1J3anN1bHdwRkh6allNWFlndittSG9wbjh6?=
 =?utf-8?B?aFBRYTd0eXlzVkd6eUZkczAxWDV6eDh6OXcvcWtaL1JiQmhCUFlxVk1TLzlF?=
 =?utf-8?B?U2VteE1IS0RTNy93VGVIR1dKYVl5SW1BWGxrYlZmd3Z2aU5Iem1La1czQVRu?=
 =?utf-8?B?ZjB5SzV2TGVBRE5MczR5U1JFUmIxcHFlam1PSXhBVnhmR0ZYN1ZpOGlqSmtm?=
 =?utf-8?B?WVJOQkN2WXBaQzk1UkhxMU5kQ050Vzl0TWtmVEVzOGVtbVVnb1p6V3FBN3l3?=
 =?utf-8?B?UVdpam9VK2ZKaFVwalVNQTgzbnZmSWNPYnBlK1ZEYU15YVkydFRDTys3djN2?=
 =?utf-8?B?ZHdUK0RXV0dQYWFIVW91NDJIRGdZU0c0UjdzNGhTTTNrNklZejVUVjJSVU5E?=
 =?utf-8?B?aktXdmdqc3ZhcFBhZ3pIUW5KZ2NvQVBGMTlQR0Y2TFV3elJGdnVMaFF4M3FK?=
 =?utf-8?B?OUcwTG9nRWg4dmxRcGZqc3FEd1I2VUgzVmpKTnJaSEUwbDZ3elhrcERHZFhh?=
 =?utf-8?B?NFFNOXo5WnB0QzB0ekk4NDJhRkxIZG9kb1RiYzdwZ09CdzV4UDBKSnFBSXkr?=
 =?utf-8?B?K0VCbk9TM3ppRzF6R0dSVjlYcXhFVXBnbURIYUxnTURodElBUUJEZ2RNK0FK?=
 =?utf-8?B?SWJZRkVDQlBYSHdqOUtINVYwT0NOaDB2cURsVHBWaVpQLzR0SUZFckcwM0Yx?=
 =?utf-8?B?Mm54Vlh2TVRsR3Brc01qSkNmYzZOWjdId3VpaWRXcENOVFU1N1M5SnV1Z3FC?=
 =?utf-8?B?bklFSWpkRjhIR0FMM29hUm9JVmloU2YwZndxeU9LMFBKY3FDbE84TXB3aUhW?=
 =?utf-8?B?RVEzSmZCZms0WEszOFd0Tkk3UCtGemovZ3J4eWN1V1JJdHp5UjBqNzQ3c1lK?=
 =?utf-8?B?L040RU1sMDVvbVcrbEFkZUcrL3llbitDSEUyOUY1a0QyTzh0Yit0WkQ5SW1U?=
 =?utf-8?B?VTdkNjFFRHU1bzkwdUZ5b1E3YkVGMTdleGg1MWFLUkI1dXFtUlBHTjZNRHlX?=
 =?utf-8?B?UWd0OS94K1JYRHZ3VmQxQ0ZDdkRTSzlwcERZckZoN2t1OVBXbHluL1IzV29i?=
 =?utf-8?B?ZW1ud0dBbDE1Wnl0OE1wM1JwOTRVYlJna3ZCbHp5TStPcW53ckJiWjJ4RXk5?=
 =?utf-8?B?NCtzSzlhdHo5NnNEZklVNzJVSldMc2pqZllUcndITUR1LzVZOHRTeEZ1c0dk?=
 =?utf-8?B?M1ZnRnlHUkdPVElwVkUrVlN5emZNMWxocnNvajduNmM5MmpmRmdYZnBsZjhY?=
 =?utf-8?B?RTRRVjF1MUcyUE1xUlJOUnZScHpzTXBmMklta0FUZVBqazRxMFN5UkZ0M2lD?=
 =?utf-8?B?MGtQS1cvWEpUcyt4bWhWMmtpTi95TXJ2V0JpQ3pPY2lVc1NYUUVWQTJUT2ZS?=
 =?utf-8?B?Umk3OU51MWZRRTNuUWlLUCtPUmJITWxOV2VOSmZpdW5TTysrVEpUczFWV0xB?=
 =?utf-8?B?NVl5cEloQzNiSGVsQ2c1RmwwVFRMN0ZjaVloSnkrYzRkSjZSTmQ3aldqem1u?=
 =?utf-8?B?b05sMDFQUTJIYk9GcHRKcEJ2ME8rRHpuNWl5SVk1MzBFY1VCdzZ1TVRFa2lF?=
 =?utf-8?B?MGlsS1Y0MXJvK0U2MElsYktlZUR6aDJDUEFGVk9HMUZBdjhJUXphSUg2cXlK?=
 =?utf-8?B?K0VJZTJ6UGd3TmdZcnc0U2pHN2poVFZpNzZlanIxOGxmd21zQVU3OHV4eE9j?=
 =?utf-8?B?V3lWU1NuOHI4QmRvdDZxeU5RSnMrNlh0NThKVkJDcnljVDlUZFFCMFo5VENI?=
 =?utf-8?Q?iwAMQQeCa+1tk6F1gVh3R+g=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab187dd2-7afa-4066-61cb-08d9dd281807
X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB4128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2022 21:50:52.4796
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HNNEZLa7kPaYWgRzdSJtaWPAHYG2J3VN2UtWeSrllLcavBUG47L0/E9Zd/DUlqVCM3377dtb0i7Tnb8xJElXsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB2443
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10234 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 spamscore=0
 suspectscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2201210138
X-Proofpoint-GUID: C8UiohaTkxLqRWcAJ33EbF1KRPw8VZ_7
X-Proofpoint-ORIG-GUID: C8UiohaTkxLqRWcAJ33EbF1KRPw8VZ_7
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 21/01/2022 21:45, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> Clang static analysis reports this problem
> ioctl.c:3333:8: warning: 3rd function call argument is an
>    uninitialized value
>      ret = exclop_start_or_cancel_reloc(fs_info,
> 
> cancel is only set in one branch of an if-check and is
> always used.  So initialize to false.
> 
> Fixes: 1a15eb724aae ("btrfs: use btrfs_get_dev_args_from_path in dev removal ioctls")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>   fs/btrfs/ioctl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 190ad8af4f45a..26e82379747f8 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -3308,7 +3308,7 @@ static long btrfs_ioctl_rm_dev(struct file *file, void __user *arg)
>   	struct block_device *bdev = NULL;
>   	fmode_t mode;
>   	int ret;
> -	bool cancel;
> +	bool cancel = false;


  Reviewed-by: Anand Jain <anand.jain@oracle.com>

Thanks,
Anand

>   
>   	if (!capable(CAP_SYS_ADMIN))
>   		return -EPERM;