Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Alexei Starovoitov <alexei.starovoitov@gmail.com>
CC:     Song Liu <song@kernel.org>, bpf <bpf@vger.kernel.org>,
        Network Development <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "Alexei Starovoitov" <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "Andrii Nakryiko" <andrii@kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        "Peter Zijlstra" <peterz@infradead.org>, X86 ML <x86@kernel.org>
Subject: Re: [PATCH v6 bpf-next 6/7] bpf: introduce bpf_prog_pack allocator
Thread-Topic: [PATCH v6 bpf-next 6/7] bpf: introduce bpf_prog_pack allocator
Thread-Index: AQHYDwA7v2eTErzZP02KrqTA2Ue2qKxuJqkAgAAH3QCAAAUSgIAABaKAgAAC8wCAAAUaAA==
Date:   Sat, 22 Jan 2022 01:30:30 +0000
Message-ID: <5F4DEFB2-5F5A-4703-B5E5-BBCE05CD3651@fb.com>
References: <20220121194926.1970172-1-song@kernel.org>
 <20220121194926.1970172-7-song@kernel.org>
 <CAADnVQK6+gWTUDo2z1H6AE5_DtuBBetW+VTwwKz03tpVdfuoHA@mail.gmail.com>
 <7393B983-3295-4B14-9528-B7BD04A82709@fb.com>
 <CAADnVQJLHXaU7tUJN=EM-Nt28xtu4vw9+Ox_uQsjh-E-4VNKoA@mail.gmail.com>
 <5407DA0E-C0F8-4DA9-B407-3DE657301BB2@fb.com>
 <CAADnVQLOpgGG9qfR4EAgzrdMrfSg9ftCY=9psR46GeBWP7aDvQ@mail.gmail.com>
In-Reply-To: <CAADnVQLOpgGG9qfR4EAgzrdMrfSg9ftCY=9psR46GeBWP7aDvQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yR9qOf7IxHEOmxPYYQbMuncmH3T8v9P7rheFu0ZSXnwodNcrcM8Tf/4gXyKq?=
 =?us-ascii?Q?mHgCYWzbwuNqFUqC77GrHjKjLwI7jbi/5c0NlfrKrusQpnyJ0apvWZJQK28B?=
 =?us-ascii?Q?GbH1QA9vMiTl5+VoW1qROidZnbeJvWlxVICsSrm9Hygv5vi2XAhAUIg5NjSa?=
 =?us-ascii?Q?PnH7zERmm4SdKyqwwYfgO5fp6/99v3l20Vm/g6vKJjuwrz7USj+VL6F/x2pY?=
 =?us-ascii?Q?IlXPPJqkFNGCVeP0LZjGxYKbvtWQcdqZM/kf9/NEuNiBfbEu2ZDCFVqAkFtb?=
 =?us-ascii?Q?9scfSxjdfhhQn9pJSd52LiIOB274BDh3MzcqcVYDU/qs3XqP49J0ORGrvsMU?=
 =?us-ascii?Q?xqNu8iwuPqEtueLILM+F59HbdoWff52mqz0ZFPULPemTRuHGkcapkVFFh2Id?=
 =?us-ascii?Q?Aw9nr4E9PmyAbEe9Z0R2H4L3jsuIEey251pdFnzWR2ECThSD3GWd5haFl1bl?=
 =?us-ascii?Q?v0KqieqQtICEfsU5TQ/8JICC+ptGPPMTgTIVSrWsJYavkO0vsQ1hPAI3jjWY?=
 =?us-ascii?Q?7QEGwU41jMY39LKN6wnuSUyc4NbO2EDPor3y77WM26TeHzC0l1MKSS5yLTYZ?=
 =?us-ascii?Q?NaVmSy0K3fO6ySrRYIRAPJgGx4n0X6+rd1i3GmHLJUspMyP6NR4Kh7bbwFnU?=
 =?us-ascii?Q?IHSJVgLLN9rRCikYYnuY2d3Qlb8c1g84srcbBrZCzheLqsyPMpUhzizDx3TT?=
 =?us-ascii?Q?b/obQUbyUKMwCYfZwzn+j7MABMx2PzZZmt4vP8ZLd+4o6zMSWas4xCsBNTqW?=
 =?us-ascii?Q?2U737lqHXG5u5fOMEhhtZfIjhyb+Kc22BMs56D7x3VYyEhMaOWxx4eO3p6AJ?=
 =?us-ascii?Q?zOeUjzEP3D4HEcc1pwJYsO7oQTZeaaraajejs+pB7rV+TaEed/DLhLqS9xdD?=
 =?us-ascii?Q?+QjNmn0v5btdqa/w6Vm2WAK5Fij83DKlYfn9Z4WUAfGGMAN1SDS8OI6h56Al?=
 =?us-ascii?Q?E9vWwoBi/N18ReLKFfiIProj+uZ+faCGEHqC8B/BSxpH6zIpvOWpOcuEWVAf?=
 =?us-ascii?Q?NqNBBeWD9cz2op9E66fxMgSPd+vDR0Ihmd6RSdwZNljz8tpB+02xF6EkhL9P?=
 =?us-ascii?Q?LD8BEyynGtBilU0rvOBpa7Y9rFNg9EPb+GG+Wc917vphW1WHjf+mZd64ySsu?=
 =?us-ascii?Q?rvm3hljBENg+mbt1kNRP7nxqbe6jXE1HgMsKRB6GuZPI/o8nsIzHxdkdPaY0?=
 =?us-ascii?Q?5ay3YRGx/0fg5BTdeULdrvJZRCI9pPXW2++sEAhknauNVi3VxY6UmRWgoQur?=
 =?us-ascii?Q?m07YELehP0tNZvOS0Ak97Z1aQndVs1EUIAb2Eg1EdrUs1snSNQp+Jku/0rs+?=
 =?us-ascii?Q?rmpoaMgnKtvDzZ6HPpQ0W6TGAwGl8nr6ShzNGMxqdHZlLWsPdgoU9MHhqe17?=
 =?us-ascii?Q?c3y3+HCD4XjWV8DZtLCggn9FR21aekbKOARE3sosY1NOBSt5wL3KvzycTqHU?=
 =?us-ascii?Q?GqhAjzQFOsVCXBd6wjj1IuGPZzHzaqNRsPq4B+whkTAHARnuJvC1aBLpmKkn?=
 =?us-ascii?Q?OR3KgcxT045bIHNmTJiNLN0tBWAnIfamQxt5I09wKVZFZpuM3ckI9VuR47GM?=
 =?us-ascii?Q?e63nffpf486wDUWEDD0VHujjMTtB7LRaeUlpbPcq5xiivhdpYYeV/CjYgLXi?=
 =?us-ascii?Q?jFq7inFu96GXpMTeLu0/iGrWJVeM3ivBAY1qKAiSbN8W4mH/GGUQRpNiwJJN?=
 =?us-ascii?Q?zxRwfg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <AC676B3E2A828C4CB6939F5EF792F306@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a18ee87b-d42d-45d7-51e2-08d9dd46c73b
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2022 01:30:30.8858
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uoRWJqLv9OZi4likXSGR7YvTk6rp1Gw3R6wS7f4taZbOcsPwCsEx749U4UoUmmO5xIXRc2EtPKK9Lhg2q2Veuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1137
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: wn1LBgBLqcBZuGY14NHNGqVgCJ690y7s
X-Proofpoint-GUID: wn1LBgBLqcBZuGY14NHNGqVgCJ690y7s
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-21_10,2022-01-21_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 mlxscore=0 adultscore=0
 clxscore=1015 bulkscore=0 impostorscore=0 spamscore=0 phishscore=0
 suspectscore=0 mlxlogscore=848 lowpriorityscore=0 malwarescore=0
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2201220005
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jan 21, 2022, at 5:12 PM, Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
> 
> On Fri, Jan 21, 2022 at 5:01 PM Song Liu <songliubraving@fb.com> wrote:
>> 
>> In this way, we need to allocate rw_image here, and free it in
>> bpf_jit_comp.c. This feels a little weird to me, but I guess that
>> is still the cleanest solution for now.
> 
> You mean inside bpf_jit_binary_alloc?
> That won't be arch independent.
> It needs to be split into generic piece that stays in core.c
> and callbacks like bpf_jit_fill_hole_t
> or into multiple helpers with prep in-between.
> Don't worry if all archs need to be touched.

How about we introduce callback bpf_jit_set_header_size_t? Then we
can split x86's jit_fill_hole() into two functions, one to fill the
hole, the other to set size. The rest of the logic gonna stay the same. 

Archs that do not use bpf_prog_pack won't need bpf_jit_set_header_size_t. 

Thanks,
Song